Convert to TF 0.12. Add tests. Add Codefresh test pipeline (#20)

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

Author: aknysh

.travis.yml

@@ -186,7 +186,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright 2017-2018 Cloud Posse, LLC
+   Copyright 2017-2019 Cloud Posse, LLC
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.

LICENSE

@@ -5,10 +5,10 @@
 
 # terraform-aws-acm-request-certificate
 
- [![Build Status](https://travis-ci.org/cloudposse/terraform-aws-acm-request-certificate.svg?branch=master)](https://travis-ci.org/cloudposse/terraform-aws-acm-request-certificate) [![Latest Release](https://img.shields.io/github/release/cloudposse/terraform-aws-acm-request-certificate.svg)](https://github.com/cloudposse/terraform-aws-acm-request-certificate/releases/latest) [![Slack Community](https://slack.cloudposse.com/badge.svg)](https://slack.cloudposse.com)
+ [![Codefresh Build Status](https://g.codefresh.io/api/badges/pipeline/cloudposse/terraform-modules%2Fterraform-aws-acm-request-certificate?type=cf-1)](https://g.codefresh.io/public/accounts/cloudposse/pipelines/5d13bc4da6fc75502872e5f8) [![Latest Release](https://img.shields.io/github/release/cloudposse/terraform-aws-acm-request-certificate.svg)](https://github.com/cloudposse/terraform-aws-acm-request-certificate/releases/latest) [![Slack Community](https://slack.cloudposse.com/badge.svg)](https://slack.cloudposse.com)
 
 
-Terraform module to request an ACM certificate for a domain and add a CNAME record to the DNS zone to complete certificate validation 
+Terraform module to request an ACM certificate for a domain and add a CNAME record to the DNS zone to complete certificate validation
 
 
 ---
@@ -44,13 +44,18 @@ We literally have [*hundreds of terraform modules*][terraform_modules] that are
 
 ## Usage
 
+
+**IMPORTANT:** The `master` branch is used in `source` just as an example. In your code, do not pin to `master` because there may be breaking changes between releases.
+Instead pin to the release tag (e.g. `?ref=tags/x.y.z`) of one of our [latest releases](https://github.com/cloudposse/terraform-aws-acm-request-certificate/releases).
+
+
 This example will request an SSL certificate for `example.com` domain
 
 ```hcl
 module "acm_request_certificate" {
   source                            = "git::https://github.com/cloudposse/terraform-aws-acm-request-certificate.git?ref=master"
   domain_name                       = "example.com"
-  process_domain_validation_options = "true"
+  process_domain_validation_options = true
   ttl                               = "300"
 }
 ```
@@ -61,7 +66,7 @@ This example will request an SSL certificate for `example.com` domain and all it
 module "acm_request_certificate" {
   source                            = "git::https://github.com/cloudposse/terraform-aws-acm-request-certificate.git?ref=master"
   domain_name                       = "example.com"
-  process_domain_validation_options = "true"
+  process_domain_validation_options = true
   ttl                               = "300"
   subject_alternative_names         = ["*.example.com"]
 }
@@ -87,11 +92,13 @@ Available targets:
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
 | domain_name | A domain name for which the certificate should be issued | string | - | yes |
-| process_domain_validation_options | Flag to enable/disable processing of the record to add to the DNS zone to complete certificate validation | string | `true` | no |
-| subject_alternative_names | A list of domains that should be SANs in the issued certificate | list | `<list>` | no |
-| tags | Additional tags (e.g. map('BusinessUnit`,`XYZ`) | map | `<map>` | no |
+| enabled | Set to false to prevent the module from creating or accessing any resources | bool | `true` | no |
+| process_domain_validation_options | Flag to enable/disable processing of the record to add to the DNS zone to complete certificate validation | bool | `true` | no |
+| subject_alternative_names | A list of domains that should be SANs in the issued certificate | list(string) | `<list>` | no |
+| tags | Additional tags (e.g. map('BusinessUnit`,`XYZ`) | map(string) | `<map>` | no |
 | ttl | The TTL of the record to add to the DNS zone to complete certificate validation | string | `300` | no |
-| validation_method | Which method to use for validation, DNS or EMAIL | string | `DNS` | no |
+| validation_method | Method to use for validation, DNS or EMAIL | string | `DNS` | no |
+| wait_for_certificate_issued | Whether to wait for the certificate to be issued by ACM (the certificate status changed from `Pending Validation` to `Issued`) | bool | `false` | no |
 | zone_name | The name of the desired Route53 Hosted Zone | string | `` | no |
 
 ## Outputs
@@ -100,7 +107,7 @@ Available targets:
 |------|-------------|
 | arn | The ARN of the certificate |
 | domain_validation_options | CNAME records that are added to the DNS zone to complete certificate validation |
-| id | The ARN of the certificate |
+| id | The ID of the certificate |
 
 
 
@@ -238,11 +245,15 @@ Check out [our other projects][github], [follow us on twitter][twitter], [apply
 
 ### Contributors
 
-|  [![Andriy Knysh][aknysh_avatar]][aknysh_homepage]<br/>[Andriy Knysh][aknysh_homepage] | [![Vladimir][SweetOps_avatar]][SweetOps_homepage]<br/>[Vladimir][SweetOps_homepage] |
-|---|---|
+|  [![Andriy Knysh][aknysh_avatar]][aknysh_homepage]<br/>[Andriy Knysh][aknysh_homepage] | [![Erik Osterman][osterman_avatar]][osterman_homepage]<br/>[Erik Osterman][osterman_homepage] | [![Igor Rodionov][goruha_avatar]][goruha_homepage]<br/>[Igor Rodionov][goruha_homepage] | [![Vladimir][SweetOps_avatar]][SweetOps_homepage]<br/>[Vladimir][SweetOps_homepage] |
+|---|---|---|---|
 
   [aknysh_homepage]: https://github.com/aknysh
   [aknysh_avatar]: https://github.com/aknysh.png?size=150
+  [osterman_homepage]: https://github.com/osterman
+  [osterman_avatar]: https://github.com/osterman.png?size=150
+  [goruha_homepage]: https://github.com/goruha
+  [goruha_avatar]: https://github.com/goruha.png?size=150
   [SweetOps_homepage]: https://github.com/SweetOps
   [SweetOps_avatar]: https://github.com/SweetOps.png?size=150
 

README.md

@@ -34,9 +34,9 @@ github_repo: cloudposse/terraform-aws-acm-request-certificate
 
 # Badges to display
 badges:
-  - name: "Build Status"
-    image: "https://travis-ci.org/cloudposse/terraform-aws-acm-request-certificate.svg?branch=master"
-    url: "https://travis-ci.org/cloudposse/terraform-aws-acm-request-certificate"
+  - name: "Codefresh Build Status"
+    image: "https://g.codefresh.io/api/badges/pipeline/cloudposse/terraform-modules%2Fterraform-aws-acm-request-certificate?type=cf-1"
+    url: "https://g.codefresh.io/public/accounts/cloudposse/pipelines/5d13bc4da6fc75502872e5f8"
   - name: "Latest Release"
     image: "https://img.shields.io/github/release/cloudposse/terraform-aws-acm-request-certificate.svg"
     url: "https://github.com/cloudposse/terraform-aws-acm-request-certificate/releases/latest"
@@ -54,7 +54,7 @@ related:
 
 # Short description of this project
 description: |-
-  Terraform module to request an ACM certificate for a domain and add a CNAME record to the DNS zone to complete certificate validation 
+  Terraform module to request an ACM certificate for a domain and add a CNAME record to the DNS zone to complete certificate validation
 
 # How to use this project
 usage: |-
@@ -64,7 +64,7 @@ usage: |-
   module "acm_request_certificate" {
     source                            = "git::https://github.com/cloudposse/terraform-aws-acm-request-certificate.git?ref=master"
     domain_name                       = "example.com"
-    process_domain_validation_options = "true"
+    process_domain_validation_options = true
     ttl                               = "300"
   }
   ```
@@ -75,7 +75,7 @@ usage: |-
   module "acm_request_certificate" {
     source                            = "git::https://github.com/cloudposse/terraform-aws-acm-request-certificate.git?ref=master"
     domain_name                       = "example.com"
-    process_domain_validation_options = "true"
+    process_domain_validation_options = true
     ttl                               = "300"
     subject_alternative_names         = ["*.example.com"]
   }
@@ -89,5 +89,9 @@ include:
 contributors:
   - name: "Andriy Knysh"
     github: "aknysh"
+  - name: "Erik Osterman"
+    github: "osterman"
+  - name: "Igor Rodionov"
+    github: "goruha"
   - name: "Vladimir"
-    github: "SweetOps"
+    github: "SweetOps"

README.yaml

@@ -0,0 +1,74 @@
+version: '1.0'
+
+stages:
+  - Prepare
+  - Test
+
+steps:
+  wait:
+    title: Wait
+    stage: Prepare
+    image: codefresh/cli:latest
+    commands:
+      - codefresh get builds --pipeline=${{CF_REPO_NAME}} --status running --limit 1000 -o json | jq --arg id ${{CF_BUILD_ID}} -ser 'flatten|.[-1].id==$id'
+    retry:
+      maxAttempts: 10
+      delay: 20
+      exponentialFactor: 1.1
+
+  main_clone:
+    title: "Clone repository"
+    type: git-clone
+    stage: Prepare
+    description: "Initialize"
+    repo: ${{CF_REPO_OWNER}}/${{CF_REPO_NAME}}
+    git: CF-default
+    revision: ${{CF_REVISION}}
+
+  clean_init:
+    title: Prepare build-harness and test-harness
+    image: ${{TEST_IMAGE}}
+    stage: Prepare
+    commands:
+      - cf_export PATH="/usr/local/terraform/0.12/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
+      - make init
+      - git -C build-harness checkout master
+      - make -C test/ clean init TEST_HARNESS_BRANCH=master
+      - make -C test/src clean init
+      - find . -type d -name '.terraform' | xargs rm -rf
+      - find . -type f -name 'terraform.tfstate*' -exec rm -f {} \;
+
+  test:
+    type: "parallel"
+    title: "Run tests"
+    description: "Run all tests in parallel"
+    stage: Test
+    steps:
+      test_readme_lint:
+        title: "Test README.md updated"
+        stage: "Test"
+        image: ${{TEST_IMAGE}}
+        description: Test "readme/lint"
+        commands:
+          - make readme/lint
+
+      test_module:
+        title: Test module with bats
+        image: ${{TEST_IMAGE}}
+        stage: Test
+        commands:
+          - make -C test/ module
+
+      test_examples_complete:
+        title: Test "examples/complete" with bats
+        image: ${{TEST_IMAGE}}
+        stage: Test
+        commands:
+          - make -C test/ examples/complete
+
+      test_examples_complete_terratest:
+        title: Test "examples/complete" with terratest
+        image: ${{TEST_IMAGE}}
+        stage: Test
+        commands:
+          - make -C test/src

codefresh/test.yml

@@ -3,11 +3,13 @@
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
 | domain_name | A domain name for which the certificate should be issued | string | - | yes |
-| process_domain_validation_options | Flag to enable/disable processing of the record to add to the DNS zone to complete certificate validation | string | `true` | no |
-| subject_alternative_names | A list of domains that should be SANs in the issued certificate | list | `<list>` | no |
-| tags | Additional tags (e.g. map('BusinessUnit`,`XYZ`) | map | `<map>` | no |
+| enabled | Set to false to prevent the module from creating or accessing any resources | bool | `true` | no |
+| process_domain_validation_options | Flag to enable/disable processing of the record to add to the DNS zone to complete certificate validation | bool | `true` | no |
+| subject_alternative_names | A list of domains that should be SANs in the issued certificate | list(string) | `<list>` | no |
+| tags | Additional tags (e.g. map('BusinessUnit`,`XYZ`) | map(string) | `<map>` | no |
 | ttl | The TTL of the record to add to the DNS zone to complete certificate validation | string | `300` | no |
-| validation_method | Which method to use for validation, DNS or EMAIL | string | `DNS` | no |
+| validation_method | Method to use for validation, DNS or EMAIL | string | `DNS` | no |
+| wait_for_certificate_issued | Whether to wait for the certificate to be issued by ACM (the certificate status changed from `Pending Validation` to `Issued`) | bool | `false` | no |
 | zone_name | The name of the desired Route53 Hosted Zone | string | `` | no |
 
 ## Outputs
@@ -16,5 +18,5 @@
 |------|-------------|
 | arn | The ARN of the certificate |
 | domain_validation_options | CNAME records that are added to the DNS zone to complete certificate validation |
-| id | The ARN of the certificate |
+| id | The ID of the certificate |
 

docs/terraform.md

@@ -0,0 +1,17 @@
+region = "us-west-1"
+
+namespace = "eg"
+
+stage = "test"
+
+name = "test-zone"
+
+parent_zone_name = "testing.cloudposse.co"
+
+validation_method = "DNS"
+
+ttl = "300"
+
+process_domain_validation_options = true
+
+wait_for_certificate_issued = false

examples/complete/fixtures.us-west-1.tfvars

@@ -0,0 +1,22 @@
+provider "aws" {
+  region = var.region
+}
+
+module "zone" {
+  source           = "git::https://github.com/cloudposse/terraform-aws-route53-cluster-zone.git?ref=tags/0.4.0"
+  namespace        = var.namespace
+  stage            = var.stage
+  name             = var.name
+  parent_zone_name = var.parent_zone_name
+  zone_name        = "$${name}.$${parent_zone_name}"
+}
+
+module "acm_request_certificate" {
+  source                            = "../../"
+  domain_name                       = module.zone.zone_name
+  validation_method                 = var.validation_method
+  ttl                               = var.ttl
+  subject_alternative_names         = ["*.${module.zone.zone_name}"]
+  process_domain_validation_options = var.process_domain_validation_options
+  wait_for_certificate_issued       = var.wait_for_certificate_issued
+}

examples/complete/main.tf

@@ -0,0 +1,34 @@
+output "parent_zone_id" {
+  value = module.zone.parent_zone_id
+}
+
+output "parent_zone_name" {
+  value = module.zone.parent_zone_name
+}
+
+output "zone_id" {
+  value = module.zone.zone_id
+}
+
+output "zone_name" {
+  value = module.zone.zone_name
+}
+
+output "zone_fqdn" {
+  value = module.zone.fqdn
+}
+
+output "certificate_id" {
+  value       = module.acm_request_certificate.id
+  description = "The ID of the certificate"
+}
+
+output "certificate_arn" {
+  value       = module.acm_request_certificate.arn
+  description = "The ID of the certificate"
+}
+
+output "certificate_domain_validation_options" {
+  value       = module.acm_request_certificate.domain_validation_options
+  description = "CNAME records that are added to the DNS zone to complete certificate validation"
+}

examples/complete/outputs.tf

@@ -0,0 +1,44 @@
+variable "namespace" {
+  type        = string
+  description = "Namespace, which could be your organization name or abbreviation, e.g. 'eg' or 'cp'"
+}
+
+variable "stage" {
+  type        = string
+  description = "Stage (e.g. `prod`, `dev`, `staging`)"
+}
+
+variable "name" {
+  type        = string
+  description = "The Name of the application or solution  (e.g. `bastion` or `portal`)"
+}
+
+variable "region" {
+  type        = string
+  description = "AWS region"
+}
+
+variable "parent_zone_name" {
+  type        = string
+  description = "Parent DNS zone name"
+}
+
+variable "validation_method" {
+  type        = string
+  description = "Method to use for validation, DNS or EMAIL"
+}
+
+variable "process_domain_validation_options" {
+  type        = bool
+  description = "Flag to enable/disable processing of the record to add to the DNS zone to complete certificate validation"
+}
+
+variable "ttl" {
+  type        = string
+  description = "The TTL of the record to add to the DNS zone to complete certificate validation"
+}
+
+variable "wait_for_certificate_issued" {
+  type        = bool
+  description = "Whether to wait for the certificate to be issued by ACM (the certificate status changed from `Pending Validation` to `Issued`)"
+}