Skip to content

Commit 338110a

Browse files
authored
Fix go-github ref errors (#8)
1 parent 5764644 commit 338110a

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
dist/bin/*
44
github-status-updater
55
.build-harness
6+
build-harness
67

78
# Binaries for programs and plugins
89
*.exe

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
sudo: required
22
language: go
33
go:
4-
- 1.9.x
4+
- 1.11.x
5+
56
addons:
67
apt:
78
packages:

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
FROM golang:1.9.3 as builder
1+
FROM golang:1.11.2 as builder
22
RUN mkdir -p /go/src/github.com/cloudposse/github-status-updater
33
WORKDIR /go/src/github.com/cloudposse/github-status-updater
44
COPY . .
55
RUN go get && CGO_ENABLED=0 go build -v -o "./dist/bin/github-status-updater" *.go
66

77

8-
FROM alpine:3.6
8+
FROM alpine:3.8
99
RUN apk add --no-cache ca-certificates
1010
COPY --from=builder /go/src/github.com/cloudposse/github-status-updater/dist/bin/github-status-updater /usr/bin/github-status-updater
1111
ENV PATH $PATH:/usr/bin

main.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,12 @@ func main() {
170170
if requiredPullRequestReviews != nil {
171171
pullRequestReviewsEnforcementRequest := &github.PullRequestReviewsEnforcementRequest{}
172172

173+
users := getUserLogins(requiredPullRequestReviews.DismissalRestrictions.Users)
174+
teams := getTeamSlugs(requiredPullRequestReviews.DismissalRestrictions.Teams)
175+
173176
dismissalRestrictionsRequest := &github.DismissalRestrictionsRequest{
174-
Users: getUserLogins(requiredPullRequestReviews.DismissalRestrictions.Users),
175-
Teams: getTeamSlugs(requiredPullRequestReviews.DismissalRestrictions.Teams),
177+
Users: &users,
178+
Teams: &teams,
176179
}
177180

178181
pullRequestReviewsEnforcementRequest.DismissalRestrictionsRequest = dismissalRestrictionsRequest

0 commit comments

Comments
 (0)