Refactor central SCM URL selection for improved readability, Unify logging of central SCM usage

Author: pmarkiewka

scripts/scm-manager/init-scmm.sh

@@ -180,8 +180,8 @@ function configureScmmManager() {
   setPermissionForUser "${METRICS_USERNAME}" "metrics:read"
 
  USE_CENTRAL_SCM=$([[ -n "${CENTRAL_SCM_URL// /}" ]] && echo true || echo false)
- echo "CENTRAL_SCM_URL='$CENTRAL_SCM_URL'"
- echo "USE_CENTRAL_SCM=$USE_CENTRAL_SCM"
+ echo "Using central SCM: ${USE_CENTRAL_SCM}, URL: '${CENTRAL_SCM_URL}'"
+
   ### ArgoCD Repos
   if [[ $INSTALL_ARGOCD == true ]]; then
 

src/main/groovy/com/cloudogu/gitops/scmm/ScmmRepo.groovy

@@ -47,7 +47,11 @@ class ScmmRepo {
         //switching from normal scm path to the central path
         this.scmmUrl = "${config.scmm.protocol}://${config.scmm.host}"
         if(this.isCentralRepo) {
-            this.scmmUrl= !config.multiTenant.internal? "${config.multiTenant.centralScmUrl.toString()}" : "http://scmm.${config.multiTenant.centralSCMamespace}.svc.cluster.local/scm"
+            boolean useInternal = config.multiTenant.internal
+            String internalUrl = "http://scmm.${config.multiTenant.centralSCMamespace}.svc.cluster.local/scm"
+            String externalUrl = config.multiTenant.centralScmUrl.toString()
+
+            this.scmmUrl = useInternal ? internalUrl : externalUrl
         }