Skip to content

Commit 739ca2f

Browse files
committed
- helm-with-dependencies not existing anymore
- extract hardcoded references for example-apps in unit test
1 parent 1ba8752 commit 739ca2f

File tree

2 files changed

+2
-46
lines changed

2 files changed

+2
-46
lines changed

examples/example-apps-via-content-loader/argocd/petclinic-helm/Jenkinsfile.ftl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ String getCesBuildLibRepo() { configRepositoryPRBaseUrl+"/repo/3rd-party-depende
2020
String getCesBuildLibVersion() { '2.5.0' }
2121
String getGitOpsBuildLibRepo() { configRepositoryPRBaseUrl+"/repo/3rd-party-dependencies/gitops-build-lib" }
2222
String getGitOpsBuildLibVersion() { '0.8.0'}
23-
String getHelmChartRepository() { configRepositoryPRBaseUrl+"/repo/3rd-party-dependencies/spring-boot-helm-chart-with-dependency" }
24-
String getHelmChartVersion() { "1.0.0" }
23+
String getHelmChartRepository() { configRepositoryPRBaseUrl+"/repo/3rd-party-dependencies/spring-boot-helm-chart" }
24+
String getHelmChartVersion() { "0.4.0" }
2525
String getMainBranch() { 'main' }
2626

2727
cesBuildLib = library(identifier: "ces-build-lib@${cesBuildLibVersion}",

src/test/groovy/com/cloudogu/gitops/features/JenkinsTest.groovy

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -213,20 +213,6 @@ me:x:1000:''')
213213

214214
verify(userManager).createUser('metrics-usr', 'metrics-pw')
215215
verify(userManager).grantPermission('metrics-usr', UserManager.Permissions.METRICS_VIEW)
216-
217-
verify(jobManger).createCredential('my-prefix-example-apps', 'scmm-user',
218-
'my-prefix-gitops', 'scmm-pw', 'credentials for accessing scm-manager')
219-
220-
verify(jobManger).startJob('my-prefix-example-apps')
221-
verify(jobManger).createJob('my-prefix-example-apps', 'http://scmm/scm',
222-
"my-prefix-argocd", 'scmm-user')
223-
224-
verify(jobManger).createCredential('my-prefix-example-apps', 'registry-user',
225-
'reg-usr', 'reg-pw', 'credentials for accessing the docker-registry for writing images built on jenkins')
226-
verify(jobManger, never()).createCredential(eq('my-prefix-example-apps'), eq('registry-proxy-user'),
227-
anyString(), anyString(), anyString())
228-
verify(jobManger, never()).createCredential(eq('my-prefix-example-apps'), eq('registry-proxy-user'),
229-
anyString(), anyString(), anyString())
230216
}
231217

232218
@Test
@@ -279,36 +265,6 @@ me:x:1000:''')
279265
createJenkins().install()
280266
assertThat(config.jenkins.url).endsWith('192.168.16.2:42')
281267
}
282-
283-
@Test
284-
void 'Handles two registries'() {
285-
config.registry.twoRegistries = true
286-
config.content.examples = true
287-
config.application.namePrefix = 'my-prefix-'
288-
config.application.namePrefixForEnvVars = 'MY_PREFIX_'
289-
290-
config.registry.url = 'reg-url'
291-
config.registry.path = 'reg-path'
292-
config.registry.username = 'reg-usr'
293-
config.registry.password = 'reg-pw'
294-
config.registry.proxyUrl = 'reg-proxy-url'
295-
config.registry.proxyUsername = 'reg-proxy-usr'
296-
config.registry.proxyPassword = 'reg-proxy-pw'
297-
298-
createJenkins().install()
299-
300-
verify(globalPropertyManager).setGlobalProperty('MY_PREFIX_REGISTRY_PROXY_URL', 'reg-proxy-url')
301-
302-
verify(globalPropertyManager).setGlobalProperty(eq('MY_PREFIX_REGISTRY_URL'), anyString())
303-
verify(globalPropertyManager).setGlobalProperty(eq('MY_PREFIX_REGISTRY_PATH'), anyString())
304-
305-
verify(jobManger).createCredential('my-prefix-example-apps', 'registry-user',
306-
'reg-usr', 'reg-pw',
307-
'credentials for accessing the docker-registry for writing images built on jenkins')
308-
verify(jobManger).createCredential('my-prefix-example-apps', 'registry-proxy-user',
309-
'reg-proxy-usr', 'reg-proxy-pw',
310-
'credentials for accessing the docker-registry that contains 3rd party or base images')
311-
}
312268

313269
@Test
314270
void 'Does not create create job credentials when argo cd is deactivated'() {

0 commit comments

Comments
 (0)