Refactor files and docu that contain bitnami/kubectl images and rename bitnami to bitnamilegacy.

Author: avetgit

README.md

@@ -469,7 +469,7 @@ def gitopsConfig = [
     ...
     buildImages          : [
             helm: 'ghcr.io/cloudogu/helm:3.10.3-1',
-            kubectl: 'bitnami/kubectl:1.29',
+            kubectl: 'bitnamilegacy/kubectl:1.29',
             kubeval: 'ghcr.io/cloudogu/helm:3.10.3-1',
             helmKubeval: 'ghcr.io/cloudogu/helm:3.10.3-1',
             yamllint: 'cytopia/yamllint:1.25-0.7'
@@ -624,7 +624,7 @@ When you encounter errors with port 80 you might want to use e.g.
 * If you must, you can also run using Docker Desktop from native Windows console (see bellow)
 * However, there seems to be a problem when the Jenkins Jobs running the playground access docker, e.g.   
 ```
-$ docker run -t -d -u 0:133 -v ... -e ******** bitnami/kubectl:1.25.4 cat
+$ docker run -t -d -u 0:133 -v ... -e ******** bitnamilegacy/kubectl:1.25.4 cat
 docker top e69b92070acf3c1d242f4341eb1fa225cc40b98733b0335f7237a01b4425aff3 -eo pid,comm
 process apparently never started in /tmp/gitops-playground-jenkins-agent/workspace/xample-apps_petclinic-plain_main/.configRepoTempDir@tmp/durable-7f109066
 (running Jenkins temporarily with -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.LAUNCH_DIAGNOSTICS=true might make the problem clearer)

docs/developers.md

@@ -453,15 +453,15 @@ curl -X PUT -u admin:Harbor12345 'http://localhost:30002/api/v2.0/projects/1'  -
 
 Then either import external images like so (requires `skopeo` but no prior pulling or insecure config necessary):
 ```bash
-skopeo copy docker://bitnami/nginx:1.25.1 --dest-creds admin:Harbor12345 --dest-tls-verify=false  docker://localhost:30002/library/nginx:1.25.1
+skopeo copy docker://bitnamilegacy/nginx:1.25.1 --dest-creds admin:Harbor12345 --dest-tls-verify=false  docker://localhost:30002/library/nginx:1.25.1
 ```
 
 Alternatively, you could push existing images from your docker daemon.
 However, this takes longer (pull first) and you'll have to make sure to add `localhost:30002` to `insecure-registries` in `/etc/docker/daemon.json` and restart your docker daemon first.
 
 ```bash
 docker login localhost:30002 -u admin -p Harbor12345
-docker tag bitnami/nginx:1.25.1 localhost:30002/library/nginx:1.25.1
+docker tag bitnamilegacy/nginx:1.25.1 localhost:30002/library/nginx:1.25.1
 docker push localhost:30002/library/nginx:1.25.1
 ```
 
@@ -567,7 +567,7 @@ curl  --fail "http://localhost:30000/api/v2.0/projects/${projectId}/members" -X
 skopeo copy docker://ghcr.io/cloudogu/mailhog:v1.0.1 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/mailhog
 skopeo copy docker://ghcr.io/external-secrets/external-secrets:v0.9.16 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/external-secrets
 skopeo copy docker://hashicorp/vault:1.14.0 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/vault
-skopeo copy docker://bitnami/nginx:1.23.3-debian-11-r8 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/nginx
+skopeo copy docker://bitnamilegacy/nginx:1.23.3-debian-11-r8 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/nginx
 skopeo copy docker://registry.k8s.io/ingress-nginx/controller:v1.12.1 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false docker://localhost:30000/proxy/ingress-nginx
 
 # Monitoring
@@ -586,7 +586,7 @@ skopeo copy docker://quay.io/jetstack/cert-manager-cainjector:v1.16.1 --dest-cre
 skopeo copy docker://quay.io/jetstack/cert-manager-webhook:v1.16.1 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false docker://localhost:30000/proxy/cert-manager-webhook
 
 # Needed for the builds to work with proxy-registry
-skopeo copy docker://bitnami/kubectl:1.29 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/bitnami/kubectl:1.29
+skopeo copy docker://bitnamilegacy/kubectl:1.29 --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/bitnami/kubectl:1.29
 skopeo copy docker://eclipse-temurin:17-jre-alpine --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/eclipse-temurin:17-jre-alpine
 skopeo copy docker://ghcr.io/cloudogu/helm:3.16.1-1  --dest-creds Proxy:Proxy12345 --dest-tls-verify=false  docker://localhost:30000/proxy/helm:latest 
 ```
@@ -612,7 +612,7 @@ docker run --rm -t -u $(id -u) \
     --registry-proxy-password=Proxy12345 \
     --registry-username-read-only=RegistryRead \
     --registry-password-read-only=RegistryRead12345 \
-    --kubectl-image=localhost:30000/proxy/bitnami/kubectl:1.29 \
+    --kubectl-image=localhost:30000/proxy/bitnamilegacy/kubectl:1.29 \
     --helm-image=localhost:30000/proxy/helm:latest \
     --petclinic-image=localhost:30000/proxy/eclipse-temurin:17-jre-alpine \
     --mailhog-image=localhost:30000/proxy/mailhog:latest \

src/main/groovy/com/cloudogu/gitops/config/Config.groovy

@@ -494,7 +494,7 @@ class Config {
     static class ImagesSchema {
         @Option(names = ['--kubectl-image'], description = KUBECTL_IMAGE_DESCRIPTION)
         @JsonPropertyDescription(KUBECTL_IMAGE_DESCRIPTION)
-        String kubectl = "bitnami/kubectl:$K8S_VERSION"
+        String kubectl = "bitnamilegacy/kubectl:$K8S_VERSION"
 
         // cloudogu/helm also contains kubeval and helm kubeval plugin. Using the same image makes builds faster
         @Option(names = ['--helm-image'], description = HELM_IMAGE_DESCRIPTION)

src/test/groovy/com/cloudogu/gitops/utils/data/contentRepos/copyRepo1/Jenkinsfile

@@ -128,7 +128,7 @@ void addSpecificGitOpsConfig(gitopsConfig) {
         // If you can access the internet, you can rely on the defaults, which load the images from public registries.
         buildImages          : [
             helm: 'ghcr.io/cloudogu/helm:3.16.4-1',
-            kubectl: 'bitnami/kubectl:1.29',
+            kubectl: 'bitnamilegacy/kubectl:1.29',
             kubeval: 'ghcr.io/cloudogu/helm:3.16.4-1',
             helmKubeval: 'ghcr.io/cloudogu/helm:3.16.4-1',
             yamllint: 'cytopia/yamllint:1.25-0.7'

src/test/groovy/com/cloudogu/gitops/utils/data/contentRepos/mirrorRepo1/Jenkinsfile

@@ -128,7 +128,7 @@ void addSpecificGitOpsConfig(gitopsConfig) {
         // If you can access the internet, you can rely on the defaults, which load the images from public registries.
         buildImages          : [
             helm: 'ghcr.io/cloudogu/helm:3.16.4-1',
-            kubectl: 'bitnami/kubectl:1.29',
+            kubectl: 'bitnamilegacy/kubectl:1.29',
             kubeval: 'ghcr.io/cloudogu/helm:3.16.4-1',
             helmKubeval: 'ghcr.io/cloudogu/helm:3.16.4-1',
             yamllint: 'cytopia/yamllint:1.25-0.7'

src/test/resources/testMainConfig.yaml

@@ -50,7 +50,7 @@ application:
   namespaceIsolation: false
   netpols: false
 images:
-  kubectl: "bitnami/kubectl:1.29"
+  kubectl: "bitnamilegacy/kubectl:1.29"
   helm: "ghcr.io/cloudogu/helm:3.15.4-1"
   kubeval: "ghcr.io/cloudogu/helm:3.15.4-1"
   helmKubeval: "ghcr.io/cloudogu/helm:3.15.4-1"