From ae4b43c26f68a04962dc0fc491d53a74a650b9c9 Mon Sep 17 00:00:00 2001 From: ccoVeille <3875889+ccoVeille@users.noreply.github.com> Date: Tue, 4 Nov 2025 00:59:18 +0100 Subject: [PATCH] feat(test): use safecast.RequireConvert as a replacement for safecast.Convert in tests --- pkg/controllers/proxy/ipset_fixture_test.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/controllers/proxy/ipset_fixture_test.go b/pkg/controllers/proxy/ipset_fixture_test.go index ada0283e2..502a0bca0 100644 --- a/pkg/controllers/proxy/ipset_fixture_test.go +++ b/pkg/controllers/proxy/ipset_fixture_test.go @@ -149,10 +149,7 @@ func buildIPVSServicesFromFixtures(t *testing.T, services *v1.ServiceList) []*ip require.GreaterOrEqualf(t, port.Port, int32(0), "service %s/%s has negative port %d", svc.Namespace, svc.Name, port.Port) const maxServicePort = 1<<16 - 1 require.LessOrEqualf(t, port.Port, int32(maxServicePort), "service %s/%s port %d exceeds %d", svc.Namespace, svc.Name, port.Port, maxServicePort) - targetPort, err := safecast.Convert[uint16](port.Port) - if err != nil { - t.Fatalf("failed to convert port %d to uint16: %v", port.Port, err) - } + targetPort := safecast.RequireConvert[uint16](t, port.Port) appendService := func(ipStr string) { ip := net.ParseIP(ipStr)