Skip to content

Commit 3491d3a

Browse files
authored
Merge pull request #14 from wmudge/bugfix/azure-public-cloud-sandbox
Remove extraneous user_ports from Extra security group
2 parents 2cbb523 + c2abc4d commit 3491d3a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

roles/infrastructure/tasks/initialize_setup_azure.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
infra__azure_security_group_rules:
2020
- name: 'AllowCallerAccess'
2121
protocol: Tcp
22+
# TODO Add back in infra__vpc_user_cidr as an union of source addresses
2223
source_address_prefix:
2324
- "{{ ipify_public_ip }}/32"
2425
destination_port_range: "{{ infra__vpc_user_ports }}"
@@ -40,15 +41,15 @@
4041
direction: Inbound
4142

4243
- name: Add User and Extra security group rules for Azure
43-
when: (infra__vpc_extra_cidr | length > 0) or (infra__vpc_user_cidr | length > 0)
44+
when: infra__vpc_extra_cidr | length > 0
4445
ansible.builtin.set_fact:
4546
infra__azure_security_group_rules: "{{ infra__azure_security_group_rules | union(rule) }}"
4647
vars:
4748
rule:
4849
- name: 'AllowExtraAccess'
4950
protocol: Tcp
50-
source_address_prefix: "{{ infra__vpc_extra_cidr | union(infra__vpc_user_cidr) }}"
51-
destination_port_range: "{{ infra__vpc_extra_ports | union(infra__vpc_user_ports) }}"
51+
source_address_prefix: "{{ infra__vpc_extra_cidr }}"
52+
destination_port_range: "{{ infra__vpc_extra_ports }}"
5253
access: Allow
5354
priority: 201
5455
direction: Inbound

0 commit comments

Comments
 (0)