UI: file_actions: dev [ci skip]

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>

Author: bigcat88

nc_py_api/ex_app/ui/top_menu.py

@@ -31,13 +31,14 @@ def display_name(self) -> str:
         return self._raw_data["display_name"]
 
     @property
-    def icon_url(self) -> str:
+    def icon(self) -> str:
         """Relative to the ExApp url with icon or empty value to use the default one icon."""
-        return self._raw_data["icon_url"] if self._raw_data["icon_url"] else ""
+        return self._raw_data["icon"] if self._raw_data["icon"] else ""
 
     @property
     def admin_required(self) -> bool:
         """Flag that determines whether the entry menu is displayed only for administrators."""
+        print(self._raw_data["admin_required"])
         return bool(self._raw_data["admin_required"])
 
     def __repr__(self):
@@ -52,19 +53,19 @@ class _UiTopMenuAPI:
     def __init__(self, session: NcSessionApp):
         self._session = session
 
-    def register(self, name: str, display_name: str, icon_url: str = "", admin_required=False) -> None:
+    def register(self, name: str, display_name: str, icon: str = "", admin_required=False) -> None:
         """Registers or edit the App entry in Top Meny.
 
         :param name: Unique name for the menu entry.
         :param display_name: Display name of the menu entry.
-        :param icon_url: Optional, url relative to the ExApp, like: "img/icon.svg"
+        :param icon: Optional, url relative to the ExApp, like: "img/icon.svg"
         :param admin_required: Boolean value indicating should be Entry visible to all or only to admins.
         """
         require_capabilities("app_api", self._session.capabilities)
         params = {
             "name": name,
             "displayName": display_name,
-            "iconUrl": icon_url,
+            "icon": icon,
             "adminRequired": int(admin_required),
         }
         self._session.ocs(method="POST", path=f"{self._session.ae_url}/{self._ep_suffix}", json=params)

tests/actual_tests/appcfg_prefs_ex_test.py

@@ -122,7 +122,7 @@ def test_appcfg_sensitive(nc_app):
     assert appcfg.get_value("test_key") == "123"
     assert appcfg.get_values(["test_key"])[0].value == "123"
     appcfg.delete("test_key")
-    # next code tests `sensitive` value from the `AppEcosystem`
+    # next code tests `sensitive` value from the `AppAPI`
     params = {"configKey": "test_key", "configValue": "123"}
     result = nc_app._session.ocs(method="POST", path=f"{nc_app._session.ae_url}/{appcfg._url_suffix}", json=params)
     assert not result["sensitive"]  # by default if sensitive value is unspecified it is False

tests/actual_tests/ui_top_menu_test.py

@@ -8,7 +8,7 @@ def test_register_ui_top_menu(nc_app):
     result = nc_app.ui.top_menu.get_entry("test_name")
     assert result.name == "test_name"
     assert result.display_name == "Disp name"
-    assert result.icon_url == ""
+    assert result.icon == ""
     assert result.admin_required is False
     nc_app.ui.top_menu.unregister(result.name)
     assert nc_app.ui.top_menu.get_entry("test_name") is None
@@ -19,13 +19,13 @@ def test_register_ui_top_menu(nc_app):
     result = nc_app.ui.top_menu.get_entry("test_name")
     assert result.name == "test_name"
     assert result.display_name == "display"
-    assert result.icon_url == "img/test.svg"
+    assert result.icon == "img/test.svg"
     assert result.admin_required is True
     nc_app.ui.top_menu.register("test_name", "Display name", "", admin_required=False)
     result = nc_app.ui.top_menu.get_entry("test_name")
     assert result.name == "test_name"
     assert result.display_name == "Display name"
-    assert result.icon_url == ""
+    assert result.icon == ""
     assert result.admin_required is False
     nc_app.ui.top_menu.unregister(result.name)
     assert nc_app.ui.top_menu.get_entry("test_name") is None