dev: appcfg/pref - key cannot be empty

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>

Author: bigcat88

tests/appconfig_preferences_ex_test.py

@@ -9,9 +9,15 @@
     pytest.skip("app_ecosystem_v2 is not installed.", allow_module_level=True)
 
 
+@pytest.mark.parametrize("class_to_test", (NC_APP.appconfig_ex_api, NC_APP.preferences_ex_api))
+def test_cfg_ex_set_empty_key(class_to_test):
+    with pytest.raises(NextcloudException):
+        class_to_test.set("", "some value")
+
+
 @pytest.mark.parametrize("value", ("0", "1", "12 3", ""))
 @pytest.mark.parametrize("class_to_test", (NC_APP.appconfig_ex_api, NC_APP.preferences_ex_api))
-def test_preferences_ex_set_delete(value, class_to_test):
+def test_cfg_ex_set_delete(value, class_to_test):
     class_to_test.delete("test_key")
     assert class_to_test.get_value("test_key") is None
     class_to_test.set("test_key", value)
@@ -23,15 +29,7 @@ def test_preferences_ex_set_delete(value, class_to_test):
 
 
 @pytest.mark.parametrize("class_to_test", (NC_APP.appconfig_ex_api, NC_APP.preferences_ex_api))
-def test_preferences_ex_set_empty_param(class_to_test):
-    class_to_test.set("", "123")
-    assert class_to_test.get_value("") == "123"
-    class_to_test.delete("")
-    assert class_to_test.get_value("") is None
-
-
-@pytest.mark.parametrize("class_to_test", (NC_APP.appconfig_ex_api, NC_APP.preferences_ex_api))
-def test_preferences_ex_delete(class_to_test):
+def test_cfg_ex_delete(class_to_test):
     class_to_test.set("test_key", "123")
     assert class_to_test.get_value("test_key")
     class_to_test.delete("test_key")
@@ -42,7 +40,7 @@ def test_preferences_ex_delete(class_to_test):
 
 
 @pytest.mark.parametrize("class_to_test", (NC_APP.appconfig_ex_api, NC_APP.preferences_ex_api))
-def test_preferences_ex_multiply_delete(class_to_test):
+def test_cfg_ex_multiply_delete(class_to_test):
     class_to_test.set("test_key", "123")
     class_to_test.set("test_key2", "123")
     assert len(class_to_test.get_values(["test_key", "test_key2"])) == 2
@@ -55,9 +53,9 @@ def test_preferences_ex_multiply_delete(class_to_test):
     assert len(class_to_test.get_values(["test_key", "test_key2"])) == 0
 
 
-@pytest.mark.parametrize("key", ("k", "k y", "", " "))
+@pytest.mark.parametrize("key", ("k", "k y", " "))
 @pytest.mark.parametrize("class_to_test", (NC_APP.appconfig_ex_api, NC_APP.preferences_ex_api))
-def test_preferences_ex_get_non_existing(key, class_to_test):
+def test_cfg_ex_get_non_existing(key, class_to_test):
     try:
         class_to_test.delete(key)
     except NextcloudException:
@@ -68,7 +66,7 @@ def test_preferences_ex_get_non_existing(key, class_to_test):
 
 
 @pytest.mark.parametrize("class_to_test", (NC_APP.appconfig_ex_api, NC_APP.preferences_ex_api))
-def test_preferences_ex_get(class_to_test):
+def test_cfg_ex_get(class_to_test):
     class_to_test.delete(["test key", "test key2"])
     assert len(class_to_test.get_values(["test key", "test key2"])) == 0
     class_to_test.set("test key", "123")
@@ -79,7 +77,7 @@ def test_preferences_ex_get(class_to_test):
 
 
 @pytest.mark.parametrize("class_to_test", (NC_APP.appconfig_ex_api, NC_APP.preferences_ex_api))
-def test_preferences_ex_get_typing(class_to_test):
+def test_cfg_ex_get_typing(class_to_test):
     class_to_test.set("test key", "123")
     class_to_test.set("test key2", "321")
     r = class_to_test.get_values(["test key", "test key2"])