Skip to content

Commit c94bc1f

Browse files
authored
small ci & cd update (#43)
* CI&CD-py: run analysis always * CI&CD-py: added `check-manifest` to pre-commit
1 parent 73caa06 commit c94bc1f

File tree

2 files changed

+18
-32
lines changed

2 files changed

+18
-32
lines changed

.github/workflows/py_analysis-coverage.yml

Lines changed: 12 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
name: (Py)Analysis & Coverage
22

33
on:
4-
pull_request:
5-
paths:
6-
- 'nc_py_api/*.*'
7-
- 'tests/nc_py_api/**'
8-
- 'setup.*'
9-
- 'pyproject.toml'
104
push:
11-
paths:
12-
- 'nc_py_api/*.*'
13-
- 'tests/nc_py_api/**'
14-
- 'setup.*'
15-
- 'pyproject.toml'
16-
workflow_dispatch:
5+
branches:
6+
- main
7+
- dev
8+
pull_request:
9+
branches:
10+
- main
11+
- dev
1712

1813
env:
1914
APP_NAME: cloud_py_api
@@ -22,36 +17,25 @@ jobs:
2217
analysis:
2318
runs-on: macos-12
2419
name: Analysis
25-
if: "!contains(github.event.head_commit.message, '[docs]')"
2620

2721
steps:
2822
- uses: actions/checkout@v3
2923
- uses: actions/setup-python@v4
3024
with:
3125
python-version: '3.9'
3226

33-
- name: pre-commit cache
34-
uses: actions/cache@v3
35-
with:
36-
path: ~/.cache/pre-commit
37-
key: lint-pre-commit-${{ hashFiles('.pre-commit-config.yaml') }}
38-
restore-keys: |
39-
lint-pre-commit-
40-
41-
- name: Making preparations
42-
run: |
43-
python3 -m pip install .
44-
python3 -m pip install pre-commit pylint
45-
pre-commit install
27+
- name: Install from source
28+
run: python3 -m pip install .
4629

4730
- name: Run Analysis
48-
run: pre-commit run --all-files --verbose --show-diff-on-failure
31+
run: |
32+
python3 -m pip install pylint
33+
python3 -m pylint setup.py "nc_py_api/" -sn
4934
5035
tests-pgsql:
5136
needs: [analysis]
5237
runs-on: ubuntu-22.04
5338
name: ${{ matrix.nextcloud }} • PHP ${{ matrix.php-version }} • PgSQL ${{ matrix.pgsql-version }}
54-
if: "!contains(github.event.head_commit.message, '[docs]')"
5539
strategy:
5640
fail-fast: false
5741
matrix:
@@ -144,7 +128,6 @@ jobs:
144128
needs: [analysis]
145129
runs-on: ubuntu-22.04
146130
name: ${{ matrix.nextcloud }} • PHP ${{ matrix.php-version }} • MySQL ${{ matrix.mysql-version }}
147-
if: "!contains(github.event.head_commit.message, '[docs]')"
148131
strategy:
149132
fail-fast: false
150133
matrix:
@@ -236,7 +219,6 @@ jobs:
236219
needs: [analysis]
237220
runs-on: ubuntu-22.04
238221
name: ${{ matrix.nextcloud }} • PHP ${{ matrix.php-version }} • Maria ${{ matrix.mariadb-version }}
239-
if: "!contains(github.event.head_commit.message, '[docs]')"
240222
strategy:
241223
fail-fast: false
242224
matrix:
@@ -328,7 +310,6 @@ jobs:
328310
needs: [analysis]
329311
runs-on: ubuntu-22.04
330312
name: ${{ matrix.nextcloud }} • PHP ${{ matrix.php-version }} • MySQL • SOCK
331-
if: "!contains(github.event.head_commit.message, '[docs]')"
332313
strategy:
333314
fail-fast: false
334315
matrix:
@@ -409,7 +390,6 @@ jobs:
409390
needs: [analysis]
410391
runs-on: ubuntu-22.04
411392
name: ${{ matrix.nextcloud }} • PHP ${{ matrix.php-version }} • PgSQL • SOCK
412-
if: "!contains(github.event.head_commit.message, '[docs]')"
413393
strategy:
414394
fail-fast: false
415395
matrix:

.pre-commit-config.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@ repos:
4242
files: nc_py_api/
4343
additional_dependencies: [types-pymysql, pg8000, pytest]
4444

45+
- repo: https://github.com/mgedmin/check-manifest
46+
rev: "0.49"
47+
hooks:
48+
- id: check-manifest
49+
args: [--no-build-isolation]
50+
4551
- repo: local
4652
hooks:
4753
- id: pylint

0 commit comments

Comments
 (0)