CLJS-3011: Port improved runtime exception printing to non-Node REPLs

Author: mfikes

src/main/cljs/clojure/browser/repl.cljs

@@ -69,12 +69,7 @@
            :value (str (js* "eval(~{block})"))}
           (catch :default e
             {:status :exception
-             :ua-product (get-ua-product)
-             :value (str e)
-             :stacktrace
-             (if (.hasOwnProperty e "stack")
-               (.-stack e)
-               "No stacktrace available.")}))]
+             :value (cljs.repl/error->str e)}))]
     (pr-str result)))
 
 (defn send-result [connection url data]

src/main/clojure/cljs/repl/graaljs.clj

@@ -148,25 +148,12 @@
       {:status :success
        :value  (if-let [r (eval-str engine js)] (safe-to-string r) "")}
       (catch ScriptException e
-        (let [^Throwable root-cause (clojure.stacktrace/root-cause e)]
-          {:status :exception
-           :value  (.getMessage root-cause)
-           :stacktrace
-                   (apply str
-                     (interpose "\n"
-                       (map #(subs % 5)
-                         (filter #(clojure.string/starts-with? % "<js>.")
-                           (map str
-                             (.getStackTrace root-cause))))))}))
+        {:status :exception
+         :value  (eval-str engine "cljs.repl.error__GT_str(cljs.core._STAR_e)")})
       (catch Throwable e
         (let [^Throwable root-cause (clojure.stacktrace/root-cause e)]
           {:status :exception
-           :value  (.getMessage root-cause)
-           :stacktrace
-                   (apply str
-                     (interpose "\n"
-                       (map str
-                         (.getStackTrace root-cause))))}))))
+           :value  (cljs.repl/ex-str (cljs.repl/ex-triage (Throwable->map root-cause)))}))))
   (-load [{engine :engine :as this} ns url]
     (load-ns engine ns))
   (-tear-down [this]

src/main/clojure/cljs/repl/nashorn.clj

@@ -138,17 +138,11 @@
           (catch ScriptException e
             (let [^Throwable root-cause (clojure.stacktrace/root-cause e)]
               {:status :exception
-               :value (.getMessage root-cause)
-               :stacktrace (NashornException/getScriptStackString root-cause)}))
+               :value  (eval-str engine "cljs.repl.error__GT_str(cljs.core._STAR_e)")}))
           (catch Throwable e
             (let [^Throwable root-cause (clojure.stacktrace/root-cause e)]
               {:status :exception
-               :value (.getMessage root-cause)
-               :stacktrace
-               (apply str
-                 (interpose "\n"
-                   (map str
-                     (.getStackTrace root-cause))))}))))
+               :value (cljs.repl/ex-str (cljs.repl/ex-triage (Throwable->map root-cause)))}))))
       (-load [{engine :engine :as this} ns url]
         (load-ns engine ns))
       (-tear-down [this]

src/main/clojure/cljs/repl/rhino.clj

@@ -86,8 +86,7 @@
         (ScriptableObject/putProperty top-level "_STAR_e"
           (Context/javaToJS ex scope))
         {:status :exception
-         :value (.toString ex)
-         :stacktrace (stacktrace ex)}))))
+         :value  (cljs.repl/ex-str (cljs.repl/ex-triage (Throwable->map ex)))}))))
 
 (defn load-file
   "Load a JavaScript. This is needed to load JavaScript files before the Rhino