Fix and cover project-files-in-topo-order

Author: vemv

Makefile

@@ -3,6 +3,7 @@
 VERSION ?= 1.10
 
 .inline-deps:
+	git clean -fdx
 	lein with-profile -user,+$(VERSION) inline-deps
 	touch .inline-deps
 

project.clj

@@ -1,4 +1,4 @@
-(defproject refactor-nrepl "3.0.0-alpha4"
+(defproject refactor-nrepl "3.0.0-alpha10"
   :description "nREPL middleware to support editor-agnostic refactoring"
   :url "http://github.com/clojure-emacs/refactor-nrepl"
   :license {:name "Eclipse Public License"

src/refactor_nrepl/ns/tracker.clj

@@ -4,7 +4,7 @@
             [clojure.tools.namespace
              [dependency :as dep]
              [file :as file]
-             [repl :refer [refresh-dirs]]
+             [repl :as tools.namespace.repl]
              [track :as tracker]]
             [refactor-nrepl.core :as core]
             [refactor-nrepl.util :as util]
@@ -35,7 +35,7 @@
               resolve
               deref)
       ;; corner case - use the mranderson-ized refresh-dirs (for supporting this project's test suite):
-      refresh-dirs))
+      tools.namespace.repl/refresh-dirs))
 
 (def default-file-filter-predicate (every-pred core/source-file?
                                                safe-for-clojure-tools-namespace?))
@@ -90,8 +90,9 @@
   ([]
    (project-files-in-topo-order false))
   ([ignore-errors?]
-   (let [tracker (build-tracker (util/with-suppressed-errors
-                                  (every-pred (partial in-refresh-dirs? refresh-dirs (absolutize-refresh-dirs user-refresh-dirs))
+   (let [refresh-dirs (user-refresh-dirs)
+         tracker (build-tracker (util/with-suppressed-errors
+                                  (every-pred (partial in-refresh-dirs? refresh-dirs (absolutize-refresh-dirs refresh-dirs))
                                               core/clj-file?)
                                   ignore-errors?))
          nses (dep/topo-sort (:clojure.tools.namespace.track/deps tracker))

test/refactor_nrepl/ns/tracker_test.clj

@@ -1,7 +1,7 @@
 (ns refactor-nrepl.ns.tracker-test
   (:require
    [refactor-nrepl.ns.tracker :as sut]
-   [clojure.test :refer [are deftest]]))
+   [clojure.test :refer [are deftest is]]))
 
 (deftest in-refresh-dirs?
   (are [refresh-dirs file-ns expected] (= expected
@@ -18,3 +18,8 @@
     ["src"]  "/"                                       false
     ["ffff"] "src/refactor_nrepl/ns/tracker.clj"       false
     ["src"]  "src/refactor_nrepl/ns/trackeeeeeer.clj"  false))
+
+(deftest project-files-in-topo-order
+  (is (seq (sut/project-files-in-topo-order false))
+      "Does not throw exceptions even when specifying to not ignore errors,
+i.e. it doesn't have bugs"))