Use constant values instead of variables in clojure-match-next-def tests (#627)

Author: OknoLombarda

test/clojure-mode-syntax-test.el

@@ -92,28 +92,26 @@
           (expect (looking-at "(def"))))))
 
   (it "captures var name"
-    (let ((var-name "some-name"))
-      (dolist (form '("(def %s 1)"
-                      "(def %s)"
-                      "(def ^:private %s 2)"
-                      "(def ^{:private true} %s 3)"))
-        (with-clojure-buffer (format form var-name)
-          (end-of-buffer)
-          (clojure-match-next-def)
-          (cl-destructuring-bind (name-beg name-end) (match-data)
-            (expect (string= var-name (buffer-substring name-beg name-end))))))))
+    (dolist (form '("(def some-name 1)"
+                    "(def some-name)"
+                    "(def ^:private some-name 2)"
+                    "(def ^{:private true} some-name 3)"))
+      (with-clojure-buffer form
+        (end-of-buffer)
+        (clojure-match-next-def)
+        (cl-destructuring-bind (name-beg name-end) (match-data)
+          (expect (string= "some-name" (buffer-substring name-beg name-end)))))))
 
   (it "captures var name with dispatch value for defmethod"
-    (let ((name "some-name :key"))
-      (dolist (form '("(defmethod %s [a])"
-                      "(defmethod ^:meta %s [a])"
-                      "(defmethod ^{:meta true} %s [a])"
-                      "(defmethod %s)"))
-        (with-clojure-buffer (format form name)
-          (end-of-buffer)
-          (clojure-match-next-def)
-          (cl-destructuring-bind (name-beg name-end) (match-data)
-            (expect (string= name (buffer-substring name-beg name-end)))))))))
+    (dolist (form '("(defmethod some-name :key [a])"
+                    "(defmethod ^:meta some-name :key [a])"
+                    "(defmethod ^{:meta true} some-name :key [a])"
+                    "(defmethod some-name :key)"))
+      (with-clojure-buffer form
+        (end-of-buffer)
+        (clojure-match-next-def)
+        (cl-destructuring-bind (name-beg name-end) (match-data)
+          (expect (string= "some-name :key" (buffer-substring name-beg name-end))))))))
 
 (describe "clojure syntax"
   (it "handles prefixed symbols"