Address some byte-compilation warnings

Thanks for the patch, Stefan!

Author: bbatsov

.gitignore

@@ -7,3 +7,5 @@
 *.elc
 .cask
 elpa*
+/clojure-mode-autoloads.el
+/clojure-mode-pkg.el

clojure-mode-extra-font-locking.el

@@ -1,4 +1,4 @@
-;;; clojure-mode-extra-font-locking.el --- Extra font-locking for Clojure mode
+;;; clojure-mode-extra-font-locking.el --- Extra font-locking for Clojure mode  -*- lexical-binding: t; -*-
 
 ;; Copyright © 2014-2021 Bozhidar Batsov
 ;;

test/clojure-mode-bytecomp-warnings.el

@@ -1,4 +1,4 @@
-;;; clojure-mode-bytecomp-warnings.el --- Check for byte-compilation problems
+;;; clojure-mode-bytecomp-warnings.el --- Check for byte-compilation problems  -*- lexical-binding: t; -*-
 
 ;; Copyright © 2012-2021 Bozhidar Batsov and contributors
 ;;

test/clojure-mode-external-interaction-test.el

@@ -22,6 +22,7 @@
 (require 'clojure-mode)
 (require 'buttercup)
 (require 'paredit)
+(require 'test-helper "test/utils/test-helper")
 
 (describe "Interactions with Paredit:"
   ;; reuse existing when-refactoring-it macro

test/clojure-mode-font-lock-test.el

@@ -27,6 +27,7 @@
 (require 'clojure-mode)
 (require 'cl-lib)
 (require 'buttercup)
+(require 'test-helper "test/utils/test-helper")
 
 
 ;;;; Utilities
@@ -36,7 +37,7 @@
   (declare (debug t)
            (indent 1))
   `(with-clojure-buffer ,content
-     (font-lock-fontify-buffer)
+     (font-lock-ensure)
      (goto-char (point-min))
      ,@body))
 

test/clojure-mode-indentation-test.el

@@ -26,7 +26,8 @@
 (require 'clojure-mode)
 (require 'cl-lib)
 (require 'buttercup)
-(require 's)
+(require 's nil t)               ;Don't burp if it's missing during compilation.
+(require 'test-helper "test/utils/test-helper")
 
 (defmacro when-indenting-with-point-it (description before after)
   "Return a buttercup spec.
@@ -279,7 +280,7 @@ DESCRIPTION is a string with the description of the spec."
         one)"))
 
   (describe "we can pass a lambda to explicitly set the column"
-    (put-clojure-indent 'arsymbol (lambda (indent-point state) 0))
+    (put-clojure-indent 'arsymbol (lambda (_indent-point _state) 0))
 
     (when-indenting-with-point-it "should handle a symbol with lambda"
       "

test/clojure-mode-promote-fn-literal-test.el

@@ -23,6 +23,7 @@
 
 (require 'clojure-mode)
 (require 'buttercup)
+(require 'test-helper "test/utils/test-helper")
 
 (describe "clojure-promote-fn-literal"
   :var (names)

test/clojure-mode-syntax-test.el

@@ -25,6 +25,7 @@
 
 (require 'clojure-mode)
 (require 'buttercup)
+(require 'test-helper "test/utils/test-helper")
 
 (defun non-func (form-a form-b)
   (with-clojure-buffer form-a
@@ -66,6 +67,7 @@
                     ("#aaa"   . "aaa")
                     ("'aaa"   . "aaa")))
       (with-clojure-buffer (car form)
+        ;; FIXME: Shouldn't there be an `expect' here?
         (equal (symbol-name (symbol-at-point)) (cdr form)))))
 
   (it "skips prefixes"

test/clojure-mode-util-test.el

@@ -25,12 +25,14 @@
 (require 'clojure-mode)
 (require 'cl-lib)
 (require 'buttercup)
-
+(require 'test-helper "test/utils/test-helper")
 
 (describe "clojure-mode-version"
   (it "should not be nil"
     (expect clojure-mode-version)))
 
+(defvar clojure-cache-project)
+
 (let ((project-dir "/home/user/projects/my-project/")
       (clj-file-path "/home/user/projects/my-project/src/clj/my_project/my_ns/my_file.clj")
       (project-relative-clj-file-path "src/clj/my_project/my_ns/my_file.clj")
@@ -45,13 +47,13 @@
   (describe "clojure-expected-ns"
     (it "should return the namespace matching a path"
       (cl-letf (((symbol-function 'clojure-project-relative-path)
-                 (lambda (&optional current-buffer-file-name)
+                 (lambda (&optional _current-buffer-file-name)
                    project-relative-clj-file-path)))
         (expect (string= (clojure-expected-ns clj-file-path) clj-file-ns))))
 
     (it "should return the namespace even without a path"
       (cl-letf (((symbol-function 'clojure-project-relative-path)
-                 (lambda (&optional current-buffer-file-name)
+                 (lambda (&optional _current-buffer-file-name)
                    project-relative-clj-file-path)))
         (expect (string= (let ((buffer-file-name clj-file-path))
                            (clojure-expected-ns))

test/test-checks.el

@@ -1,4 +1,4 @@
-;; This is a script to be loaded from the root `clojure-mode' directory. It will
+;; This is a script to be loaded from the root `clojure-mode' directory. It will  -*- lexical-binding: t; -*-
 ;; prepare all requirements and then run `check-declare-directory' on
 ;; `default-directory'. For example: emacs -Q --batch -l test/test-checkdoc.el