Add byte-comp and checkdoc tests

Author: xiongtx

.travis.yml

@@ -1,10 +1,15 @@
 sudo: false
 language: emacs-lisp
 env:
-  - EMACS_BINARY=emacs-24.4-travis
-  - EMACS_BINARY=emacs-24.5-travis
-  - EMACS_BINARY=emacs-25.1-travis
-  - EMACS_BINARY=emacs-25.2-travis
+  - EMACS_BINARY=emacs-24.4-travis MAKE_TEST=test
+  - EMACS_BINARY=emacs-24.4-travis MAKE_TEST=test-bytecomp
+  - EMACS_BINARY=emacs-24.5-travis MAKE_TEST=test
+  - EMACS_BINARY=emacs-24.5-travis MAKE_TEST=test-bytecomp
+  - EMACS_BINARY=emacs-25.1-travis MAKE_TEST=test
+  - EMACS_BINARY=emacs-25.1-travis MAKE_TEST=test-bytecomp
+  - EMACS_BINARY=emacs-25.2-travis MAKE_TEST=test
+  - EMACS_BINARY=emacs-25.2-travis MAKE_TEST=test-bytecomp
+  - EMACS_BINARY=emacs-25.2-travis MAKE_TEST=test-checks
   - EMACS_BINARY=emacs-git-snapshot-travis
 matrix:
   allow_failures:
@@ -15,4 +20,4 @@ before_script:
   - make elpa
 script:
   - emacs --version
-  - make compile test
+  - make $MAKE_TEST

Makefile

@@ -25,9 +25,12 @@ clean:
 test: $(PKGDIR)
 	$(CASK) exec ert-runner $(TESTFLAGS)
 
-%.elc : %.el $(PKGDIR)
-	$(CASK) exec $(EMACS) -Q --batch $(EMACSFLAGS) -f batch-byte-compile $<
+test-checks:
+	$(CASK) exec $(EMACS) --no-site-file --no-site-lisp --batch \
+		-l test/test-checks.el ./
 
-$(PKGDIR) : Cask
-	$(CASK) install
-	touch $(PKGDIR)
+test-bytecomp: $(SRCS:.el=.elc-test)
+
+%.elc-test: %.el elpa
+	$(CASK) exec $(EMACS) --no-site-file --no-site-lisp --batch \
+		-l test/clojure-mode-bytecomp-warnings.el $

test/clojure-mode-bytecomp-warnings.el

@@ -0,0 +1,40 @@
+;;; clojure-mode-bytecomp-warnings.el --- Check for byte-compilation problems
+
+;; Copyright © 2012-2017 Bozhidar Batsov and contributors
+;;
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+;; This file is not part of GNU Emacs.
+
+;;; Commentary:
+
+;; This is a script to be loaded while visiting a `clojure-mode' source file.
+;; It will prepare all requirements and then byte-compile the file and signal an
+;; error on any warning.  For example:
+;;
+;;    emacs -Q --batch -l test/clojure-mode-bytecomp-warnings.el clojure-mode.el
+
+;; This assumes that all `clojure-mode' dependencies are already on the package
+;; dir (probably from running `cask install').
+
+(setq load-prefer-newer t)
+(add-to-list 'load-path (expand-file-name "./"))
+(require 'package)
+(package-generate-autoloads 'clojure-mode default-directory)
+(package-initialize)
+(load-file "clojure-mode-autoloads.el")
+(setq byte-compile-error-on-warn t)
+(batch-byte-compile)
+
+;;; clojure-mode-bytecomp-warnings.el ends here

test/test-checks.el

@@ -0,0 +1,30 @@
+;; This is a script to be loaded from the root `clojure-mode' directory. It will
+;; prepare all requirements and then run `check-declare-directory' on
+;; `default-directory'. For example: emacs -Q --batch -l test/test-checkdoc.el
+
+;; This assumes that all `clojure-mode' dependencies are already on the package
+;; dir (probably from running `cask install').
+
+(add-to-list 'load-path (expand-file-name "./"))
+(require 'package)
+(require 'check-declare)
+(package-initialize)
+
+;; disable some annoying (or non-applicable) checkdoc checks
+(setq checkdoc-package-keywords-flag nil)
+(setq checkdoc-arguments-in-order-flag nil)
+(setq checkdoc-verb-check-experimental-flag nil)
+
+(let ((files (directory-files default-directory t
+                              "\\`[^.].*\\.el\\'" t)))
+
+  ;; `checkdoc-file' was introduced in Emacs 25
+  (when (fboundp 'checkdoc-file)
+    (dolist (file files)
+      (checkdoc-file file))
+    (when (get-buffer "*Warnings*")
+      (message "Failing due to checkdoc warnings...")
+      (kill-emacs 1)))
+
+  (when (apply #'check-declare-files files)
+    (kill-emacs 1)))