Appease clippy

Author: coolreader18

modules/benchmarks/src/ia_loop.rs

@@ -193,7 +193,7 @@ pub fn update_position_all(ctx: &ReducerContext, expected: u32) {
 pub fn update_position_with_velocity(ctx: &ReducerContext, expected: u32) {
     let mut count = 0;
     for velocity in ctx.db.velocity().iter() {
-        let Some(mut position) = ctx.db.position().entity_id().find(&velocity.entity_id) else {
+        let Some(mut position) = ctx.db.position().entity_id().find(velocity.entity_id) else {
             continue;
         };
 
@@ -274,7 +274,7 @@ fn get_targetables_near_quad(ctx: &ReducerContext, entity_id: u64, num_players:
                 ctx.db
                     .game_targetable_state()
                     .entity_id()
-                    .find(&t.entity_id)
+                    .find(t.entity_id)
                     .expect("Identity not found"),
             )
         }
@@ -296,7 +296,7 @@ fn move_agent(
         .db
         .game_enemy_state()
         .entity_id()
-        .find(&entity_id)
+        .find(entity_id)
         .expect("GameEnemyState Entity ID not found")
         .clone();
     ctx.db.game_enemy_state().entity_id().update(enemy);
@@ -314,7 +314,7 @@ fn move_agent(
         .db
         .game_targetable_state()
         .entity_id()
-        .find(&entity_id)
+        .find(entity_id)
         .expect("GameTargetableState Entity ID not found");
     let new_hash = calculate_hash(&targetable.quad) as i64;
     targetable.quad = new_hash;
@@ -326,7 +326,7 @@ fn move_agent(
         .db
         .game_live_targetable_state()
         .entity_id()
-        .find(&entity_id)
+        .find(entity_id)
         .is_some()
     {
         ctx.db
@@ -341,7 +341,7 @@ fn move_agent(
         .db
         .game_mobile_entity_state()
         .entity_id()
-        .find(&entity_id)
+        .find(entity_id)
         .expect("GameMobileEntityState Entity ID not found");
     let mobile_entity = GameMobileEntityState {
         entity_id,
@@ -367,20 +367,20 @@ fn agent_loop(
         .db
         .game_mobile_entity_state()
         .entity_id()
-        .find(&entity_id)
+        .find(entity_id)
         .expect("GameMobileEntityState Entity ID not found");
 
     let agent_entity = ctx
         .db
         .game_enemy_state()
         .entity_id()
-        .find(&entity_id)
+        .find(entity_id)
         .expect("GameEnemyState Entity ID not found");
     let agent_herd = ctx
         .db
         .game_herd_cache()
         .id()
-        .find(&agent_entity.herd_id)
+        .find(agent_entity.herd_id)
         .expect("GameHerdCache Entity ID not found");
     let agent_herd_coordinates = agent_herd.location;
 
@@ -402,7 +402,7 @@ pub fn game_loop_enemy_ia(ctx: &ReducerContext, players: u64) {
             .db
             .game_targetable_state()
             .entity_id()
-            .find(&agent.entity_id)
+            .find(agent.entity_id)
             .expect("No TargetableState for AgentState entity");
 
         let surrounding_agents = get_targetables_near_quad(ctx, agent_targetable.entity_id, players);

modules/benchmarks/src/synthetic.rs

@@ -219,7 +219,7 @@ pub fn iterate_unique_0_u32_u64_u64(ctx: &ReducerContext) {
 
 #[spacetimedb::reducer]
 pub fn filter_unique_0_u32_u64_str_by_id(ctx: &ReducerContext, id: u32) {
-    if let Some(p) = ctx.db.unique_0_u32_u64_str().id().find(&id) {
+    if let Some(p) = ctx.db.unique_0_u32_u64_str().id().find(id) {
         black_box(p);
     }
 }
@@ -261,7 +261,7 @@ pub fn filter_btree_each_column_u32_u64_str_by_name(ctx: &ReducerContext, name:
 
 #[spacetimedb::reducer]
 pub fn filter_unique_0_u32_u64_u64_by_id(ctx: &ReducerContext, id: u32) {
-    if let Some(loc) = ctx.db.unique_0_u32_u64_u64().id().find(&id) {
+    if let Some(loc) = ctx.db.unique_0_u32_u64_u64().id().find(id) {
         black_box(loc);
     }
 }
@@ -328,12 +328,12 @@ pub fn filter_btree_each_column_u32_u64_u64_by_y(ctx: &ReducerContext, x: u64) {
 
 #[spacetimedb::reducer]
 pub fn delete_unique_0_u32_u64_str_by_id(ctx: &ReducerContext, id: u32) {
-    ctx.db.unique_0_u32_u64_str().id().delete(&id);
+    ctx.db.unique_0_u32_u64_str().id().delete(id);
 }
 
 #[spacetimedb::reducer]
 pub fn delete_unique_0_u32_u64_u64_by_id(ctx: &ReducerContext, id: u32) {
-    ctx.db.unique_0_u32_u64_u64().id().delete(&id);
+    ctx.db.unique_0_u32_u64_u64().id().delete(id);
 }
 
 // ---------- clear table ----------

modules/perf-test/src/lib.rs

@@ -43,7 +43,7 @@ const CHUNK: u64 = ID / ROWS_PER_CHUNK;
 /// Probing a single column index for a single row should be fast!
 pub fn test_index_scan_on_id(ctx: &ReducerContext) {
     let span = LogStopwatch::new("Index scan on {id}");
-    let location = ctx.db.location().id().find(&ID).unwrap();
+    let location = ctx.db.location().id().find(ID).unwrap();
     span.end();
     assert_eq!(ID, location.id);
 }

modules/quickstart-chat/src/lib.rs

@@ -26,7 +26,7 @@ fn validate_name(name: String) -> Result<String, String> {
 #[spacetimedb::reducer]
 pub fn set_name(ctx: &ReducerContext, name: String) -> Result<(), String> {
     let name = validate_name(name)?;
-    if let Some(user) = ctx.db.user().identity().find(&ctx.sender) {
+    if let Some(user) = ctx.db.user().identity().find(ctx.sender) {
         ctx.db.user().identity().update(User {
             name: Some(name),
             ..user
@@ -65,7 +65,7 @@ pub fn init(_ctx: &ReducerContext) {}
 
 #[spacetimedb::reducer(client_connected)]
 pub fn identity_connected(ctx: &ReducerContext) {
-    if let Some(user) = ctx.db.user().identity().find(&ctx.sender) {
+    if let Some(user) = ctx.db.user().identity().find(ctx.sender) {
         // If this is a returning user, i.e. we already have a `User` with this `Identity`,
         // set `online: true`, but leave `name` and `identity` unchanged.
         ctx.db.user().identity().update(User { online: true, ..user });
@@ -82,7 +82,7 @@ pub fn identity_connected(ctx: &ReducerContext) {
 
 #[spacetimedb::reducer(client_disconnected)]
 pub fn identity_disconnected(ctx: &ReducerContext) {
-    if let Some(user) = ctx.db.user().identity().find(&ctx.sender) {
+    if let Some(user) = ctx.db.user().identity().find(ctx.sender) {
         ctx.db.user().identity().update(User { online: false, ..user });
     } else {
         // This branch should be unreachable,