Skip to content

Commit 4a01538

Browse files
authored
tests: deal with commented out tests (#39)
Turf: - Cookies tests, our README states we don't support cookies - A header conversion test (Apache HttpClient specific, not relevant for us, we use HttpURLConnection) Enable: - Delete with body test, this has been fixed since JDK8. Update README accordingly. Closes #26
1 parent b48c2d9 commit 4a01538

File tree

3 files changed

+5
-244
lines changed

3 files changed

+5
-244
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ A Clojure HTTP library similar to [clj-http](http://github.com/dakrone/clj-http)
1919
- Instead of Apache HttpClient, clj-http-lite uses HttpURLConnection
2020
- No automatic JSON decoding for response bodies
2121
- No cookie support
22-
- No proxy-ing DELETEs with body
2322
- No multipart form uploads
2423
- No persistent connection support
2524
- namespace rename clj-http.* -> clj-http.lite.*

test/clj_http/test/cookies_test.clj

Lines changed: 0 additions & 209 deletions
This file was deleted.

test/clj_http/test/core_test.clj

Lines changed: 5 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -156,12 +156,11 @@
156156
(is (or (= java.net.SocketTimeoutException (class e))
157157
(= java.net.SocketTimeoutException (class (.getCause e))))))))
158158

159-
;; HUC can't do this
160-
;; (deftest ^{:integration true} delete-with-body
161-
;; (run-server)
162-
;; (let [resp (request {:request-method :delete :uri "/delete-with-body"
163-
;; :body (.getBytes "foo bar")})]
164-
;; (is (= 200 (:status resp)))))
159+
(deftest ^{:integration true} delete-with-body
160+
(let [resp (request {:request-method :delete :uri "/delete-with-body"
161+
:body (.getBytes "foo bar")})]
162+
(is (= 200 (:status resp)))
163+
(is (= "delete-with-body" (slurp-body resp)))))
165164

166165
(deftest ^{:integration true} self-signed-ssl-get
167166
(let [client-opts {:request-method :get
@@ -190,35 +189,7 @@
190189
:request
191190
(dissoc :body))))))
192191

193-
;; (deftest parse-headers
194-
;; (are [headers expected]
195-
;; (let [iterator (BasicHeaderIterator.
196-
;; (into-array BasicHeader
197-
;; (map (fn [[name value]]
198-
;; (BasicHeader. name value))
199-
;; headers))
200-
;; nil)]
201-
;; (is (= (core/parse-headers iterator)
202-
;; expected)))
203-
204-
;; []
205-
;; {}
206-
207-
;; [["Set-Cookie" "one"]]
208-
;; {"set-cookie" "one"}
209-
210-
;; [["Set-Cookie" "one"]
211-
;; ["set-COOKIE" "two"]]
212-
;; {"set-cookie" ["one" "two"]}
213-
214-
;; [["Set-Cookie" "one"]
215-
;; ["serVer" "some-server"]
216-
;; ["set-cookie" "two"]]
217-
;; {"set-cookie" ["one" "two"]
218-
;; "server" "some-server"}))
219-
220192
(deftest ^{:integration true} t-streaming-response
221193
(let [stream (:body (request {:request-method :get :uri "/get" :as :stream}))
222194
body (slurp stream)]
223195
(is (= "get" body))))
224-

0 commit comments

Comments
 (0)