Increase MSRV to 1.52.0

- Unconditionally set `deny(unsafe_op_in_unsafe_fn)`
- Unconditionally implement `From<BinaryHeap<T, C>>` for `Vec<T>` and
  remove conditional implementation of `Into<Vec<T>>` for `BinaryHeap<T,
  C>`
- Use intra-doc links

Author: clint-white

.github/workflows/rust.yml

@@ -16,7 +16,7 @@ jobs:
         - macos-latest
         rust:
         - stable
-        - 1.36.0 # MSRV (Rust 2018 and dev-dependency `serde_json`)
+        - 1.52.0  # MSRV
         cargo_args:
         - ""
         - --features serde
@@ -26,12 +26,6 @@ jobs:
           - os: ubuntu-latest
             rust: nightly
             cargo_args: ""
-          - os: ubuntu-latest
-            rust: 1.41.0
-            cargo_args: ""
-          - os: ubuntu-latest
-            rust: 1.52.0
-            cargo_args: ""
           - os: ubuntu-latest
             rust: 1.56.0
             cargo_args: ""

CHANGELOG.md

@@ -11,8 +11,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * `#[must_use]` attribute to many methods, porting and extending several
   rust-lang/rust PRs
 * Method `shrink_to()` for Rust 1.56.0 and greater, ported from rust-lang/rust
-* Implementation of `From<BinaryHeap<T, C>>` for `Vec<T>` for Rust 1.41.0 or
-  greater
 * Implementation of `From<[T; N]>` for `BinaryHeap<T>` for Rust 1.56.0 or
   greater, ported from rust-lang/rust#84111
 * Links to referenced items in the documenation
@@ -22,7 +20,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
-* Bump MSRV (minimum supported rust version) to rust 1.36.0.
+* Bump MSRV (minimum supported rust version) to rust 1.52.0.
+* Implement `From<BinaryHeap<T, C>>` for `Vec<T>` instead of `Into<Vec<T>>` for
+  `BinaryHeap<T, C>`
 * Port rust-lang/rust#77435 improvement to rebuild heuristic of
   `BinaryHeap::append()`
 * Use italics with big-O notation in documentation, ported from

README.md

@@ -26,7 +26,7 @@ This crate is based on the standard library's implementation of
 [`BinaryHeap`](https://doc.rust-lang.org/stable/std/collections/struct.BinaryHeap.html)
 from Rust 1.62.0.
 
-This crate requires Rust 1.36.0 or later.  A few of its APIs are only available
+This crate requires Rust 1.52.0 or later.  A few of its APIs are only available
 for more recent versions of Rust where they have been stabilized in the
 standard library; see the documentation for specifics.
 

build.rs

@@ -1,12 +1,6 @@
 fn main() {
     let ac = autocfg::new();
 
-    // Required in order to implement `From<BinaryHeap<T, C>>` for `Vec<T>`.
-    ac.emit_rustc_version(1, 41);
-
-    // Required for stabilization of `unsafe_op_in_unsafe_fn` lint.
-    ac.emit_rustc_version(1, 52);
-
     // Required for stabilization of `Vec::shrink_to()` and `IntoIterator` for arrays.
     ac.emit_rustc_version(1, 56);
 

src/binary_heap.rs

@@ -18,7 +18,6 @@
 //! [dijkstra]: https://en.wikipedia.org/wiki/Dijkstra%27s_algorithm
 //! [sssp]: https://en.wikipedia.org/wiki/Shortest_path_problem
 //! [dir_graph]: https://en.wikipedia.org/wiki/Directed_graph
-//! [`BinaryHeap`]: struct.BinaryHeap.html
 //!
 //! ```
 //! use std::cmp::Ordering;
@@ -146,8 +145,7 @@
 //! }
 //! ```
 
-#![cfg_attr(rustc_1_52, deny(unsafe_op_in_unsafe_fn))]
-#![cfg_attr(not(rustc_1_52), allow(unused_unsafe))]
+#![deny(unsafe_op_in_unsafe_fn)]
 #![allow(clippy::needless_doctest_main)]
 #![allow(missing_docs)]
 // #![stable(feature = "rust1", since = "1.0.0")]
@@ -264,10 +262,10 @@ use std::vec;
 /// [`Ord`]: https://doc.rust-lang.org/stable/core/cmp/trait.Ord.html
 /// [`Cell`]: https://doc.rust-lang.org/stable/core/cell/struct.Cell.html
 /// [`RefCell`]: https://doc.rust-lang.org/stable/core/cell/struct.RefCell.html
-/// [push]: #method.push
-/// [pop]: #method.pop
-/// [peek]: #method.peek
-/// [peek\_mut]: #method.peek_mut
+/// [push]: BinaryHeap::push
+/// [pop]: BinaryHeap::pop
+/// [peek]: BinaryHeap::peek
+/// [peek\_mut]: BinaryHeap::peek_mut
 // #[stable(feature = "rust1", since = "1.0.0")]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 pub struct BinaryHeap<T, C = MaxComparator> {
@@ -333,8 +331,7 @@ where
 /// This `struct` is created by the [`peek_mut`] method on [`BinaryHeap`]. See
 /// its documentation for more.
 ///
-/// [`peek_mut`]: struct.BinaryHeap.html#method.peek_mut
-/// [`BinaryHeap`]: struct.BinaryHeap.html
+/// [`peek_mut`]: BinaryHeap::peek_mut
 // #[stable(feature = "binary_heap_peek_mut", since = "1.12.0")]
 pub struct PeekMut<'a, T: 'a, C: 'a + Compare<T>> {
     heap: &'a mut BinaryHeap<T, C>,
@@ -1196,7 +1193,7 @@ impl<T, C> BinaryHeap<T, C> {
     /// heap.push(4);
     /// ```
     ///
-    /// [`reserve`]: #method.reserve
+    /// [`reserve`]: BinaryHeap::reserve
     // #[stable(feature = "rust1", since = "1.0.0")]
     pub fn reserve_exact(&mut self, additional: usize) {
         self.data.reserve_exact(additional);
@@ -1468,8 +1465,6 @@ impl<T> Drop for Hole<'_, T> {
 ///
 /// This `struct` is created by [`BinaryHeap::iter()`]. See its
 /// documentation for more.
-///
-/// [`BinaryHeap::iter()`]: struct.BinaryHeap.html#method.iter
 #[must_use = "iterators are lazy and do nothing unless consumed"]
 // #[stable(feature = "rust1", since = "1.0.0")]
 pub struct Iter<'a, T: 'a> {
@@ -1536,7 +1531,6 @@ impl<'a, T> DoubleEndedIterator for Iter<'a, T> {
 /// This `struct` is created by [`BinaryHeap::into_iter()`]
 /// (provided by the [`IntoIterator`] trait). See its documentation for more.
 ///
-/// [`BinaryHeap::into_iter()`]: struct.BinaryHeap.html#method.into_iter
 /// [`IntoIterator`]: https://doc.rust-lang.org/stable/core/iter/trait.IntoIterator.html
 // #[stable(feature = "rust1", since = "1.0.0")]
 #[derive(Clone)]
@@ -1612,8 +1606,6 @@ impl<T, C: Compare<T>> Iterator for IntoIterSorted<T, C> {
 ///
 /// This `struct` is created by [`BinaryHeap::drain()`]. See its
 /// documentation for more.
-///
-/// [`BinaryHeap::drain()`]: struct.BinaryHeap.html#method.drain
 // #[stable(feature = "drain", since = "1.6.0")]
 #[derive(Debug)]
 pub struct Drain<'a, T: 'a> {
@@ -1682,11 +1674,6 @@ impl<T: Ord, const N: usize> From<[T; N]> for BinaryHeap<T> {
     }
 }
 
-/// # Compatibility
-///
-/// This trait is only implemented for Rust 1.41.0 or greater.  For earlier versions, `Into<Vec<T>>`
-/// is implemented for `BinaryHeap<T, C>` instead.
-#[cfg(rustc_1_41)]
 impl<T, C> From<BinaryHeap<T, C>> for Vec<T> {
     /// Converts a `BinaryHeap<T>` into a `Vec<T>`.
     ///
@@ -1697,17 +1684,6 @@ impl<T, C> From<BinaryHeap<T, C>> for Vec<T> {
     }
 }
 
-#[cfg(not(rustc_1_41))]
-impl<T, C> Into<Vec<T>> for BinaryHeap<T, C> {
-    /// Converts a `BinaryHeap<T>` into a `Vec<T>`.
-    ///
-    /// This conversion requires no data movement or allocation, and has
-    /// constant time complexity.
-    fn into(self) -> Vec<T> {
-        self.data
-    }
-}
-
 // #[stable(feature = "rust1", since = "1.0.0")]
 impl<T: Ord> FromIterator<T> for BinaryHeap<T> {
     fn from_iter<I: IntoIterator<Item = T>>(iter: I) -> Self {