enforce that @clerk/shared cannot reference self through imports

Author: nikosdouvlis

eslint.config.mjs

@@ -374,6 +374,29 @@ export default tseslint.config([
       '@typescript-eslint/unbound-method': 'off',
     },
   },
+  {
+    name: 'packages/shared',
+    files: ['packages/shared/src/**/*'],
+    rules: {
+      'no-restricted-imports': [
+        'error',
+        {
+          patterns: [
+            {
+              group: ['@clerk/shared', '@clerk/shared/*'],
+              message:
+                'Do not import from @clerk/shared package exports within the package itself. Use the @/ alias or relative imports from source files instead (e.g., import from "@/types" or "../../types").',
+            },
+            {
+              group: ['../../../*'],
+              message:
+                'Relative imports should not traverse more than 2 levels up (../../). Use the @/ path alias instead (e.g., import from "@/types").',
+            },
+          ],
+        },
+      ],
+    },
+  },
   {
     name: 'packages/expo-passkeys',
     files: ['packages/expo-passkeys/src/**/*'],

packages/shared/src/internal/clerk-js/url.ts

@@ -227,7 +227,7 @@ export function getSearchParameterFromHash({
   return dummyUrlForHash.searchParams.get(paramName);
 }
 
-export function isValidUrl<T extends string | URL | undefined>(val: T): val is NonNullable<T> {
+export function isValidUrl(val: string | URL | undefined | null): boolean {
   if (!val) {
     return false;
   }
@@ -275,7 +275,7 @@ export function isProblematicUrl(url: URL): boolean {
 }
 
 export function isDataUri(val?: string): val is string {
-  if (!isValidUrl(val)) {
+  if (!val || !isValidUrl(val)) {
     return false;
   }
 

packages/shared/src/internal/clerk-js/warnings.ts

@@ -1,4 +1,4 @@
-import type { Serializable } from '../../types';
+import type { Serializable } from '@/types';
 
 const formatWarning = (msg: string) => {
   return `🔒 Clerk:\n${msg.trim()}\n(This notice only appears in development)`;

packages/shared/tsconfig.json

@@ -23,6 +23,7 @@
     "declarationMap": true,
     "allowJs": true,
     "paths": {
+      "@/*": ["./src/*"],
       "virtual:data-hooks/useSubscription": ["./src/react/hooks/useSubscription.swr.tsx"],
       "virtual:data-hooks/SWRConfigCompat": ["./src/react/providers/SWRConfigCompat.swr.tsx"]
     }