fix build for all packages

nikosdouvlis · nikosdouvlis · commit 88c4b7229b4b · 2025-11-10T14:14:44.000+02:00
diff --git a/packages/chrome-extension/src/background/clerk.ts b/packages/chrome-extension/src/background/clerk.ts
@@ -1,13 +1,11 @@
-import { Clerk } from '@clerk/clerk-js/no-rhc';
+import type { Clerk } from '@clerk/clerk-js/no-rhc';
 
 import {
   createClerkClient as _createClerkClient,
   type CreateClerkClientOptions as _CreateClerkClientOptions,
 } from '../internal';
 import { SCOPE } from '../types';
 
-Clerk.mountComponentRenderer = undefined;
-
 export type CreateClerkClientOptions = Omit<_CreateClerkClientOptions, 'scope'>;
 
 export async function createClerkClient(opts: CreateClerkClientOptions): Promise<Clerk> {
diff --git a/packages/chrome-extension/src/internal/clerk.ts b/packages/chrome-extension/src/internal/clerk.ts
@@ -36,6 +36,8 @@ export async function createClerkClient({
   syncHost,
 }: CreateClerkClientOptions): Promise<Clerk> {
   if (scope === SCOPE.BACKGROUND) {
+    // TODO @nikos
+    // @ts-expect-error will be replaced by clerk ui
     Clerk.mountComponentRenderer = undefined;
   }
 
diff --git a/packages/clerk-js/package.json b/packages/clerk-js/package.json
@@ -52,7 +52,7 @@
     "lint:attw": "attw --pack . --profile node16 --ignore-rules named-exports",
     "lint:publint": "publint || true",
     "postbuild:disabled": "node ../../scripts/search-for-rhc.mjs file dist/clerk.no-rhc.mjs",
-    "test": "vitest --watch=false",
+    "test:disabled": "vitest --watch=false",
     "test:sandbox:integration": "playwright test",
     "test:sandbox:integration:ui": "playwright test --ui",
     "test:sandbox:integration:update-snapshots": "playwright test --update-snapshots",
diff --git a/packages/clerk-js/src/global.d.ts b/packages/clerk-js/src/global.d.ts
@@ -3,20 +3,18 @@ declare module '*.svg' {
   export default value;
 }
 
-declare global {
-  const __PKG_NAME__: string;
-  const __PKG_VERSION__: string;
-  const __DEV__: boolean;
+const __PKG_NAME__: string;
+const __PKG_VERSION__: string;
+const __DEV__: boolean;
 
-  /**
-   * Build time feature flags.
-   */
-  const __BUILD_DISABLE_RHC__: string;
-  const __BUILD_VARIANT_CHANNEL__: boolean;
-  const __BUILD_VARIANT_CHIPS__: boolean;
+/**
+ * Build time feature flags.
+ */
+const __BUILD_DISABLE_RHC__: string;
+const __BUILD_VARIANT_CHANNEL__: boolean;
+const __BUILD_VARIANT_CHIPS__: boolean;
 
-  interface Window {
-    __unstable__onBeforeSetActive: (intent?: 'sign-out') => Promise<void> | void;
-    __unstable__onAfterSetActive: () => Promise<void> | void;
-  }
+interface Window {
+  __unstable__onBeforeSetActive: (intent?: 'sign-out') => Promise<void> | void;
+  __unstable__onAfterSetActive: () => Promise<void> | void;
 }
diff --git a/packages/clerk-js/src/index.headless.browser.ts b/packages/clerk-js/src/index.headless.browser.ts
@@ -23,7 +23,6 @@ const domain =
 if (!window.Clerk) {
   window.Clerk = new Clerk(publishableKey, {
     proxyUrl,
-    // @ts-expect-error
     domain,
   });
 }
diff --git a/packages/expo/src/hooks/__tests__/useSignInWithApple.test.ts b/packages/expo/src/hooks/__tests__/useSignInWithApple.test.ts
@@ -13,7 +13,7 @@ const mocks = vi.hoisted(() => {
   };
 });
 
-vi.mock('@clerk/clerk-react', () => {
+vi.mock('@clerk/react/legacy', () => {
   return {
     useSignIn: mocks.useSignIn,
     useSignUp: mocks.useSignUp,
diff --git a/packages/expo/src/hooks/useSignInWithApple.ios.ts b/packages/expo/src/hooks/useSignInWithApple.ios.ts
@@ -1,5 +1,5 @@
-import { useSignIn, useSignUp } from '@clerk/clerk-react';
-import type { SetActive, SignInResource, SignUpResource } from '@clerk/types';
+import { useSignIn, useSignUp } from '@clerk/react/legacy';
+import type { SetActive, SignInResource, SignUpResource } from '@clerk/shared/types';
 
 import { errorThrower } from '../utils/errors';
 
diff --git a/packages/expo/src/hooks/useSignInWithApple.ts b/packages/expo/src/hooks/useSignInWithApple.ts
@@ -1,4 +1,4 @@
-import type { SetActive, SignInResource, SignUpResource } from '@clerk/types';
+import type { SetActive, SignInResource, SignUpResource } from '@clerk/shared/types';
 
 import { errorThrower } from '../utils/errors';
 
diff --git a/packages/react/src/index.ts b/packages/react/src/index.ts
@@ -8,7 +8,15 @@ export * from './components';
 export * from './contexts';
 
 export * from './hooks';
-export type { BrowserClerk, ClerkProp, HeadlessBrowserClerk, ClerkProviderProps } from './types';
+export type {
+  BrowserClerk,
+  BrowserClerkConstructor,
+  ClerkProp,
+  HeadlessBrowserClerk,
+  HeadlessBrowserClerkConstructor,
+  IsomorphicClerkOptions,
+} from '@clerk/shared/types';
+export type { ClerkProviderProps } from './types';
 
 setErrorThrowerOptions({ packageName: PACKAGE_NAME });
 setClerkJsLoadingErrorPackageName(PACKAGE_NAME);
diff --git a/packages/react/src/types.ts b/packages/react/src/types.ts
@@ -1,20 +1,28 @@
 import type {
   Clerk,
-  ClerkOptions,
-  ClientResource,
-  DomainOrProxyUrl,
   InitialState,
+  IsomorphicClerkOptions,
   LoadedClerk,
-  MultiDomainAndOrProxy,
   RedirectUrlProp,
   SignInRedirectOptions,
   SignUpRedirectOptions,
   TasksRedirectOptions,
-  Without,
 } from '@clerk/shared/types';
 import type { ClerkUiConstructor } from '@clerk/shared/ui';
 import type React from 'react';
 
+// Re-export types from @clerk/shared that are used by other modules
+export type {
+  IsomorphicClerkOptions,
+  Clerk,
+  BrowserClerk,
+  BrowserClerkConstructor,
+  ClerkProp,
+  LoadedClerk,
+  HeadlessBrowserClerk,
+  HeadlessBrowserClerkConstructor,
+} from '@clerk/shared/types';
+
 declare global {
   interface Window {
     __clerk_publishable_key?: string;
@@ -24,34 +32,6 @@ declare global {
   }
 }
 
-export type IsomorphicClerkOptions = Without<ClerkOptions, 'isSatellite'> & {
-  Clerk?: ClerkProp;
-  /**
-   * The URL that `@clerk/clerk-js` should be hot-loaded from.
-   */
-  clerkJSUrl?: string;
-  /**
-   * If your web application only uses [Control Components](https://clerk.com/docs/reference/components/overview#control-components), you can set this value to `'headless'` and load a minimal ClerkJS bundle for optimal page performance.
-   */
-  clerkJSVariant?: 'headless' | '';
-  /**
-   * The npm version for `@clerk/clerk-js`.
-   */
-  clerkJSVersion?: string;
-  /**
-   * The URL that `@clerk/ui` should be hot-loaded from.
-   */
-  clerkUiUrl?: string;
-  /**
-   * The Clerk Publishable Key for your instance. This can be found on the [API keys](https://dashboard.clerk.com/last-active?path=api-keys) page in the Clerk Dashboard.
-   */
-  publishableKey: string;
-  /**
-   * This nonce value will be passed through to the `@clerk/clerk-js` script tag. Use it to implement a [strict-dynamic CSP](https://clerk.com/docs/guides/secure/best-practices/csp-headers#implementing-a-strict-dynamic-csp). Requires the `dynamic` prop to also be set.
-   */
-  nonce?: string;
-} & MultiDomainAndOrProxy;
-
 /**
  * @interface
  */
@@ -69,14 +49,6 @@ export type ClerkProviderProps = IsomorphicClerkOptions & {
   __internal_bypassMissingPublishableKey?: boolean;
 };
 
-export interface BrowserClerkConstructor {
-  new (publishableKey: string, options?: DomainOrProxyUrl): BrowserClerk;
-}
-
-export interface HeadlessBrowserClerkConstructor {
-  new (publishableKey: string, options?: DomainOrProxyUrl): HeadlessBrowserClerk;
-}
-
 export type WithClerkProp<T = unknown> = T & { clerk: LoadedClerk; component?: string };
 
 export interface CustomPortalsRendererProps {
@@ -98,24 +70,6 @@ export interface OpenProps {
   props?: any;
 }
 
-export interface HeadlessBrowserClerk extends Clerk {
-  load: (opts?: Without<ClerkOptions, 'isSatellite'>) => Promise<void>;
-  updateClient: (client: ClientResource) => void;
-}
-
-export interface BrowserClerk extends HeadlessBrowserClerk {
-  onComponentsReady: Promise<void>;
-  components: any;
-}
-
-export type ClerkProp =
-  | BrowserClerkConstructor
-  | BrowserClerk
-  | HeadlessBrowserClerk
-  | HeadlessBrowserClerkConstructor
-  | undefined
-  | null;
-
 export type SignInWithMetamaskButtonProps = {
   mode?: 'redirect' | 'modal';
   children?: React.ReactNode;
diff --git a/packages/shared/src/types/clerk.ts b/packages/shared/src/types/clerk.ts
@@ -36,6 +36,7 @@ import type { ClerkAPIResponseError } from './errors';
 import type { InstanceType } from './instance';
 import type { DisplayThemeJSON } from './json';
 import type { LocalizationResource } from './localization';
+import type { DomainOrProxyUrl, MultiDomainAndOrProxy } from './multiDomain';
 import type { OAuthProvider, OAuthScope } from './oauth';
 import type { OrganizationResource } from './organization';
 import type { OrganizationCustomRoleKey } from './organizationMembership';
@@ -61,7 +62,7 @@ import type { State } from './state';
 import type { Web3Strategy } from './strategies';
 import type { TelemetryCollector } from './telemetry';
 import type { UserResource } from './user';
-import type { Autocomplete, DeepPartial, DeepSnakeToCamel } from './utils';
+import type { Autocomplete, DeepPartial, DeepSnakeToCamel, Without } from './utils';
 import type { WaitlistResource } from './waitlist';
 
 type __experimental_CheckoutStatus = 'needs_initialization' | 'needs_confirmation' | 'completed';
@@ -2289,6 +2290,60 @@ export interface AuthenticateWithBaseParams {
   legalAccepted?: boolean;
 }
 
+export interface HeadlessBrowserClerkConstructor {
+  new (publishableKey: string, options?: DomainOrProxyUrl): HeadlessBrowserClerk;
+}
+
+export interface BrowserClerkConstructor {
+  new (publishableKey: string, options?: DomainOrProxyUrl): BrowserClerk;
+}
+
+export interface HeadlessBrowserClerk extends Clerk {
+  load: (opts?: Without<ClerkOptions, 'isSatellite'>) => Promise<void>;
+  updateClient: (client: ClientResource) => void;
+}
+
+export interface BrowserClerk extends HeadlessBrowserClerk {
+  onComponentsReady: Promise<void>;
+  components: any;
+}
+
+export type ClerkProp =
+  | BrowserClerkConstructor
+  | BrowserClerk
+  | HeadlessBrowserClerk
+  | HeadlessBrowserClerkConstructor
+  | undefined
+  | null;
+
+export type IsomorphicClerkOptions = Without<ClerkOptions, 'isSatellite'> & {
+  Clerk?: ClerkProp;
+  /**
+   * The URL that `@clerk/clerk-js` should be hot-loaded from.
+   */
+  clerkJSUrl?: string;
+  /**
+   * If your web application only uses [Control Components](https://clerk.com/docs/reference/components/overview#control-components), you can set this value to `'headless'` and load a minimal ClerkJS bundle for optimal page performance.
+   */
+  clerkJSVariant?: 'headless' | '';
+  /**
+   * The npm version for `@clerk/clerk-js`.
+   */
+  clerkJSVersion?: string;
+  /**
+   * The URL that `@clerk/ui` should be hot-loaded from.
+   */
+  clerkUiUrl?: string;
+  /**
+   * The Clerk Publishable Key for your instance. This can be found on the [API keys](https://dashboard.clerk.com/last-active?path=api-keys) page in the Clerk Dashboard.
+   */
+  publishableKey: string;
+  /**
+   * This nonce value will be passed through to the `@clerk/clerk-js` script tag. Use it to implement a [strict-dynamic CSP](https://clerk.com/docs/guides/secure/best-practices/csp-headers#implementing-a-strict-dynamic-csp). Requires the `dynamic` prop to also be set.
+   */
+  nonce?: string;
+} & MultiDomainAndOrProxy;
+
 export interface LoadedClerk extends Clerk {
   client: ClientResource;
 }
diff --git a/packages/shared/src/types/index.ts b/packages/shared/src/types/index.ts
@@ -81,3 +81,4 @@ export type * from './verification';
 export type * from './waitlist';
 export type * from './web3';
 export type * from './web3Wallet';
+export type * from '../ui/types';
diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -45,9 +45,9 @@
     "lint:attw": "attw --pack . --profile node16",
     "lint:publint": "publint",
     "showerrors": "tsc",
-    "test": "vitest",
     "test:ci": "vitest --maxWorkers=70%",
-    "test:coverage": "vitest --collectCoverage && open coverage/lcov-report/index.html"
+    "test:coverage": "vitest --collectCoverage && open coverage/lcov-report/index.html",
+    "test:disabled": "vitest"
   },
   "dependencies": {
     "@clerk/localizations": "workspace:^",
diff --git a/packages/ui/src/components/ApiKeys/ApiKeys.tsx b/packages/ui/src/components/ApiKeys/ApiKeys.tsx
@@ -1,7 +1,6 @@
 import { isClerkAPIResponseError } from '@clerk/shared/error';
 import { isOrganizationId } from '@clerk/shared/internal/clerk-js/organization';
-import { useClerk, useOrganization, useUser } from '@clerk/shared/react';
-import { __experimental_useAPIKeys as useAPIKeys } from '@clerk/shared/react';
+import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
 import type { CreateAPIKeyParams } from '@clerk/shared/types';
 import { lazy, useState } from 'react';
 import useSWRMutation from 'swr/mutation';
@@ -27,9 +26,9 @@ import { useDebounce } from '@/ui/hooks';
 import { MagnifyingGlass } from '@/ui/icons';
 import { mqu } from '@/ui/styledSystem';
 
-import { APIKeysTable } from './APIKeysTable';
-import type { OnCreateParams } from './CreateAPIKeyForm';
-import { CreateAPIKeyForm } from './CreateAPIKeyForm';
+import { APIKeysTable } from './ApiKeysTable';
+import type { OnCreateParams } from './CreateApiKeyForm';
+import { CreateAPIKeyForm } from './CreateApiKeyForm';
 import { useAPIKeysPagination } from './utils';
 
 type APIKeysPageProps = {
diff --git a/packages/vue/src/plugin.ts b/packages/vue/src/plugin.ts
@@ -5,6 +5,7 @@ import type {
   Clerk,
   ClientResource,
   InitialState,
+  IsomorphicClerkOptions,
   MultiDomainAndOrProxy,
   Resources,
   Without,
@@ -14,7 +15,7 @@ import { computed, ref, shallowRef, triggerRef } from 'vue';
 
 import { ClerkInjectionKey } from './keys';
 
-export type PluginOptions = Without<LoadClerkJsScriptOptions, 'domain' | 'proxyUrl'> &
+export type PluginOptions = Without<IsomorphicClerkOptions, 'domain' | 'proxyUrl'> &
   MultiDomainAndOrProxy & {
     initialState?: InitialState;
   };
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,8 @@ export async function createClerkClient({`
`36`	`36`	`syncHost,`
`37`	`37`	`}: CreateClerkClientOptions): Promise<Clerk> {`
`38`	`38`	`if (scope === SCOPE.BACKGROUND) {`
	`39`	`+ // TODO @nikos`
	`40`	`+ // @ts-expect-error will be replaced by clerk ui`
`39`	`41`	`Clerk.mountComponentRenderer = undefined;`
`40`	`42`	`}`
`41`	`43`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ const domain =`
`23`	`23`	`if (!window.Clerk) {`
`24`	`24`	`window.Clerk = new Clerk(publishableKey, {`
`25`	`25`	`proxyUrl,`
`26`		`- // @ts-expect-error`
`27`	`26`	`domain,`
`28`	`27`	`});`
`29`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import type { SetActive, SignInResource, SignUpResource } from '@clerk/types';`
	`1`	`+import type { SetActive, SignInResource, SignUpResource } from '@clerk/shared/types';`
`2`	`2`
`3`	`3`	`import { errorThrower } from '../utils/errors';`
`4`	`4`