Merge pull request #14 from clappr/fix-ready-state

Ensure the existence of the HLS.JS internal instance on the ready state

Author: joaopaulovieira

src/hls.js

@@ -192,6 +192,8 @@ export default class HlsjsPlayback extends HTML5Video {
   }
 
   _ready() {
+    if (this._isReadyState) return
+    !this._hls && this._setup()
     this._isReadyState = true
     this.trigger(Events.PLAYBACK_READY, this.name)
   }

src/hls.test.js

@@ -173,6 +173,50 @@ describe('HlsjsPlayback', () => {
     })
   })
 
+  describe('_ready method', () => {
+    test('avoid to run internal logic if _isReadyState flag is true', () => {
+      const playback = new HlsjsPlayback({ src: 'http://clappr.io/video.m3u8' })
+      playback._isReadyState = true
+      jest.spyOn(playback, '_setup')
+      playback._ready()
+
+      expect(playback._setup).not.toHaveBeenCalled()
+    })
+
+    test('call _setup method if HLS.JS internal don\'t exists', () => {
+      const playback = new HlsjsPlayback({ src: 'http://clappr.io/video.m3u8' })
+      jest.spyOn(playback, '_setup')
+      playback._ready()
+
+      expect(playback._setup).toHaveBeenCalledTimes(1)
+
+      playback._ready()
+      expect(playback._setup).toHaveBeenCalledTimes(1)
+    })
+
+    test('update _isReadyState flag value to true', () => {
+      const playback = new HlsjsPlayback({ src: 'http://clappr.io/video.m3u8' })
+
+      expect(playback._isReadyState).toBeFalsy()
+
+      playback._ready()
+
+      expect(playback._isReadyState).toBeTruthy()
+    })
+
+    test('triggers PLAYBACK_READY event', done => {
+      const cb = jest.fn()
+      const playback = new HlsjsPlayback({ src: 'http://clappr.io/video.m3u8' })
+
+      playback.listenTo(playback, Events.PLAYBACK_READY, cb)
+      playback.listenTo(playback, Events.PLAYBACK_READY, () => {
+        expect(cb).toHaveBeenCalledTimes(1)
+        done()
+      })
+      playback._ready()
+    })
+  })
+
   describe('play method', () => {
     test('calls this._hls.loadSource if _manifestParsed flag and options.hlsPlayback.preload are falsy', () => {
       const playback = new HlsjsPlayback({ src: 'http://clappr.io/foo.m3u8', hlsPlayback: { preload: true } })