v4

Author: Dominik Zogg

README.md

@@ -14,9 +14,9 @@ A simple http handler implementation for API.
 ## Requirements
 
  * php: ^7.2
- * chubbyphp/chubbyphp-deserialization: ^2.17.1
+ * chubbyphp/chubbyphp-deserialization: ^3.0
  * chubbyphp/chubbyphp-negotiation: ^1.5.3
- * chubbyphp/chubbyphp-serialization: ^2.13.2
+ * chubbyphp/chubbyphp-serialization: ^3.0
  * psr/http-factory: ^1.0.1
  * psr/http-message: ^1.0.1
  * psr/http-server-middleware: ^1.0.1
@@ -27,7 +27,7 @@ A simple http handler implementation for API.
 Through [Composer](http://getcomposer.org) as [chubbyphp/chubbyphp-api-http][1].
 
 ```sh
-composer require chubbyphp/chubbyphp-api-http "^3.4"
+composer require chubbyphp/chubbyphp-api-http "^4.0"
 ```
 
 ## Usage

composer.json

@@ -11,9 +11,9 @@
     ],
     "require": {
         "php": "^7.2",
-        "chubbyphp/chubbyphp-deserialization": "^2.17.1",
+        "chubbyphp/chubbyphp-deserialization": "^3.0@dev",
         "chubbyphp/chubbyphp-negotiation": "^1.5.3",
-        "chubbyphp/chubbyphp-serialization": "^2.13.2",
+        "chubbyphp/chubbyphp-serialization": "^3.0@dev",
         "psr/http-factory": "^1.0.1",
         "psr/http-message": "^1.0.1",
         "psr/http-server-middleware": "^1.0.1",
@@ -43,7 +43,7 @@
     },
     "extra": {
         "branch-alias": {
-            "dev-master": "3.4-dev"
+            "dev-master": "4.0-dev"
         }
     },
     "scripts": {

src/Manager/ResponseManager.php

@@ -5,7 +5,6 @@
 namespace Chubbyphp\ApiHttp\Manager;
 
 use Chubbyphp\ApiHttp\ApiProblem\ApiProblemInterface;
-use Chubbyphp\Deserialization\DeserializerInterface;
 use Chubbyphp\Serialization\Normalizer\NormalizerContextInterface;
 use Chubbyphp\Serialization\SerializerInterface;
 use Psr\Http\Message\ResponseFactoryInterface;
@@ -23,21 +22,10 @@ final class ResponseManager implements ResponseManagerInterface
      */
     private $serializer;
 
-    public function __construct()
+    public function __construct(ResponseFactoryInterface $responseFactory, SerializerInterface $serializer)
     {
-        $args = func_get_args();
-
-        if ($args[0] instanceof DeserializerInterface) {
-            @trigger_error(
-                'Remove deserializer as first argument.',
-                E_USER_DEPRECATED
-            );
-
-            array_shift($args);
-        }
-
-        $this->setResponseFactory($args[0]);
-        $this->setSerializer($args[1]);
+        $this->responseFactory = $responseFactory;
+        $this->serializer = $serializer;
     }
 
     /**
@@ -88,14 +76,4 @@ public function createFromApiProblem(
 
         return $response;
     }
-
-    private function setResponseFactory(ResponseFactoryInterface $responseFactory): void
-    {
-        $this->responseFactory = $responseFactory;
-    }
-
-    private function setSerializer(SerializerInterface $serializer): void
-    {
-        $this->serializer = $serializer;
-    }
 }

tests/Unit/Manager/ResponseManagerTest.php

@@ -6,7 +6,6 @@
 
 use Chubbyphp\ApiHttp\ApiProblem\ApiProblemInterface;
 use Chubbyphp\ApiHttp\Manager\ResponseManager;
-use Chubbyphp\Deserialization\DeserializerInterface;
 use Chubbyphp\Mock\Call;
 use Chubbyphp\Mock\MockByCallsTrait;
 use Chubbyphp\Serialization\Normalizer\NormalizerContextInterface;
@@ -26,50 +25,6 @@ final class ResponseManagerTest extends TestCase
 {
     use MockByCallsTrait;
 
-    public function testCreateWithDefaultsAndDeserializer(): void
-    {
-        $bodyString = '{"key": "value"}';
-
-        $object = new \stdClass();
-
-        /** @var DeserializerInterface|MockObject $deserializer */
-        $deserializer = $this->getMockByCalls(DeserializerInterface::class);
-
-        /** @var StreamInterface|MockObject $body */
-        $body = $this->getMockByCalls(StreamInterface::class, [
-            Call::create('write')->with($bodyString),
-        ]);
-
-        /** @var Response|MockObject $response */
-        $response = $this->getMockByCalls(Response::class, [
-            Call::create('withHeader')->with('Content-Type', 'application/json')->willReturnSelf(),
-            Call::create('getBody')->with()->willReturn($body),
-        ]);
-
-        /** @var ResponseFactoryInterface|MockObject $responseFactory */
-        $responseFactory = $this->getMockByCalls(ResponseFactoryInterface::class, [
-            Call::create('createResponse')->with(200, '')->willReturn($response),
-        ]);
-
-        /** @var SerializerInterface|MockObject $serializer */
-        $serializer = $this->getMockByCalls(SerializerInterface::class, [
-            Call::create('serialize')->with($object, 'application/json', null, '')->willReturn($bodyString),
-        ]);
-
-        error_clear_last();
-
-        $responseManager = new ResponseManager($deserializer, $responseFactory, $serializer);
-
-        $error = error_get_last();
-
-        self::assertNotNull($error);
-
-        self::assertSame(E_USER_DEPRECATED, $error['type']);
-        self::assertSame('Remove deserializer as first argument.', $error['message']);
-
-        self::assertSame($response, $responseManager->create($object, 'application/json'));
-    }
-
     public function testCreateWithDefaults(): void
     {
         $bodyString = '{"key": "value"}';