fix(): image didn't appear (moved fetching image from onAppear to initializer)

celies-e · celies-e · commit ad0cf3c0c2dc · 2020-03-27T15:53:37.000+01:00
diff --git a/Sources/RemoteImage/public/Views/RemoteImage.swift b/Sources/RemoteImage/public/Views/RemoteImage.swift
@@ -40,9 +40,6 @@ public struct RemoteImage<ErrorView: View, ImageView: View, LoadingView: View>:
             case .loading:
                 return AnyView(
                     loadingView()
-                    .onAppear {
-                        self.service.fetchImage(ofType: self.type)
-                    }
                 )
         }
     }
@@ -52,6 +49,8 @@ public struct RemoteImage<ErrorView: View, ImageView: View, LoadingView: View>:
         self.errorView = errorView
         self.imageView = imageView
         self.loadingView = loadingView
+
+        service.fetchImage(ofType: type)
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,6 @@ public struct RemoteImage<ErrorView: View, ImageView: View, LoadingView: View>:`
`40`	`40`	`case .loading:`
`41`	`41`	`return AnyView(`
`42`	`42`	`loadingView()`
`43`		`- .onAppear {`
`44`		`- self.service.fetchImage(ofType: self.type)`
`45`		`- }`
`46`	`43`	`)`
`47`	`44`	`}`
`48`	`45`	`}`
`@@ -52,6 +49,8 @@ public struct RemoteImage<ErrorView: View, ImageView: View, LoadingView: View>:`
`52`	`49`	`self.errorView = errorView`
`53`	`50`	`self.imageView = imageView`
`54`	`51`	`self.loadingView = loadingView`
	`52`	`+`
	`53`	`+ service.fetchImage(ofType: type)`
`55`	`54`	`}`
`56`	`55`	`}`
`57`	`56`