Skip to content

Commit 7241d3d

Browse files
committed
add note
1 parent 1c5633c commit 7241d3d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

message.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -562,6 +562,7 @@ static void php_protocolbuffers_message_set(INTERNAL_FUNCTION_PARAMETERS, zval *
562562

563563
} else {
564564
if (Z_TYPE_P(value) == IS_ARRAY) {
565+
/* NOTE(chobie): Array to Object conversion */
565566
zval *param;
566567

567568
MAKE_STD_ZVAL(tmp);
@@ -638,8 +639,8 @@ static void php_protocolbuffers_message_clear(INTERNAL_FUNCTION_PARAMETERS, zval
638639
zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC, "clear method can't use for extension value", name);
639640
return;
640641
}
641-
php_protocolbuffers_message_get_hash_table_by_container(container, scheme, instance, &htt, &n, &n_len TSRMLS_CC);
642642

643+
php_protocolbuffers_message_get_hash_table_by_container(container, scheme, instance, &htt, &n, &n_len TSRMLS_CC);
643644
if (zend_hash_find(htt, n, n_len, (void **)&e) == SUCCESS) {
644645
zval *vl = NULL;
645646

@@ -763,7 +764,7 @@ static void php_protocolbuffers_message_has(INTERNAL_FUNCTION_PARAMETERS, zval *
763764
}
764765

765766
if (scheme->is_extension) {
766-
zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC, "get method can't use for extension value", name);
767+
zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC, "has method can't use for extension value", name);
767768
return;
768769
}
769770

0 commit comments

Comments
 (0)