test coverage

Author: codemasher

src/message_helpers.php

@@ -239,6 +239,9 @@ function decompress_content(MessageInterface $message):string{
 	'ldap'   => 389,
 ];
 
+/**
+ * Checks whether the URI has a port set and if that port is one of the default ports for the given scheme
+ */
 function uriIsDefaultPort(UriInterface $uri):bool{
 	$port   = $uri->getPort();
 	$scheme = $uri->getScheme();
@@ -292,7 +295,6 @@ function uriIsAbsolutePathReference(UriInterface $uri):bool{
  *
  * A relative reference that does not begin with a slash character is termed a relative-path reference.
  *
- * @return bool
  * @link https://tools.ietf.org/html/rfc3986#section-4.2
  */
 function uriIsRelativePathReference(UriInterface $uri):bool{

tests/FactoryHelpersTest.php

@@ -11,10 +11,10 @@
 namespace chillerlan\HTTPTest\Utils;
 
 use chillerlan\HTTP\Utils\Server;
+use InvalidArgumentException;
 
 use function time;
-use const UPLOAD_ERR_OK;
-use const UPLOAD_ERR_PARTIAL;
+use const UPLOAD_ERR_OK, UPLOAD_ERR_PARTIAL;
 
 class FactoryHelpersTest extends TestAbstract{
 
@@ -236,4 +236,10 @@ public function testNormalizeMultipleFiles():void{
 		$this::assertSame(UPLOAD_ERR_PARTIAL, $normalized[1]->getError());
 	}
 
+	public function testNormalizeFilesInvalidValueException():void{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('Invalid value in files specification');
+		$this->server->normalizeFiles(['files' => 'foo']);
+	}
+
 }

tests/MessageHelpersTest.php

@@ -13,11 +13,13 @@
 use TypeError;
 
 use function chillerlan\HTTP\Utils\{
-	decompress_content, get_json, get_xml, message_to_string, r_rawurlencode,
-	uriIsAbsolute, uriIsAbsolutePathReference, uriIsNetworkPathReference,
+	decompress_content, get_json, get_xml, message_to_string, parseUrl, r_rawurlencode,
+	uriIsAbsolute, uriIsAbsolutePathReference, uriIsDefaultPort, uriIsNetworkPathReference,
 	uriIsRelativePathReference, uriWithoutQueryValue, uriWithQueryValue
 };
 
+use const chillerlan\HTTP\Utils\URI_DEFAULT_PORTS;
+
 class MessageHelpersTest extends TestAbstract{
 
 	public function rawurlencodeDataProvider():array{
@@ -222,4 +224,41 @@ public function testUriWithoutQueryValueHandlesEncoding():void{
 		$this::assertSame('', $uri->getQuery());
 	}
 
+	public function testUriIsDefaultPort():void{
+
+		foreach(URI_DEFAULT_PORTS as $scheme => $port){
+			$uri = $this->uriFactory->createUri($scheme.'://localhost:'.$port);
+
+			$this::assertTrue(uriIsDefaultPort($uri));
+			$this->assertSame($scheme.'://localhost', (string)$uri);
+		}
+
+		$uri = $this->uriFactory->createUri('https://localhost:42');
+		$this->assertSame('https://localhost:42', (string)$uri);
+
+	}
+
+	public function parseUrlProvider():array{
+		return [
+			['http://', null],
+			['https://яндекAс.рф', [
+				'scheme' => 'https',
+				'host'   => 'яндекAс.рф'
+			]],
+			['http://[2a00:f48:1008::212:183:10]:56?foo=bar', [
+				'scheme' => 'http',
+				'host'   => '[2a00:f48:1008::212:183:10]',
+				'port'   => '56',
+				'query'  => 'foo=bar',
+			]]
+		];
+	}
+
+	/**
+	 * @dataProvider parseUrlProvider
+	 */
+	public function testParseUrl($url, $expected):void{
+		$this::assertSame($expected, parseUrl($url));
+	}
+
 }