feat: Don't update self-{avatar,status} from received messages (#7002) #7526
Conversation
The normal way of synchronizing self-avatar and -status nowadays is sync messages.
link2xt
left a comment
link2xt
left a comment
There was a problem hiding this comment.
Good thing about synchronizing from non-sync message is that it works even if sync message is lost. With this change if sync message is lost, avatar and status is not synced anymore.
Overall I don't like the idea of changing something in this logic without reproducing the bug first, #7002 is closed as we cannot find a way to reproduce it.
| /// Reactions do not contain the status, | ||
| /// but should not result in self-status being reset on other devices. | ||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn test_reaction_status_multidevice() -> Result<()> { |
There was a problem hiding this comment.
Why the test is removed, did it break?
There was a problem hiding this comment.
It broke because it also tests that the self-status is synced from outgoing messages. Anyway, it's no longer relevant because with this PR there's nothing special to reactions anymore. The new behavior is now tested by contact_tests::test_synchronize_status
OTOH the avatar and status can't be reverted to the old ones anymore, this looks more valuable to me. Otherwise we need to add some timestamp of the avatar/status change and do smth similar to we do in the group consistency algo.
This isn't only to (maybe) fix #7002 , but also to simplify the code and make the self-avatar and -status sync logic the same as for other synced config keys. Wrt #7002 , i'm able to reproduce it if i change the self-status, delete the sync message and send a message to "Saved Messages" from another device. This reverts the self-status change on the first device. Maybe it was not the case for that issue, but lost sync messages aren't smth that cannot happen, sometimes i experience lost messages in my Gmail profile. |
The normal way of synchronizing self-avatar and -status nowadays is sync messages.
This is the second commit from #7123
Fixes (probably) #7002