Skip to content

Commit 3d86cb5

Browse files
committed
test: remove ThreadPoolExecutor from test_wait_next_messages
1 parent 75eb94e commit 3d86cb5

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

deltachat-rpc-client/src/deltachat_rpc_client/account.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,9 +399,10 @@ def get_next_messages(self) -> list[Message]:
399399
next_msg_ids = self._rpc.get_next_msgs(self.id)
400400
return [Message(self, msg_id) for msg_id in next_msg_ids]
401401

402+
@futuremethod
402403
def wait_next_messages(self) -> list[Message]:
403404
"""Wait for new messages and return a list of them."""
404-
next_msg_ids = self._rpc.wait_next_msgs(self.id)
405+
next_msg_ids = yield self._rpc.wait_next_msgs.future(self.id)
405406
return [Message(self, msg_id) for msg_id in next_msg_ids]
406407

407408
def wait_for_incoming_msg_event(self):

deltachat-rpc-client/tests/test_something.py

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -484,22 +484,21 @@ def test_wait_next_messages(acfactory) -> None:
484484
# There are no old messages and the call returns immediately.
485485
assert not bot.wait_next_messages()
486486

487-
with concurrent.futures.ThreadPoolExecutor(max_workers=1) as executor:
488-
# Bot starts waiting for messages.
489-
next_messages_task = executor.submit(bot.wait_next_messages)
487+
# Bot starts waiting for messages.
488+
next_messages_task = bot.wait_next_messages.future()
490489

491-
alice_contact_bot = alice.create_contact(bot, "Bot")
492-
alice_chat_bot = alice_contact_bot.create_chat()
493-
alice_chat_bot.send_text("Hello!")
490+
alice_contact_bot = alice.create_contact(bot, "Bot")
491+
alice_chat_bot = alice_contact_bot.create_chat()
492+
alice_chat_bot.send_text("Hello!")
494493

495-
next_messages = next_messages_task.result()
494+
next_messages = next_messages_task()
496495

497-
if len(next_messages) == E2EE_INFO_MSGS:
498-
next_messages += bot.wait_next_messages()
496+
if len(next_messages) == E2EE_INFO_MSGS:
497+
next_messages += bot.wait_next_messages()
499498

500-
assert len(next_messages) == 1 + E2EE_INFO_MSGS
501-
snapshot = next_messages[0 + E2EE_INFO_MSGS].get_snapshot()
502-
assert snapshot.text == "Hello!"
499+
assert len(next_messages) == 1 + E2EE_INFO_MSGS
500+
snapshot = next_messages[0 + E2EE_INFO_MSGS].get_snapshot()
501+
assert snapshot.text == "Hello!"
503502

504503

505504
def test_import_export_backup(acfactory, tmp_path) -> None:

0 commit comments

Comments
 (0)