Commit 0e7e35b
committed
feat: Do not copy Chat-Version header into outer part
Chat-Version is used sometimes by Sieve filters to move messages to DeltaChat folder:
https://github.com/mailcow/mailcow-dockerized/blob/37beed6ad93f259b97cad41877982bce95295629/data/conf/dovecot/global_sieve_before
This probably prevents notifications to MUAs that don't watch DeltaChat but watch INBOX.
There are however disadvantages to exposing Chat-Version:
1. Spam filters may not like this header and it is difficult or impossible to tell if `Chat-Version`
plays role in rejecting the message or delivering it into Spam folder. If there is no such header
visible to the spam filter, this possibility can be ruled out.
2. Replies to chat messages may have no `Chat-Version` but have to be moved anyway.
3. The user may have no control over the Sieve filter, but it comes preconfigured in mailcow, so it
is not possible to disable it on the client.
Thanks to link2xt for providing this motivation.
NOTE: Old Delta Chat will assign partially downloaded replies to an ad-hoc group with the sender
instead of the 1:1 chat, but we're removing partial downloads anyway.1 parent 148ff5a commit 0e7e35b
2 files changed
+5
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
947 | 947 | | |
948 | 948 | | |
949 | 949 | | |
950 | | - | |
951 | | - | |
| 950 | + | |
952 | 951 | | |
953 | 952 | | |
954 | 953 | | |
| |||
1063 | 1062 | | |
1064 | 1063 | | |
1065 | 1064 | | |
1066 | | - | |
1067 | | - | |
1068 | | - | |
1069 | | - | |
1070 | | - | |
| 1065 | + | |
1071 | 1066 | | |
1072 | 1067 | | |
1073 | 1068 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2414 | 2414 | | |
2415 | 2415 | | |
2416 | 2416 | | |
2417 | | - | |
| 2417 | + | |
2418 | 2418 | | |
2419 | 2419 | | |
2420 | 2420 | | |
| |||
2561 | 2561 | | |
2562 | 2562 | | |
2563 | 2563 | | |
| 2564 | + | |
2564 | 2565 | | |
2565 | 2566 | | |
2566 | 2567 | | |
| |||
2579 | 2580 | | |
2580 | 2581 | | |
2581 | 2582 | | |
2582 | | - | |
| 2583 | + | |
2583 | 2584 | | |
2584 | 2585 | | |
2585 | 2586 | | |
| |||
0 commit comments