Prevent overallocating space for message recipients

rbuch · rbuch · commit 327b6d9a36a3 · 2021-05-03T12:37:48.000-04:00
diff --git a/src/projections/Tools/Timeline/TimelineMessage.java b/src/projections/Tools/Timeline/TimelineMessage.java
@@ -126,8 +126,10 @@ protected EntryMethodObject getSender() {
 
 	protected void addRecipient(EntryMethodObject obj) {
 		synchronized (this) {
-			if (recipients == null)
-				recipients = new ArrayList<>();
+			if (recipients == null) {
+				// Set initialCapacity to 1 to prevent recipients from allocating more memory than needed
+				recipients = new ArrayList<>(1);
+			}
 			recipients.add(obj);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -126,8 +126,10 @@ protected EntryMethodObject getSender() {`
`126`	`126`
`127`	`127`	`protected void addRecipient(EntryMethodObject obj) {`
`128`	`128`	`synchronized (this) {`
`129`		`- if (recipients == null)`
`130`		`- recipients = new ArrayList<>();`
	`129`	`+ if (recipients == null) {`
	`130`	`+ // Set initialCapacity to 1 to prevent recipients from allocating more memory than needed`
	`131`	`+ recipients = new ArrayList<>(1);`
	`132`	`+ }`
`131`	`133`	`recipients.add(obj);`
`132`	`134`	`}`
`133`	`135`	`}`