Fix for chaostoolkit/chaostoolkit#192

Signed-off-by: Sylvain Hellegouarch <sh@defuze.org>

Author: Lawouach

chaoslib/run.py

@@ -469,6 +469,7 @@ def run_gate_hypothesis(experiment: Experiment, journal: Journal,
             "Steady state probe '{p}' is not in the given "
             "tolerance so failing this experiment".format(
                 p=p["activity"]["name"]))
+        return
     event_registry.hypothesis_before_completed(experiment, state, journal)
     return state
 

tests/fixtures/experiments.py

@@ -933,3 +933,39 @@
         }
     ]
 }
+
+
+SimpleExperimentWithFailingHypothesis = {
+    "version": "1.0.0",
+    "title": "Hello world!",
+    "description": "Say hello world.",
+    "steady-state-hypothesis": {
+        "title": "World needs politeness",
+        "probes": [
+            {
+                "type": "probe",
+                "name": "has-world",
+                "tolerance": 1,
+                "provider": {
+                "type": "process",
+                "path": "echo",
+                    "arguments": "hello"
+                }
+            }
+        ]
+    },
+    "method": [
+        {
+            "type": "action",
+            "name": "say-hello",
+            "provider": {
+                "type": "process",
+                "path": "echo",
+                "arguments": "world"
+            },
+            "pauses": {
+                "after": 1
+            }
+        }
+    ]
+}

tests/test_run.py

@@ -238,3 +238,15 @@ def test_exceptions_does_not_stop_handler_registry():
         "hypothesis_after_completed",
         "start_cooldown", "cooldown_completed"
     ]
+
+
+def test_do_not_ruin_method_on_failing_before_ssh():
+    experiment = experiments.SimpleExperimentWithFailingHypothesis.copy()
+    journal = run_experiment(experiment, strategy=Strategy.DEFAULT)
+    assert journal is not None
+    assert journal["steady_states"]["before"] is not None
+    assert journal["steady_states"]["after"] is None
+    assert journal["steady_states"]["during"] == []
+    assert journal["status"] == "failed"
+    assert journal["deviated"] == False
+    assert len(journal["run"]) == 0