Let controls update conf/secrets

Closes #181

Signed-off-by: Sylvain Hellegouarch <sh@defuze.org>

Author: Lawouach

CHANGELOG.md

@@ -4,6 +4,13 @@
 
 [Unreleased]: https://github.com/chaostoolkit/chaostoolkit-lib/compare/1.11.0...HEAD
 
+## Changed
+
+- Controls can now update/change configuration and secrets on the fly as per
+  the specification [#181][181]
+
+[181]: https://github.com/chaostoolkit/chaostoolkit-lib/issues/181
+
 ## [1.11.0][] - 2020-07-06
 
 [1.11.0]: https://github.com/chaostoolkit/chaostoolkit-lib/compare/1.10.0...1.11.0

chaoslib/control/python.py

@@ -127,10 +127,10 @@ def apply_python_control(level: str, control: Control,  # noqa: C901
     if "secrets" in provider and "secrets" in sig.parameters:
         arguments["secrets"] = {}
         for s in provider["secrets"]:
-            arguments["secrets"].update(secrets.get(s, {}).copy())
+            arguments["secrets"].update(secrets.get(s, {}))
 
     if "configuration" in sig.parameters:
-        arguments["configuration"] = configuration.copy()
+        arguments["configuration"] = configuration
 
     if "state" in sig.parameters:
         arguments["state"] = state

tests/fixtures/controls/dummy_changed_configuration.py

@@ -0,0 +1,8 @@
+from chaoslib.types import Activity, Configuration, Run, Secrets
+
+
+def after_activity_control(context: Activity, state: Run,
+                           configuration: Configuration = None,
+                           secrets: Secrets = None, **kwargs):
+    if context["name"] == "generate-token":
+        configuration["my_token"] = state["output"]

tests/fixtures/controls/dummy_changed_secrets.py

@@ -0,0 +1,8 @@
+from chaoslib.types import Activity, Configuration, Run, Secrets
+
+
+def after_activity_control(context: Activity, state: Run,
+                           configuration: Configuration = None,
+                           secrets: Secrets = None, **kwargs):
+    if context["name"] == "generate-token":
+        secrets["mytokens"]["my_token"] = state["output"]

tests/fixtures/experiments.py

@@ -13,7 +13,9 @@
     PythonModuleProbeWithProcessStatusTolerance, \
     PythonModuleProbeWithProcessFailedStatusTolerance, \
     PythonModuleProbeWithProcesStdoutTolerance, \
-    PythonModuleProbeWithHTTPStatusToleranceDeviation, FailProbe
+    PythonModuleProbeWithHTTPStatusToleranceDeviation, FailProbe, \
+    GenerateSecretTokenProbe, ReadSecretTokenProbe, \
+    ReadSecretTokenFromSecretsProbe
 
 Secrets = {}
 
@@ -308,6 +310,44 @@
     }
 ]
 
+ExperimentWithControlsThatUpdatedConfiguration = deepcopy(ExperimentNoControls)
+ExperimentWithControlsThatUpdatedConfiguration["configuration"] = {
+    "my_token": "UNSET"
+}
+ExperimentWithControlsThatUpdatedConfiguration["method"] = [
+    deepcopy(GenerateSecretTokenProbe),
+    deepcopy(ReadSecretTokenProbe)
+]
+ExperimentWithControlsThatUpdatedConfiguration["controls"] = [
+    {
+        "name": "dummy",
+        "provider": {
+            "type": "python",
+            "module": "fixtures.controls.dummy_changed_configuration"
+        }
+    }
+]
+
+ExperimentWithControlsThatUpdatedSecrets = deepcopy(ExperimentNoControls)
+ExperimentWithControlsThatUpdatedSecrets["secrets"] = {
+    "mytokens": {
+        "my_token": "UNSET"
+    }
+}
+ExperimentWithControlsThatUpdatedSecrets["method"] = [
+    deepcopy(GenerateSecretTokenProbe),
+    deepcopy(ReadSecretTokenFromSecretsProbe)
+]
+ExperimentWithControlsThatUpdatedSecrets["controls"] = [
+    {
+        "name": "dummy",
+        "provider": {
+            "type": "python",
+            "module": "fixtures.controls.dummy_changed_secrets"
+        }
+    }
+]
+
 ExperimentWithArgumentsControls = deepcopy(ExperimentNoControls)
 ExperimentWithArgumentsControls["controls"] = [
     {

tests/fixtures/probes.py

@@ -384,3 +384,43 @@ def must_be_in_range(a: int, b: int, value: Any = None) -> bool:
         "func": "force_failed_activity"
     }
 }
+
+
+GenerateSecretTokenProbe = {
+    "type": "probe",
+    "name": "generate-token",
+    "provider": {
+        "type": "python",
+        "module": "secrets",
+        "func": "token_hex"
+    }
+}
+
+
+ReadSecretTokenProbe = {
+    "type": "action",
+    "name": "use-token",
+    "provider": {
+        "type": "python",
+        "module": "pprint",
+        "func": "pformat",
+        "arguments": {
+            "object": "${my_token}"
+        }
+    }
+}
+
+
+ReadSecretTokenFromSecretsProbe = {
+    "type": "action",
+    "name": "use-token",
+    "provider": {
+        "type": "python",
+        "module": "pprint",
+        "func": "pformat",
+        "secrets": ["mytokens"],
+        "arguments": {
+            "object": "${my_token}"
+        }
+    }
+}

tests/test_control.py

@@ -554,3 +554,19 @@ def test_controls_on_loaded_experiment():
             assert experiment["title"] == "BOOM I changed it"
         finally:
             cleanup_global_controls()
+
+
+def test_control_can_update_configuration():
+    exp = deepcopy(experiments.ExperimentWithControlsThatUpdatedConfiguration)
+    with controls("experiment", exp, context=exp):
+        state = run_experiment(exp)
+
+    assert state["run"][0]["output"] != "UNSET"
+
+
+def test_control_can_update_secrets():
+    exp = deepcopy(experiments.ExperimentWithControlsThatUpdatedSecrets)
+    with controls("experiment", exp, context=exp):
+        state = run_experiment(exp)
+
+    assert state["run"][0]["output"] != "UNSET"