Move to pylama

Closes #205

Signed-off-by: Sylvain Hellegouarch <sh@defuze.org>

Author: Lawouach

.github/workflows/build.yaml

@@ -20,7 +20,7 @@ jobs:
         pip install -r requirements.txt -r requirements-dev.txt
     - name: Checking the code syntax
       run: |
-        pycodestyle --first chaoslib
+        pylama chaoslib
     - name: Run tests
       run: |
         pip install -e .

CHANGELOG.md

@@ -7,8 +7,10 @@
 ### Changed
 
 - Moved from setup.py to declarative setup.cfg [#204][204]
+- Moved to pylama from pycodestyle [#205][205]
 
 [204]: https://github.com/chaostoolkit/chaostoolkit-lib/issues/204
+[205]: https://github.com/chaostoolkit/chaostoolkit-lib/issues/205
 
 ## [1.17.0][] - 2021-02-15
 

chaoslib/activity.py

@@ -23,7 +23,7 @@
            "run_activities"]
 
 
-def ensure_activity_is_valid(activity: Activity):
+def ensure_activity_is_valid(activity: Activity):  # noqa: C901
     """
     Goes through the activity and checks certain of its properties and raise
     :exc:`InvalidActivity` whenever one does not respect the expectations.

chaoslib/caching.py

@@ -53,7 +53,7 @@ def wrapped(experiment: Experiment, settings: Settings = None,
                 experiment_vars: Dict[str, Any] = None,
                 strategy: Strategy = Strategy.DEFAULT,
                 schedule: Schedule = None,
-                event_handlers: List['RunEventHandler'] = None):
+                event_handlers: List['RunEventHandler'] = None):  #noqa: E0602
         try:
             if experiment:
                 cache_activities(experiment)

chaoslib/control/__init__.py

@@ -282,7 +282,7 @@ def reset_global_controls():
     global_controls.clear()
 
 
-def get_context_controls(level: str, experiment: Experiment = None,
+def get_context_controls(level: str, experiment: Experiment = None,  #noqa: C901
                          context: Union[Activity, Experiment] = None) \
                          -> List[Control]:
     """

chaoslib/discovery/discover.py

@@ -82,7 +82,7 @@ def discover_probes(extension_mod_name: str) -> DiscoveredActivities:
     return discover_activities(extension_mod_name, "probe")
 
 
-def discover_activities(extension_mod_name: str,
+def discover_activities(extension_mod_name: str,  #noqa: C901
                         activity_type: str) -> DiscoveredActivities:
     """
     Discover exported activities from the given extension module name.
@@ -141,7 +141,7 @@ def discover_activities(extension_mod_name: str,
     return activities
 
 
-def portable_type_name(python_type: Any) -> str:
+def portable_type_name(python_type: Any) -> str:  # noqa: C901
     """
     Return a fairly portable name for a Python type. The idea is to make it
     easy for consumer to read without caring for actual Python types
@@ -185,7 +185,7 @@ def portable_type_name(python_type: Any) -> str:
     return "object"
 
 
-def portable_type_name_to_python_type(name: str) -> Any:
+def portable_type_name_to_python_type(name: str) -> Any:  # noqa: C901
     """
     Return the Python type associated to the given portable name.
     """

chaoslib/hypothesis.py

@@ -278,7 +278,7 @@ def _(tolerance: list, value: Any, configuration: Configuration = None,
 
 
 @within_tolerance.register(dict)
-def _(tolerance: dict, value: Any, configuration: Configuration = None,
+def _(tolerance: dict, value: Any, configuration: Configuration = None,  #noqa: C901
       secrets: Secrets = None) -> bool:
     tolerance_type = tolerance.get("type")
 

chaoslib/notification.py

@@ -43,7 +43,7 @@ class ValidateFlowEvent(FlowEvent):
     ValidateCompleted = "validate-completed"
 
 
-def notify(settings: Settings, event: FlowEvent, payload: Any = None,
+def notify(settings: Settings, event: FlowEvent, payload: Any = None,  #noqa: C901
            error: Any = None):
     """
     Go through all the notification channels declared in the settings and

chaoslib/provider/python.py

@@ -60,7 +60,7 @@ def run_python_activity(activity: Activity, configuration: Configuration,
                     sys.exc_info()[2])
 
 
-def validate_python_activity(activity: Activity):
+def validate_python_activity(activity: Activity):  # noqa: C901
     """
     Validate a Python activity.
 

chaoslib/secret.py

@@ -144,7 +144,7 @@ def load_secrets_from_env(secrets_info: Dict[str, Dict[str, str]],
     return secrets
 
 
-def load_secrets_from_vault(secrets_info: Dict[str, Dict[str, str]],
+def load_secrets_from_vault(secrets_info: Dict[str, Dict[str, str]],  # noqa: C901
                             configuration: Configuration = None,
                             extra_vars: Dict[str, Any] = None) -> Secrets:
     """