Internal: Add void return type to preUpdate method in ResourceNodeListener and remove unused return statement

AngelFQC · AngelFQC · commit 8ec6633dd9d3 · 2025-10-31T11:37:50.000-05:00
diff --git a/src/CoreBundle/Entity/Listener/ResourceNodeListener.php b/src/CoreBundle/Entity/Listener/ResourceNodeListener.php
@@ -35,7 +35,7 @@ public function __construct(
      * When updating a Resource.
      * $resourceNode->getContent() was set in the BaseResourceFileAction (when calling the api).
      */
-    public function preUpdate(ResourceNode $resourceNode, PreUpdateEventArgs $event)
+    public function preUpdate(ResourceNode $resourceNode, PreUpdateEventArgs $event): void
     {
         if ($resourceNode->hasEditableTextContent()) {
             $resourceFile = $resourceNode->getResourceFiles()->first();
@@ -48,8 +48,6 @@ public function preUpdate(ResourceNode $resourceNode, PreUpdateEventArgs $event)
                 }
             }
         }
-
-        return true;
     }
 
     /*public function postUpdate(ResourceNode $resourceNode, LifecycleEventArgs $event): void

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function __construct(`
`35`	`35`	`* When updating a Resource.`
`36`	`36`	`* $resourceNode->getContent() was set in the BaseResourceFileAction (when calling the api).`
`37`	`37`	`*/`
`38`		`- public function preUpdate(ResourceNode $resourceNode, PreUpdateEventArgs $event)`
	`38`	`+ public function preUpdate(ResourceNode $resourceNode, PreUpdateEventArgs $event): void`
`39`	`39`	`{`
`40`	`40`	`if ($resourceNode->hasEditableTextContent()) {`
`41`	`41`	`$resourceFile = $resourceNode->getResourceFiles()->first();`
`@@ -48,8 +48,6 @@ public function preUpdate(ResourceNode $resourceNode, PreUpdateEventArgs $event)`
`48`	`48`	`}`
`49`	`49`	`}`
`50`	`50`	`}`
`51`		`-`
`52`		`- return true;`
`53`	`51`	`}`
`54`	`52`
`55`	`53`	`/*public function postUpdate(ResourceNode $resourceNode, LifecycleEventArgs $event): void`