refactor-v3 Fix tests

Author: cham11ng

.eslintrc

@@ -22,7 +22,7 @@
     "prettier/prettier": 2,
     "no-error-on-unmatched-pattern": "off",
     "@typescript-eslint/no-explicit-any": "off", // TODO: Remove this.
-    "no-return-await": "warn", 
+    "no-return-await": "off", 
     "no-shadow": "off",
     "@typescript-eslint/no-shadow": ["error"]
   }

package.json

@@ -22,7 +22,7 @@
     "build": "run-s clean lint:fix transpile",
     "send:mail": "ts-node scripts/mail-test",
     "load:fake": "NODE_ENV=test ts-node scripts/fake-loader",
-    "test": "NODE_ENV=test yarn migrate && NODE_ENV=test jest --forceExit --detectOpenHandles --maxWorkers=1",
+    "test": "NODE_ENV=test yarn migrate && NODE_ENV=test jest --forceExit --detectOpenHandles --maxWorkers=1 --verbose",
     "seed": "knex seed:run --knexfile=knexfile.ts --verbose",
     "migrate": "knex migrate:latest --knexfile=knexfile.ts --verbose",
     "rollback": "knex migrate:rollback --knexfile=knexfile.ts --verbose",

test/api/auth.spec.ts

@@ -3,28 +3,21 @@ import request from 'supertest';
 import { StatusCodes } from 'http-status-codes';
 
 import app from '../../src/app';
-import { clearDb, getRandomElement } from '../helper';
-import * as userService from '../../src/services/userService';
+import { init, getRandomElement, TEST_PASSWORD, TEST_EMAIL } from '../helper';
 
 describe('Auth Workflow', () => {
-  let authorization: string;
-  let accessToken: string;
+  const email = TEST_EMAIL;
+  const password = TEST_PASSWORD;
 
-  const user = {
-    name: faker.name.findName(),
-    email: faker.internet.email(),
-    password: faker.internet.password()
-  };
-  const { email, password } = user;
+  let accessToken: string;
+  let authorization: string;
 
   beforeAll(async () => {
-    await clearDb();
-
-    await userService.insert(user);
+    await init();
 
     const response = await request(app)
       .post('/login')
-      .send({ email, password });
+      .send({ email, password: TEST_PASSWORD });
 
     authorization = `Bearer ${response.body.data.refreshToken}`;
   });

test/api/user.spec.ts

@@ -3,27 +3,21 @@ import request from 'supertest';
 import { StatusCodes } from 'http-status-codes';
 
 import app from '../../src/app';
-import Role from '../../src/resources/enums/Role';
-import { clearDb, getRandomElement } from '../helper';
-import * as userService from '../../src/services/userService';
+import { getRandomElement, init, TEST_EMAIL, TEST_PASSWORD } from '../helper';
 
 describe('GET /users API test', () => {
+  const email = TEST_EMAIL;
+  const password = TEST_PASSWORD;
+
   let authorization: string;
-  const user = {
-    name: faker.name.findName(),
-    email: 'first-user@starter.com',
-    password: faker.internet.password()
-  };
-  const { email, password } = user;
 
   beforeAll(async () => {
-    await clearDb();
-
-    await userService.insert(user);
+    await init();
 
     const response = await request(app)
       .post('/login')
       .send({ email, password });
+
     authorization = `Bearer ${response.body.data.accessToken}`;
   });
 
@@ -56,19 +50,17 @@ describe('GET /users API test', () => {
 
 describe('POST /users API test', () => {
   let authorization: string;
-  const user = {
-    roleId: Role.NORMAL_USER,
-    name: faker.name.findName(),
-    email: 'login-user@starter.com',
-    password: faker.internet.password()
-  };
-  const { email, password } = user;
+
+  const email = TEST_EMAIL;
+  const password = TEST_PASSWORD;
 
   beforeAll(async () => {
-    await userService.insert(user);
+    await init();
+
     const response = await request(app)
       .post('/login')
       .send({ email, password });
+
     authorization = `Bearer ${response.body.data.accessToken}`;
   });
 

test/helper.ts

@@ -1,17 +1,45 @@
 import faker from 'faker';
 
 import knex from '../src/config/knex';
+import UserDetail from '../src/domain/entities/UserDetail';
 import Table from '../src/resources/enums/Table';
 
+import * as userService from '../src/services/userService';
+
 const tables = [Table.USER_SESSIONS, Table.USERS];
 
+export const TEST_EMAIL = faker.internet.email();
+export const TEST_PASSWORD = faker.internet.password();
+let userData;
+
+/**
+ * Create user.
+ *
+ * @returns Promise
+ */
+async function createUser(): Promise<UserDetail> {
+  return await userService.insert({
+    email: TEST_EMAIL,
+    password: TEST_PASSWORD,
+    name: faker.name.findName()
+  });
+}
+
 /**
  * Delete all table's data.
  */
-export async function clearDb(): Promise<void> {
+export async function init(): Promise<UserDetail> {
+  if (userData) {
+    return userData;
+  }
+
   for (const table of tables) {
     await knex(table).del();
   }
+
+  userData = await createUser();
+
+  return userData;
 }
 
 /**