Since BigInt is represented as Object valuetype, pointer comparison fastpath doesnt work for definite object strict equality

Meghana Gupta · Meghana Gupta · commit 1170fa356de2 · 2018-11-26T12:21:37.000-08:00
diff --git a/lib/Backend/Lower.cpp b/lib/Backend/Lower.cpp
@@ -23580,13 +23580,13 @@ bool Lowerer::GenerateFastBrOrCmEqDefinite(IR::Instr * instr, IR::JnHelperMethod
         instr->InsertBefore(branch);
         *pNeedHelper = false;
     }
-    else if (definiteSrc->GetValueType().IsObject())
+    else if (definiteSrc->GetValueType().IsObject() && !CONFIG_FLAG(ESBigInt))
     {
         InsertCompareBranch(src1, src2, Js::OpCode::BrEq_A, labelBranchSuccess, instr);
-        m_lowererMD.GenerateObjectTest(likelySrc->AsRegOpnd(), instr, labelBranchFailure);
 
         if (!likelySrc->GetValueType().IsDefinite())
         {
+            m_lowererMD.GenerateObjectTest(likelySrc->AsRegOpnd(), instr, labelBranchFailure);
             IR::RegOpnd * likelyTypeReg = IR::RegOpnd::New(TyMachReg, this->m_func);
             IR::IndirOpnd * likelyType = IR::IndirOpnd::New(likelySrc->AsRegOpnd(), Js::RecyclableObject::GetOffsetOfType(), TyMachReg, this->m_func);
             Lowerer::InsertMove(likelyTypeReg, likelyType, instr);

Original file line number	Diff line number	Diff line change
`@@ -23580,13 +23580,13 @@ bool Lowerer::GenerateFastBrOrCmEqDefinite(IR::Instr * instr, IR::JnHelperMethod`
`23580`	`23580`	`instr->InsertBefore(branch);`
`23581`	`23581`	`*pNeedHelper = false;`
`23582`	`23582`	`}`
`23583`		`- else if (definiteSrc->GetValueType().IsObject())`
	`23583`	`+ else if (definiteSrc->GetValueType().IsObject() && !CONFIG_FLAG(ESBigInt))`
`23584`	`23584`	`{`
`23585`	`23585`	`InsertCompareBranch(src1, src2, Js::OpCode::BrEq_A, labelBranchSuccess, instr);`
`23586`		`- m_lowererMD.GenerateObjectTest(likelySrc->AsRegOpnd(), instr, labelBranchFailure);`
`23587`	`23586`
`23588`	`23587`	`if (!likelySrc->GetValueType().IsDefinite())`
`23589`	`23588`	`{`
	`23589`	`+ m_lowererMD.GenerateObjectTest(likelySrc->AsRegOpnd(), instr, labelBranchFailure);`
`23590`	`23590`	`IR::RegOpnd * likelyTypeReg = IR::RegOpnd::New(TyMachReg, this->m_func);`
`23591`	`23591`	`IR::IndirOpnd * likelyType = IR::IndirOpnd::New(likelySrc->AsRegOpnd(), Js::RecyclableObject::GetOffsetOfType(), TyMachReg, this->m_func);`
`23592`	`23592`	`Lowerer::InsertMove(likelyTypeReg, likelyType, instr);`