Skip to content

CFE-4605: Fixed getgroups test for AIX, solaris and suse 15 #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsewi merged 1 commit into from
Dec 5, 2025
Merged

CFE-4605: Fixed getgroups test for AIX, solaris and suse 15 #5950

larsewi merged 1 commit into from
Dec 5, 2025
+24 −23

Conversation

@victormlg
Copy link
Contributor

@victormlg victormlg commented Nov 18, 2025

No description provided.

@larsewi
Copy link
Contributor

larsewi commented Nov 18, 2025

Build Status

@larsewi
Copy link
Contributor

larsewi commented Nov 18, 2025 •
edited
Loading

Solaris

Stack Trace

2025-11-18T14:42:19+0100     info: filestat bailing on link "/perl5/5.12/bin/perl" (original "/bin/perl") because it could not be read
2025-11-18T14:42:19+0100     info: filestat bailing on link "/perl5/5.12/bin/perl" (original "/bin/perl") because it could not be read
2025-11-18T14:42:20+0100     info: filestat bailing on link "/perl5/5.12/bin/perl" (original "/bin/perl") because it could not be read
2025-11-18T14:42:20+0100     info: filestat bailing on link "/perl5/5.12/bin/perl" (original "/bin/perl") because it could not be read
2025-11-18T14:42:21+0100     info: filestat bailing on link "/perl5/5.12/bin/perl" (original "/bin/perl") because it could not be read
2025-11-18T14:42:22+0100     info: Created directory "/export/home/jenkins/workspace/testing-pr/label/PACKAGES_sparc64_solaris_11/cfengine-3.27.0a.18f05d614/tests/acceptance/workdir/__01_vars_02_functions_getgroups_cf/tmp/TESTDIR.cfengine/.", mode 0700
R: /export/home/jenkins/workspace/testing-pr/label/PACKAGES_sparc64_solaris_11/cfengine-3.27.0a.18f05d614/tests/acceptance/./01_vars/02_functions/getgroups.cf FAIL

AIX

Stack Trace

2025-11-18T09:13:19CST     info: Created directory "/home/jenkins/workspace/testing-pr/label/PACKAGES_ppc64_aix_71/cfengine-3.27.0a.18f05d614/tests/acceptance/workdir/__01_vars_02_functions_getgroups_cf/tmp/TESTDIR.cfengine/.", mode 0700
R: /home/jenkins/workspace/testing-pr/label/PACKAGES_ppc64_aix_71/cfengine-3.27.0a.18f05d614/tests/acceptance/./01_vars/02_functions/getgroups.cf FAIL

@victormlg victormlg requested a review from larsewi November 24, 2025 15:18
@larsewi
Copy link
Contributor

larsewi commented Nov 25, 2025

Build Status

@larsewi
Copy link
Contributor

larsewi commented Nov 26, 2025

There was some conflicts. Can you squash the merge commit?

craigcomstock
craigcomstock approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't read well for me due to the concat(nth(splitstring expressions with seemingly random integers.

You could improve it by adding a comment near each type of var you create explaining what it should contain and maybe an example.

tests/acceptance/01_vars/02_functions/getgroups.cf Outdated
nth(splitstring("$(this)", ":", 2), 0), "@(group_entries)"
);
# slice out the 3 first entries: root, bin, daemon
# filter out root, bin, daemon
Copy link
Contributor

@craigcomstock craigcomstock Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of filtering out... why don't you create the actual result dynamically by some shell scripting and compare that to the getgroups() output?

@victormlg victormlg changed the title CFE-4605: Fixed getgroups test for AIX and solaris CFE-4605: Fixed getgroups test for AIX, solaris and suse 15 Dec 4, 2025
@victormlg
Fixed getgroups test for AIX and solaris
8e51fb6 
Ticket: CFE-4605
Changelog: Made the test for getgroups() more robust and fixed it for AIX and solaris
Signed-off-by: Victor Moene <victor.moene@northern.tech>
@victormlg victormlg requested a review from larsewi December 4, 2025 14:25
@larsewi
Copy link
Contributor

larsewi commented Dec 4, 2025 •
edited
Loading

@cf-bottom Jenkins with exotics please :)

@cf-bottom
Copy link

cf-bottom commented Dec 4, 2025

Alright, I triggered a build:

Build Status

(with exotics)

Jenkins: https://ci.cfengine.com/job/pr-pipeline/13126/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13126/

@victormlg
Copy link
Contributor Author

victormlg commented Dec 5, 2025

Alright, I triggered a build:

Build Status

(with exotics)

Jenkins: https://ci.cfengine.com/job/pr-pipeline/13126/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13126/

The error is not related

@larsewi larsewi merged commit 73cae13 into cfengine:master Dec 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

@larsewi larsewi Awaiting requested review from larsewi

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@victormlg @larsewi @cf-bottom @craigcomstock