Add more assertions in tests and refactor

Author: SOHELAHMED7

src/spec/SecurityRequirement.php

@@ -44,6 +44,7 @@ protected function performValidation()
 
     public function getSerializableData()
     {
+        parent::getSerializableData();
         return $this->_securityRequirement;
     }
 }

src/spec/SecurityRequirements.php

@@ -23,14 +23,10 @@ public function __construct(array $data)
     {
         parent::__construct($data);
 
-        $read = true;
         foreach ($data as $index => $value) {
             if (is_numeric($index)) { // read
-                $requirements = $value;
                 $this->_securityRequirements[array_keys($value)[0]] = new SecurityRequirement(array_values($value)[0]);
             } else { // write
-                $read = false;
-                $requirements = $data;
                 $this->_securityRequirements[$index] = $value;
             }
         }
@@ -55,6 +51,7 @@ protected function attributes(): array
      */
     protected function performValidation()
     {
+        // TODO
     }
 
     /**
@@ -64,6 +61,8 @@ protected function performValidation()
      */
     public function getSerializableData()
     {
+        parent::getSerializableData();
+
         $data = [];
         foreach ($this->_securityRequirements ?? [] as $name => $securityRequirement) {
             /** @var SecurityRequirement $securityRequirement */

tests/WriterTest.php

@@ -255,6 +255,7 @@ public function testSecurityAtPathOperationLevel()
         );
     }
 
+    // TODO
 //    public function testSecurityAtGlobalLevel()
 //    {
 //        $openapi = $this->createOpenAPI([

tests/spec/OperationTest.php

@@ -79,6 +79,7 @@ public function testRead()
 
         $this->assertInstanceOf(\cebe\openapi\spec\Responses::class, $operation->responses);
 
+        $this->assertCount(1, $operation->security->getRequirements());
         $this->assertInstanceOf(\cebe\openapi\spec\SecurityRequirements::class, $operation->security);
         $this->assertInstanceOf(\cebe\openapi\spec\SecurityRequirement::class, $operation->security->getRequirement('petstore_auth'));
         $this->assertCount(2, $operation->security->getRequirement('petstore_auth')->getSerializableData());