add tests

Author: Carmine DiMascio

README.md

@@ -32,43 +32,45 @@ Maven
 
 ## Usage
 
-Import
+Import error methods
 
 ```java
 import static io.github.cdimascio.japierrors.ApiError.badRequest;
+// ...
 ```
 
-Throw
+Throw any HTTP error and optionally pass an exception or custom message.
 
 ```java
 throw notFound();
 throw badRequest("id required.");
 throw internalServerError(exception);
+// ...
 ```
 
 Assign
 
 ```shell
-AbstractApiError error = unauthorized();
+ApiError error = unauthorized();
 ```
 
 See [examples](#examples) with Spring MVC
 
 ## Configure
 
-japi-errors supports two error formats "out of the box". They are enabled as follows:
+**japi-errors** supports two error formats "out of the box". They are enabled as follows:
 
 ```
 ApiError.creator(ApiErrorCreators.BASIC); // The default
 ApiError.creator(ApiErrorCreators.WCP);
 ```
 
-### Basic
+### Basic (default)
 
 ```json
 {
   "code": 400,
-  "error": "'id' required."
+  "error": "id required."
 }
 ```
 
@@ -79,7 +81,7 @@ ApiError.creator(ApiErrorCreators.WCP);
   "trace": "1f96a430-dfd8-11e8-9f32-f2801f1b9fd1",
   "errors": [{
     "code": "bad_request",
-    "message": "'id' required."
+    "message": "id required."
   }]
 }
 ```
@@ -109,6 +111,7 @@ public class MyApiErrorCreator implements IApiErrorCreator {
 
 ```java
 // Create a custom api error object
+// Add Json ignore properties (see source code link above)
 public class MyApiError extends ApiError {
   @JsonProperty
   private String message;
@@ -122,7 +125,7 @@ public class MyApiError extends ApiError {
   }
 
   public String getMessage() {
-    return message
+    return message;
   }
 }
 ```

japi-errors-1.1.2.pom renamed to japi-errors-1.1.3.pom

@@ -10,7 +10,7 @@
 
     <groupId>io.github.cdimascio</groupId>
     <artifactId>japi-errors</artifactId>
-    <version>1.1.2</version>
+    <version>1.1.3</version>
 
     <licenses>
         <license>

pom.xml

@@ -10,7 +10,7 @@
 
     <groupId>io.github.cdimascio</groupId>
     <artifactId>japi-errors</artifactId>
-    <version>1.1.2</version>
+    <version>1.1.3</version>
 
     <licenses>
         <license>

src/main/java/io/github/cdimascio/japierrors/wcp/ApiErrorWcp.java

@@ -16,7 +16,7 @@
         isGetterVisibility = JsonAutoDetect.Visibility.NONE,
         creatorVisibility = JsonAutoDetect.Visibility.NONE
 )
-@JsonIgnoreProperties
+@JsonIgnoreProperties(ignoreUnknown = true)
 public class ApiErrorWcp extends ApiError {
     @JsonProperty
     private String trace;

src/test/java/UsageSpec.java

@@ -1,7 +1,6 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import com.mashape.unirest.http.HttpResponse;
 import com.mashape.unirest.http.Unirest;
 import com.mashape.unirest.http.exceptions.UnirestException;
 import io.github.cdimascio.japierrors.ApiError;
@@ -25,7 +24,7 @@ public static void beforeAll() {
     }
 
     @Test
-    public void autoConvert() {
+    public void autoConvertToType() {
         ApiErrorBasic notFound = ApiError.unauthorized();
         assertEquals(401, notFound.getCode());
     }
@@ -43,20 +42,47 @@ public void unirestAutoConvert() {
             ApiErrorBasic error = Unirest.get("http://mockbin.org/status/404/not_found").asObject(ApiErrorBasic.class).getBody();
             assertEquals(404, error.getCode());
         } catch (UnirestException e) {
+            fail("exception unexpected");
+        }
+    }
+
+    @Test
+    public void serializeToJson() {
+        try {
+            String s = m.writeValueAsString(ApiError.badRequest());
+            System.out.println(s);
+            JsonNode json = m.readTree(s);
+            assertNull(json.get("cause"));
+            assertNull(json.get("message"));
+            assertEquals(400, json.get("code").asInt());
+            assertEquals("bad request", json.get("error").asText());
+        } catch (IOException e) {
             e.printStackTrace();
             fail("unexpected exception");
         }
     }
 
     @Test
-    public void unirestJson() {
+    public void deserializeToApiError() {
+        JsonNode json = m.createObjectNode()
+                .put("code", 400)
+                .put("error", "bad request")
+                .put("extra", "junk");
+
+        ApiErrorBasic error = m.convertValue(json, ApiErrorBasic.class);
+
+        assertEquals(400, error.getCode());
+        assertEquals("bad request", error.getError());
+    }
+
+    @Test
+    public void httpErrorToApiError() {
         try {
-            HttpResponse<JsonNode> res = Unirest.get("http://mockbin.org/status/404/not_found").asObject(JsonNode.class);
-            assertEquals(404, res.getStatus());
-            JsonNode body = res.getBody();
-            System.out.println(body);
-            assertNull(body.get("cause"));
+            ApiErrorBasic error = Unirest
+                    .get("http://mockbin.org/status/404/not_found")
+                    .asObject(ApiErrorBasic.class).getBody();
 
+            assertEquals(404, error.getCode());
         } catch (UnirestException e) {
             e.printStackTrace();
             fail("unexpected exception");