Skip to content

Commit a2b865b

Browse files
authored
Merge pull request #1587 from ccnmtl/fix-frame-tabs
Fix label behavior for frame options.
2 parents e053c4b + 6975e3d commit a2b865b

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

media/src/objects/Curve.svelte

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
Z.evaluate({ t, a: aVal }),
7878
),
7979
);
80-
$inspect(xyz);
80+
// $inspect(xyz);
8181
8282
$effect(() => {
8383
// console.log('effex in framez');
@@ -279,6 +279,8 @@
279279
osculatingCircle: false,
280280
});
281281
282+
// $inspect(vizOptions);
283+
282284
$effect(() => {
283285
frame.visible = vizOptions.frame;
284286
arrows.r.visible = vizOptions.pos;
@@ -430,7 +432,7 @@
430432
431433
// Runs the update if math expression "params" has a dependence on 'a'
432434
let isDynamic = $derived(dependsOn(params, 'a'));
433-
$inspect(isDynamic);
435+
// $inspect(isDynamic);
434436
435437
// Start animating if animation changes (e.g. animating scene published)
436438
// Two ifs because one reacts only to animation changing and the other
@@ -742,37 +744,38 @@
742744
743745
<span class="box-1">Frame</span>
744746
<span class="box box-2" id="frameSwitches">
745-
<label class="switch" for="frameVisible">
747+
<label class="switch">
746748
<input
747749
type="checkbox"
748-
name="frameVisible"
749-
id="frameVisible"
750+
name="frameVis"
751+
id="frameVis"
750752
bind:checked={vizOptions.frame}
751753
/>
752754
<span class="slider round"></span>
753755
</label>
754756
{#if vizOptions.frame}
755-
<label for="framPos"
757+
<label
756758
><M size={'sm'} s="\\mathbf r" />
757759
<input
758760
type="checkbox"
759761
name="framePos"
762+
id="framePos"
760763
bind:checked={vizOptions.pos}
761764
/>
762765
</label>
763-
<label for="framevel">
766+
<label>
764767
<M size={'sm'} s={"\\mathbf r'"} />
765768
<input
766769
type="checkbox"
767-
name="framevel"
770+
name="frameVel"
768771
bind:checked={vizOptions.vel}
769772
/>
770773
</label>
771-
<label for="frameacc"
774+
<label
772775
><M size="sm" s={"\\mathbf r''"} />
773776
<input
774777
type="checkbox"
775-
name="frameacc"
778+
name="frameAcc"
776779
bind:checked={vizOptions.acc}
777780
/>
778781
</label>

0 commit comments

Comments
 (0)