Skip to content

feat: fix CvDropdown overflow flashing when expanding #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: fix CvDropdown overflow flashing when expanding #1795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d068af6
feat: fix CvDropdown overflow flashing when expanding
Marghen Nov 14, 2025
efd8a76
fix: fix linting errors
Marghen Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/components/CvDropdown/CvDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@
`${carbonPrefix}--label`,
{ [`${carbonPrefix}--label--disabled`]: disabled },
]"
>{{ label }}</label
>
{{ label }}
</label>

<div
ref="listBox"
Expand Down Expand Up @@ -110,7 +111,10 @@
ref="dropList"
:aria-hidden="!open ? 'true' : 'false'"
:aria-labelledby="`${uid}-label`"
:class="`${carbonPrefix}--list-box__menu`"
:class="[
`${carbonPrefix}--list-box__menu`,
{ 'cv-dropdown__menu--transition-done': transitionDone },
]"
role="menu"
tabindex="-1"
>
Expand Down Expand Up @@ -268,6 +272,7 @@ provide('dropdown-caption', dataCaption);
const itemsList = ref([]);
provide('dropdown-items', itemsList);
const open = ref(false);
const transitionDone = ref(false);
const data = reactive({
isHelper: false,
isInvalid: undefined,
Expand Down Expand Up @@ -301,6 +306,15 @@ watch(dataValue, () => {
});
watch(open, () => {
focusItem.value = '';
if (open.value) {
// Wait for the transition to complete before allowing overflow
transitionDone.value = false;
setTimeout(() => {
transitionDone.value = true;
}, 200); // Increase delay to ensure animation completes
} else {
transitionDone.value = false;
}
});
const ariaLabeledBy = computed(() => {
if (props.label) {
Expand Down Expand Up @@ -412,3 +426,13 @@ function onClick(ev) {
}
}
</script>

<style lang="scss">
.bx--list-box .bx--list-box__menu {
overflow-y: hidden !important;
}

.bx--list-box--expanded .bx--list-box__menu.cv-dropdown__menu--transition-done {
overflow-y: auto !important;
}
</style>