and more clippy suggestions

Author: dwrensha

capnp/src/capability_list.rs

@@ -68,10 +68,7 @@ where
     T: FromClientHook,
 {
     fn clone(&self) -> Reader<'a, T> {
-        Reader {
-            marker: self.marker,
-            reader: self.reader,
-        }
+        *self
     }
 }
 impl<'a, T> Copy for Reader<'a, T> where T: FromClientHook {}

capnp/src/list_list.rs

@@ -81,10 +81,7 @@ where
     T: crate::traits::Owned,
 {
     fn clone(&self) -> Reader<'a, T> {
-        Reader {
-            marker: self.marker,
-            reader: self.reader,
-        }
+        *self
     }
 }
 

capnp/src/primitive_list.rs

@@ -112,7 +112,7 @@ impl<'a, T: PrimitiveElement> Reader<'a, T> {
         }
     }
 
-    #[cfg(all(target_endian = "little"))]
+    #[cfg(target_endian = "little")]
     /// Returns something if the slice is as expected in memory.
     pub fn as_slice(&self) -> Option<&[T]> {
         if self.reader.get_element_size() == T::element_size() {
@@ -171,7 +171,7 @@ where
         PrimitiveElement::set(&self.builder, index, value);
     }
 
-    #[cfg(all(target_endian = "little"))]
+    #[cfg(target_endian = "little")]
     pub fn as_slice(&mut self) -> Option<&mut [T]> {
         if self.builder.get_element_size() == T::element_size() {
             let bytes = self.builder.into_raw_bytes();

capnp/src/private/layout.rs

@@ -3966,7 +3966,7 @@ impl<'a> ListReader<'a> {
                 }
 
                 let byte_size = bit_size / BITS_PER_BYTE as u64;
-                let mut byte_read_head: *const u8 = read_head.get() as *const u8;
+                let mut byte_read_head: *const u8 = read_head.get();
                 byte_read_head = unsafe { byte_read_head.offset(byte_size as isize) };
                 let read_head_end = unsafe {
                     read_head
@@ -3985,7 +3985,7 @@ impl<'a> ListReader<'a> {
                     byte_read_head = unsafe { byte_read_head.offset(1_isize) };
                 }
 
-                while byte_read_head != read_head_end as *const u8 {
+                while byte_read_head != read_head_end {
                     if unsafe { *byte_read_head } != 0 {
                         return Ok(false);
                     }