fix: data subject lookup when not exposed (#185)

Co-authored-by: Bob den Os <108393871+BobdenOs@users.noreply.github.com>

Author: sjvans

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
+## Version 1.1.1 - 2025-10-27
+
+### Fixed
+
+- Data subject lookup when data subject is not exposed in the same service
+
 ## Version 1.1.0 - 2025-09-08
 
 ### Added

lib/utils.js

@@ -108,7 +108,11 @@ const _keyColumns = (keys, alias) => {
     .map(key => ({ ref: [alias, key.name] }))
 }
 
-const _alias = entity => entity.name.replace(`${entity._service.name}.`, '').replace('.', '_')
+const _alias = entity => {
+  // REVISIT: we should not rely on entity._service (but I don't want to break existing behavior right now)
+  if (!entity._service) return `${entity}`
+  return entity.name.replace(`${entity._service.name}.`, '').replace(/\./g, '_')
+}
 
 const _buildSubSelect = (model, { entity, relative, element, next }, row, previousCqn) => {
   // relative is a parent or an entity itself

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cap-js/audit-logging",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "CDS plugin providing integration to the SAP Audit Log service as well as out-of-the-box personal data-related audit logging based on annotations.",
   "repository": "cap-js/audit-logging",
   "author": "SAP SE (https://www.sap.com)",

test/personal-data/crud.test.js

@@ -2054,4 +2054,17 @@ describe('personal data audit logging in CRUD', () => {
     await POST('/crud-5/A', { text: 'foo' }, { auth: ALICE })
     expect(_logs.length).toBe(1)
   })
+
+  test('with data subject not in service', async () => {
+    await POST('/crud-6/D', { c_ID: '17609000-3860-415b-b007-1b59dae2a198', text: 'I am personal' }, { auth: ALICE })
+    expect(_logs.length).toBe(1)
+    expect(_logs[0]).toMatchObject({
+      data_subject: { role: 'C', type: 'sap.auditlog.test.personal_data.db.C' },
+      object: { type: 'CRUD_6.D', id: { ID: expect.any(String) } },
+      attributes: [{ name: 'text', new: 'I am personal' }],
+      uuid: expect.any(String),
+      user: 'alice',
+      time: expect.any(Date)
+    })
+  })
 })

test/personal-data/db/schema.cds

@@ -91,9 +91,9 @@ type dummies {
 }
 
 entity Notes : cuid {
-  note           :      String;
-  attachment     :      Association to AddressAttachment;
-  customerStatus :      Association to CustomerStatus;
+  note           : String;
+  attachment     : Association to AddressAttachment;
+  customerStatus : Association to CustomerStatus;
   dummyArray     : many dummies;
 }
 
@@ -169,6 +169,12 @@ entity C {
       text : String;
 }
 
+entity D {
+  key ID   : UUID;
+      text : String;
+      c    : Association to C;
+}
+
 annotate A with @PersonalData      : {EntitySemantics: 'DataSubjectDetails'} {
   c    @PersonalData.FieldSemantics: 'DataSubjectID';
   text @PersonalData.IsPotentiallyPersonal;
@@ -183,3 +189,8 @@ annotate C with @PersonalData      : {EntitySemantics: 'DataSubject'} {
   ID   @PersonalData.FieldSemantics: 'DataSubjectID';
   text @PersonalData.IsPotentiallyPersonal;
 }
+
+annotate D with @PersonalData      : {EntitySemantics: 'Other'} {
+  c    @PersonalData.FieldSemantics: 'DataSubjectID';
+  text @PersonalData.IsPotentiallyPersonal;
+}

test/personal-data/srv/crud-service.cds

@@ -216,3 +216,9 @@ service CRUD_5 {
   entity C as projection on db.C;
 
 }
+
+@path    : '/crud-6'
+@requires: 'admin'
+service CRUD_6 {
+  entity D as projection on db.D;
+}