fix: don't use falsy check on cache (#124)

Author: sjvans

lib/utils.js

@@ -9,7 +9,7 @@ const $visitedUp = Symbol('@cap-js/audit-logging:visitedUp')
 const $visitedDown = Symbol('@cap-js/audit-logging:visitedDown')
 
 const hasPersonalData = entity => {
-  if (!entity.own($hasPersonalData)) {
+  if (entity.own($hasPersonalData) == null) {
     if (!entity['@PersonalData.EntitySemantics']) entity.set($hasPersonalData, false)
     else {
       // default role to entity name
@@ -147,22 +147,24 @@ const _getDataSubjectIdQuery = ({ dataSubjectEntity, subs }, row, model) => {
 }
 
 const _getUps = (entity, model) => {
-  if (entity.own($parents)) return entity[$parents]
-  const ups = []
-  for (const def of Object.values(model.definitions)) {
-    if (def.kind !== 'entity' || !def.associations) continue
-    for (const element of Object.values(def.associations)) {
-      if (element.target !== entity.name || element._isBacklink || element.name === 'SiblingEntity') continue
-      ups.push(element)
+  if (entity.own($parents) == null) {
+    const ups = []
+    for (const def of Object.values(model.definitions)) {
+      if (def.kind !== 'entity' || !def.associations) continue
+      for (const element of Object.values(def.associations)) {
+        if (element.target !== entity.name || element._isBacklink || element.name === 'SiblingEntity') continue
+        ups.push(element)
+      }
     }
+    entity.set($parents, ups)
   }
-  return entity.set($parents, ups)
+  return entity.own($parents)
 }
 
 const _getDataSubjectUp = (root, model, entity, prev, next, result) => {
   for (const element of _getUps(entity, model)) {
     // cycle detection
-    if (!element.own($visitedUp)) element.set($visitedUp, new Set())
+    if (element.own($visitedUp) == null) element.set($visitedUp, new Set())
     if (element.own($visitedUp).has(root)) continue
     element.own($visitedUp).add(root)
 
@@ -192,7 +194,7 @@ const _getDataSubjectDown = (root, entity, prev, next) => {
   }
   for (const element of associations) {
     // cycle detection
-    if (!element.own($visitedDown)) element.set($visitedDown, new Set())
+    if (element.own($visitedDown) == null) element.set($visitedDown, new Set())
     if (element.own($visitedDown).has(root)) continue
     element.own($visitedDown).add(root)
 
@@ -204,12 +206,14 @@ const _getDataSubjectDown = (root, entity, prev, next) => {
 }
 
 const getDataSubject = (entity, model) => {
-  if (entity.own($dataSubject)) return entity[$dataSubject]
-  // entities with EntitySemantics 'DataSubjectDetails' or 'Other' must not necessarily
-  // be always below or always above 'DataSubject' entity in CSN tree
-  let dataSubjectInfo = _getDataSubjectUp(entity.name, model, entity)
-  if (!dataSubjectInfo) dataSubjectInfo = _getDataSubjectDown(entity.name, entity)
-  return entity.set($dataSubject, dataSubjectInfo)
+  if (entity.own($dataSubject) == null) {
+    // entities with EntitySemantics 'DataSubjectDetails' or 'Other' must not necessarily
+    // be always below or always above 'DataSubject' entity in CSN tree
+    let dataSubjectInfo = _getDataSubjectUp(entity.name, model, entity)
+    if (!dataSubjectInfo) dataSubjectInfo = _getDataSubjectDown(entity.name, entity)
+    entity.set($dataSubject, dataSubjectInfo)
+  }
+  return entity.own($dataSubject)
 }
 
 const _getDataSubjectsMap = req => {