Updates based on code review

Author: DesignByOnyx

can-ajax-test.js

@@ -285,20 +285,20 @@ if(typeof XDomainRequest === 'undefined') {
 	QUnit.test("cross domain post request should change data to form data (#90)", function (assert) {
 		var done = assert.async();
 		var headers = {},
-		    restore = makeFixture(function () {
-			    this.open = function (type, url) {};
-
-			    this.send = function () {
-				    this.readyState = 4;
-				    this.status = 204;
-				    this.responseText = '';
-				    this.onreadystatechange();
-			    };
-
-			    this.setRequestHeader = function (header, value) {
-				    headers[header] = value;
-			    };
-		    });
+			restore = makeFixture(function () {
+				this.open = function (type, url) {};
+
+				this.send = function () {
+					this.readyState = 4;
+					this.status = 204;
+					this.responseText = '';
+					this.onreadystatechange();
+				};
+
+				this.setRequestHeader = function (header, value) {
+					headers[header] = value;
+				};
+			});
 		ajax({
 			type: "POST",
 			url: "https://httpbin.org/post",
@@ -569,23 +569,71 @@ QUnit.test("It doesn't stringify FormData", function(assert) {
 	});
 });
 
+QUnit.test("abort", function (assert) {
+	var done = assert.async();
+	var restore = makeFixture(function () {
+		var aborted = false;
+		this.open = function (type, url) {};
+		this.setRequestHeader = function (header, value) {};
+		this.send = function () {};
+		this.abort = function() {
+			assert.ok(true, 'called the underlying XHR.abort');
+			done();
+		};
+	});
+
+	var request = ajax({
+		url: "/foo"
+	});
+
+	request.abort();
+});
+
+QUnit.test("abort prevents sending if beforeSend is not finished", function (assert) {
+	var done = assert.async();
+	var restore = makeFixture(function () {
+		var aborted = false;
+		this.open = function (type, url) {};
+		this.setRequestHeader = function (header, value) {};
+		this.abort = function() {
+			assert.ok(true, 'XHR abort was called');
+		};
+		this.send = function () {
+			assert.notOk(true, 'should not have been called');
+		};
+	});
+
+	var request = ajax({
+		url: "/foo",
+		beforeSend: function (xhr){
+			return new Promise(resolve => {
+				setTimeout(resolve, 1);
+			});
+		}
+	});
+
+	request.abort();
+
+	setTimeout(done, 10);
+});
+
 QUnit.test("beforeSend", function (assert) {
 	var done = assert.async();
 	var headers = {},
-	    restore = makeFixture(function () {
-		    this.open = function (type, url) {};
+		restore = makeFixture(function () {
+			this.open = function (type, url) {};
 
-		    this.send = function () {
-			    this.readyState = 4;
-			    this.status = 204;
-			    this.responseText = '';
-			    this.onreadystatechange();
-		    };
+			this.send = function () {
+				this.readyState = 4;
+				this.status = 204;
+				this.responseText = '';
+				this.onreadystatechange();
+			};
 
-		    this.setRequestHeader = function (header, value) {
-			    headers[header] = value;
-		    };
-	    });
+			this.setRequestHeader = function (header, value) {
+				headers[header] = value;
+			};
+		});
 
 	ajax({
 		type: "post",
@@ -612,116 +660,65 @@ QUnit.test("beforeSend", function (assert) {
 	});
 });
 
-QUnit.test("abort", function (assert) {
+QUnit.test("beforeSend async", function (assert) {
 	var done = assert.async();
+	var headers = {};
 	var restore = makeFixture(function () {
-		var aborted = false;
-	    this.open = function (type, url) {};
-	    this.setRequestHeader = function (header, value) {};
-	    this.send = function () {};
-	    this.abort = function() {
-	    	assert.ok(true, 'called the underlying XHR.abort');
-	    	done();
-	    };
-    });
+		this.open = function (type, url) {};
 
-	var request = ajax({
-		url: "/foo"
-	});
-
-	request.abort();
-});
+		this.send = function () {
+			this.readyState = 4;
+			this.status = 204;
+			this.responseText = '';
+			this.onreadystatechange();
+		};
 
-QUnit.test("abort prevents sending if beforeSend is not finished", function (assert) {
-	var done = assert.async();
-	var restore = makeFixture(function () {
-		var aborted = false;
-	    this.open = function (type, url) {};
-	    this.setRequestHeader = function (header, value) {};
-	    this.abort = function() {
-	    	assert.ok(true, 'XHR abort was called');
-	    };
-	    this.send = function () {
-	    	assert.notOk(true, 'should not have been called');
-	    };
-    });
+		this.setRequestHeader = function (header, value) {
+			headers[header] = value;
+		};
+	});
 
-	var request = ajax({
+	ajax({
 		url: "/foo",
 		beforeSend: function (xhr){
 			return new Promise(resolve => {
-				setTimeout(resolve, 1);
+				setTimeout(() => {
+					xhr.setRequestHeader("Authorization", "Bearer 123");
+					resolve();
+				}, 1);
 			});
 		}
-	});
-
-	request.abort();
-
-	setTimeout(done, 10);
+	}).then(function (value) {
+		assert.ok(headers.hasOwnProperty('Authorization'), "authorization header set");
+	}, function (reason) {
+		assert.notOk(reason, "request failed with reason = ", reason);
+	}).then(done);
 });
 
-QUnit.module("beforeSend async", function(hooks) {
-	var headers, restore;
-
-	hooks.beforeEach(function() {
-		headers = {};
-		restore = makeFixture(function () {
-		    this.open = function (type, url) {};
-
-		    this.send = function () {
-			    this.readyState = 4;
-			    this.status = 204;
-			    this.responseText = '';
-			    this.onreadystatechange();
-		    };
-
-		    this.setRequestHeader = function (header, value) {
-			    headers[header] = value;
-		    };
-	    });
-	});
-
-	hooks.afterEach(function() {
-		restore();
-	});
-
-	QUnit.test("waits for promise to resolve", function (assert) {
-		var done = assert.async();
-
-		ajax({
-			url: "/foo",
-			beforeSend: function (xhr){
-				return new Promise(resolve => {
-					setTimeout(() => {
-						xhr.setRequestHeader("Authorization", "Bearer 123");
-						resolve();
-					}, 1);
-				});
-			}
-		}).then(function (value) {
-			assert.ok(headers.hasOwnProperty('Authorization'), "authorization header set");
-		}, function (reason) {
-			assert.notOk(reason, "request failed with reason = ", reason);
-		}).then(done);
+QUnit.test("beforeSend rejects the ajax promise on failure", function (assert) {
+	var done = assert.async();
+	var error = new Error();
+	var restore = makeFixture(function () {
+		this.open = function (type, url) {};
+		this.send = function () {
+			assert.notOk(true, 'Should not be called');
+		};
+		this.setRequestHeader = function (header, value) {};
 	});
 
-	QUnit.test("rejects the ajax promise on failure", function (assert) {
-		var done = assert.async();
-		var error = new Error();
-
-		ajax({
-			url: "/foo",
-			beforeSend: function (xhr){
-				return new Promise((resolve, reject) => {
-					setTimeout(() => {
-						reject(error);
-					}, 1);
-				});
-			}
-		}).then(function (value) {
-			assert.notOk(true, "request should have rejected");
-		}, function (reason) {
-			assert.ok(true, "request rejected");
-		}).then(done);
-	});
+	ajax({
+		url: "/foo",
+		beforeSend: function (xhr){
+			return new Promise((resolve, reject) => {
+				setTimeout(() => {
+					reject(error);
+				}, 1);
+			});
+		}
+	}).then(function (value) {
+		assert.notOk(true, "request should have rejected");
+	}, function (reason) {
+		assert.ok(true, "request rejected");
+		assert.equal(reason, error, "error is what we expect");
+	}).then(done);
 });

can-ajax.js

@@ -260,7 +260,7 @@ function ajax(o) {
 
 	if(o.beforeSend){
 		const result = o.beforeSend.call( o, xhr, o );
-		if(result && typeof result.then === 'function') {
+		if(canReflect.isPromise(result)) {
 			result.then(send).catch(deferred.reject);
 		} else {
 			send();