feat(mr): activity loading.

Author: cangzhang

package.json

@@ -1,7 +1,7 @@
 {
   "name": "coding-plugin",
   "description": "Coding plugin for VS Code.",
-  "version": "1.0.0",
+  "version": "0.1.0",
   "publisher": "coding",
   "license": "MIT",
   "engines": {

src/extension.ts

@@ -64,7 +64,7 @@ export async function activate(context: vscode.ExtensionContext) {
         Panel.currentPanel?.broadcast(`mr.reviewers.init`, reviewerResp.data);
       });
       codingSrv.getMRComments(mr.iid).then((commentResp) => {
-        Panel.currentPanel?.broadcast(`mr.udpate.comments`, commentResp.data);
+        Panel.currentPanel?.broadcast(`mr.update.comments`, commentResp.data);
       });
     }),
   );

webviews/App.tsx

@@ -5,7 +5,7 @@ import appStore from 'webviews/store/appStore';
 import persistDataHook from 'webviews/hooks/persistDataHook';
 import Activities from 'webviews/components/Activities';
 import Reviewers from 'webviews/components/Reviewers';
-import messageTransferHook from 'webviews/hooks/messageTransferHook';
+import initDataHook from 'webviews/hooks/initDataHook';
 import EditButton from 'webviews/components/EditButton';
 // import { requestUpdateMRContent } from 'webviews/service/mrService';
 
@@ -35,7 +35,7 @@ function App() {
   const { merge_request: mergeRequest } = data || {};
 
   persistDataHook();
-  messageTransferHook();
+  initDataHook();
 
   const handleKeyDown = async (event: any) => {
     if (event.key === 'Enter') {

webviews/components/Activities.tsx

@@ -34,6 +34,10 @@ function Activities() {
     (a, b) => a[0]?.created_at - b[0]?.created_at,
   );
 
+  if (!allActivities.length) {
+    return <div>Loading...</div>;
+  }
+
   return (
     <div>
       <div>

webviews/hooks/messageTransferHook.tsx renamed to webviews/hooks/initDataHook.tsx

@@ -2,7 +2,7 @@ import { useEffect } from 'react';
 import appStore from 'webviews/store/appStore';
 import { actions } from 'webviews/store/constants';
 
-export default function messageTransferHook() {
+export default function initDataHook() {
   useEffect(() => {
     window.addEventListener('message', (ev) => {
       const { updateCurrentMR, toggleMRLoading, initMRReviewers, initMRActivities } = appStore;

webviews/store/appStore.ts

@@ -20,9 +20,6 @@ const appStore = store({
   updateMRActivities(data: IActivity[]) {
     appStore.activities = data;
   },
-  updateMRReviewers(data: IMRReviewers) {
-    appStore.reviewers = data;
-  },
   updateMRComments(data: IComment[]) {
     appStore.comments = data;
   },

webviews/store/constants.ts

@@ -5,7 +5,7 @@ export enum actions {
   MR_DISAPPROVE = `mr.disapprove`,
   MR_MERGE = `mr.merge`,
   MR_UPDATE_TITLE = `mr.update.title`,
-  MR_UPDATE_COMMENTS = `mr.udpate.comments`,
+  MR_UPDATE_COMMENTS = `mr.update.comments`,
   MR_ADD_COMMENT = `mr.add.comment`,
   MR_GET_ACTIVITIES = `mr.get.activities`,
   MR_TOGGLE_LOADING = `mr.update.toggleLoading`,