Correctly show active/passive for an active-active domain in metadata (#999)

Show active cluster(s) based on activeClustersByRegion for an active-active domain, in Domain Metadata

Author: adhityamamallan

src/views/domain-page/domain-page-metadata-clusters/__tests__/domain-page-metadata-clusters.test.tsx

@@ -4,9 +4,19 @@ import {
   mockDomainDescription,
   mockDomainDescriptionSingleCluster,
 } from '../../__fixtures__/domain-description';
+import * as isActiveClusterModule from '../../helpers/is-active-cluster';
 import DomainPageMetadataClusters from '../domain-page-metadata-clusters';
 
+jest.mock('../../helpers/is-active-cluster', () => ({
+  __esModule: true,
+  default: jest.fn().mockReturnValue(false),
+}));
+
 describe(DomainPageMetadataClusters.name, () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
   it('renders plain text for single cluster', async () => {
     render(
       <DomainPageMetadataClusters {...mockDomainDescriptionSingleCluster} />
@@ -17,6 +27,11 @@ describe(DomainPageMetadataClusters.name, () => {
   });
 
   it('renders active/passive labels and links for multiple clusters', () => {
+    jest
+      .spyOn(isActiveClusterModule, 'default')
+      .mockReturnValueOnce(true) // cluster_1 is active
+      .mockReturnValueOnce(false); // cluster_2 is passive
+
     const { container } = render(
       <DomainPageMetadataClusters {...mockDomainDescription} />
     );

src/views/domain-page/domain-page-metadata-clusters/domain-page-metadata-clusters.tsx

@@ -3,6 +3,7 @@ import React from 'react';
 import Link from '@/components/link/link';
 
 import { type DomainDescription } from '../domain-page.types';
+import isActiveCluster from '../helpers/is-active-cluster';
 
 import { styled } from './domain-page-metadata-clusters.styles';
 
@@ -17,10 +18,13 @@ export default function DomainPageMetadataClusters(
   return (
     <styled.ClusterTextContainer>
       {domainDescription.clusters.map((cluster, index) => {
-        const replicationStatusLabel =
-          cluster.clusterName === domainDescription.activeClusterName
-            ? 'active'
-            : 'passive';
+        const replicationStatusLabel = isActiveCluster(
+          domainDescription,
+          cluster.clusterName
+        )
+          ? 'active'
+          : 'passive';
+
         return (
           <React.Fragment key={cluster.clusterName}>
             <Link

src/views/domain-page/helpers/__tests__/is-active-cluster.test.ts

@@ -0,0 +1,50 @@
+import { getDomainObj } from '@/views/domains-page/__fixtures__/domains';
+import { mockActiveActiveDomain } from '@/views/shared/active-active/__fixtures__/active-active-domain';
+
+import isActiveCluster from '../is-active-cluster';
+
+jest.mock('@/views/shared/active-active/helpers/is-active-active-domain');
+
+describe(isActiveCluster.name, () => {
+  it('should return true when cluster is in activeClusters.regionToCluster for active-active domain', () => {
+    expect(isActiveCluster(mockActiveActiveDomain, 'cluster0')).toBe(true);
+    expect(isActiveCluster(mockActiveActiveDomain, 'cluster1')).toBe(true);
+  });
+
+  it('should return false when cluster is not in activeClusters.regionToCluster for active-active domain', () => {
+    const domain = mockActiveActiveDomain;
+    const cluster = 'non-existent-cluster';
+
+    const result = isActiveCluster(domain, cluster);
+
+    expect(result).toBe(false);
+  });
+
+  it('should return true when cluster matches activeClusterName for active-passive domain', () => {
+    const domain = getDomainObj({
+      id: 'test-domain-id',
+      name: 'test-domain',
+      activeClusterName: 'cluster_1',
+      activeClusters: null,
+    });
+    const cluster = 'cluster_1';
+
+    const result = isActiveCluster(domain, cluster);
+
+    expect(result).toBe(true);
+  });
+
+  it('should return false when cluster does not match activeClusterName for regular domain', () => {
+    const domain = getDomainObj({
+      id: 'test-domain-id',
+      name: 'test-domain',
+      activeClusterName: 'cluster_1',
+      activeClusters: null,
+    });
+    const cluster = 'cluster_2';
+
+    const result = isActiveCluster(domain, cluster);
+
+    expect(result).toBe(false);
+  });
+});

src/views/domain-page/helpers/is-active-cluster.ts

@@ -0,0 +1,18 @@
+import isActiveActiveDomain from '@/views/shared/active-active/helpers/is-active-active-domain';
+
+import { type DomainDescription } from '../domain-page.types';
+
+export default function isActiveCluster(
+  domain: DomainDescription,
+  cluster: string
+) {
+  if (isActiveActiveDomain(domain)) {
+    return (
+      Object.values(domain.activeClusters.regionToCluster).find(
+        (activeClusterInfo) => activeClusterInfo.activeClusterName === cluster
+      ) !== undefined
+    );
+  }
+
+  return cluster === domain.activeClusterName;
+}