revert history filters persistence changes (#1001)

Author: Assem-Uber

src/views/workflow-history/__tests__/workflow-history.test.tsx

@@ -24,7 +24,6 @@ import { completedActivityTaskEvents } from '../__fixtures__/workflow-history-ac
 import { completedDecisionTaskEvents } from '../__fixtures__/workflow-history-decision-events';
 import WorkflowHistory from '../workflow-history';
 import { WorkflowHistoryContext } from '../workflow-history-context-provider/workflow-history-context-provider';
-import { type WorkflowHistoryEventFilteringType } from '../workflow-history-filters-type/workflow-history-filters-type.types';
 
 jest.mock('@/hooks/use-page-query-params/use-page-query-params', () =>
   jest.fn(() => [{ historySelectedEventId: '1' }, jest.fn()])
@@ -299,34 +298,6 @@ describe('WorkflowHistory', () => {
     expect(await screen.findByText('Ungrouped Table')).toBeInTheDocument();
     expect(screen.getByText('Group')).toBeInTheDocument();
   });
-
-  it('should override history event types preference when query param is set', async () => {
-    const {
-      mockSetUngroupedViewUserPreference,
-      mockSetHistoryEventTypesUserPreference,
-    } = await setup({
-      pageQueryParamsValues: {
-        historyEventTypes: ['TIMER', 'SIGNAL'],
-        ungroupedHistoryViewEnabled: false,
-      },
-      historyEventTypesPreference: ['ACTIVITY', 'DECISION'],
-    });
-
-    expect(mockSetUngroupedViewUserPreference).not.toHaveBeenCalled();
-    expect(mockSetHistoryEventTypesUserPreference).not.toHaveBeenCalled();
-  });
-
-  it('should use preference when history event types query param is undefined', async () => {
-    const { mockSetHistoryEventTypesUserPreference } = await setup({
-      pageQueryParamsValues: {
-        historyEventTypes: undefined,
-        ungroupedHistoryViewEnabled: false,
-      },
-      historyEventTypesPreference: ['TIMER', 'SIGNAL'],
-    });
-
-    expect(mockSetHistoryEventTypesUserPreference).not.toHaveBeenCalled();
-  });
 });
 
 async function setup({
@@ -338,7 +309,6 @@ async function setup({
   emptyEvents,
   withResetModal,
   ungroupedViewPreference,
-  historyEventTypesPreference,
 }: {
   error?: boolean;
   summaryError?: boolean;
@@ -350,7 +320,6 @@ async function setup({
   emptyEvents?: boolean;
   withResetModal?: boolean;
   ungroupedViewPreference?: boolean;
-  historyEventTypesPreference?: Array<WorkflowHistoryEventFilteringType>;
 }) {
   const user = userEvent.setup();
 
@@ -365,8 +334,6 @@ async function setup({
   }
 
   const mockSetUngroupedViewUserPreference = jest.fn();
-  const mockSetHistoryEventTypesUserPreference = jest.fn();
-  const mockClearHistoryEventTypesUserPreference = jest.fn();
 
   type ReqResolver = (r: GetWorkflowHistoryResponse) => void;
   let requestResolver: ReqResolver = () => {};
@@ -381,11 +348,6 @@ async function setup({
         value={{
           ungroupedViewUserPreference: ungroupedViewPreference ?? null,
           setUngroupedViewUserPreference: mockSetUngroupedViewUserPreference,
-          historyEventTypesUserPreference: historyEventTypesPreference ?? null,
-          setHistoryEventTypesUserPreference:
-            mockSetHistoryEventTypesUserPreference,
-          clearHistoryEventTypesUserPreference:
-            mockClearHistoryEventTypesUserPreference,
         }}
       >
         <WorkflowHistory
@@ -490,7 +452,5 @@ async function setup({
     ...renderResult,
     mockSetQueryParams,
     mockSetUngroupedViewUserPreference,
-    mockSetHistoryEventTypesUserPreference,
-    mockClearHistoryEventTypesUserPreference,
   };
 }

src/views/workflow-history/config/workflow-history-user-preferences.config.ts

@@ -1,8 +1,5 @@
-import { isArray } from 'lodash';
 import { z } from 'zod';
 
-import { WORKFLOW_HISTORY_EVENT_FILTERING_TYPES } from '../workflow-history-filters-type/workflow-history-filters-type.constants';
-import { type WorkflowHistoryEventFilteringType } from '../workflow-history-filters-type/workflow-history-filters-type.types';
 import { type WorkflowHistoryUserPreferenceConfig } from '../workflow-history.types';
 
 const workflowHistoryUserPreferencesConfig = {
@@ -13,27 +10,6 @@ const workflowHistoryUserPreferencesConfig = {
       .refine((val) => val === 'true' || val === 'false')
       .transform((val) => val === 'true'),
   },
-  historyEventTypes: {
-    key: 'history-event-types',
-    schema: z
-      .string()
-      .transform((arg) => {
-        try {
-          return JSON.parse(arg);
-        } catch {
-          return null;
-        }
-      })
-      .refine(
-        (val) =>
-          isArray(val) &&
-          val.every(
-            (item): item is WorkflowHistoryEventFilteringType =>
-              WORKFLOW_HISTORY_EVENT_FILTERING_TYPES.find((v) => v === item) !==
-              undefined
-          )
-      ),
-  },
 } as const satisfies Record<string, WorkflowHistoryUserPreferenceConfig<any>>;
 
 export default workflowHistoryUserPreferencesConfig;

src/views/workflow-history/workflow-history-context-provider/__tests__/workflow-history-context-provider.test.tsx

@@ -18,27 +18,12 @@ const TestConsumer = () => {
           ? 'null'
           : String(context.ungroupedViewUserPreference)}
       </div>
-      <div data-testid="event-types-preference">
-        {context.historyEventTypesUserPreference === null
-          ? 'null'
-          : context.historyEventTypesUserPreference.join(',')}
-      </div>
       <button onClick={() => context.setUngroupedViewUserPreference(true)}>
         Set Ungrouped True
       </button>
       <button onClick={() => context.setUngroupedViewUserPreference(false)}>
         Set Ungrouped False
       </button>
-      <button
-        onClick={() =>
-          context.setHistoryEventTypesUserPreference(['TIMER', 'SIGNAL'])
-        }
-      >
-        Set Event Types
-      </button>
-      <button onClick={() => context.clearHistoryEventTypesUserPreference()}>
-        Clear Event Types
-      </button>
     </div>
   );
 };
@@ -58,28 +43,17 @@ describe(WorkflowHistoryContextProvider.name, () => {
     const { mockGetLocalStorageValue } = setup({
       localStorageValues: {
         [workflowHistoryUserPreferencesConfig.ungroupedViewEnabled.key]: true,
-        [workflowHistoryUserPreferencesConfig.historyEventTypes.key]: [
-          'TIMER',
-          'SIGNAL',
-        ],
       },
     });
 
     expect(mockGetLocalStorageValue).toHaveBeenCalledWith(
       workflowHistoryUserPreferencesConfig.ungroupedViewEnabled.key,
       workflowHistoryUserPreferencesConfig.ungroupedViewEnabled.schema
     );
-    expect(mockGetLocalStorageValue).toHaveBeenCalledWith(
-      workflowHistoryUserPreferencesConfig.historyEventTypes.key,
-      workflowHistoryUserPreferencesConfig.historyEventTypes.schema
-    );
 
     expect(screen.getByTestId('ungrouped-preference')).toHaveTextContent(
       'true'
     );
-    expect(screen.getByTestId('event-types-preference')).toHaveTextContent(
-      'TIMER,SIGNAL'
-    );
   });
 
   it('should initialize with null values when localStorage is empty', () => {
@@ -89,17 +63,10 @@ describe(WorkflowHistoryContextProvider.name, () => {
       workflowHistoryUserPreferencesConfig.ungroupedViewEnabled.key,
       workflowHistoryUserPreferencesConfig.ungroupedViewEnabled.schema
     );
-    expect(mockGetLocalStorageValue).toHaveBeenCalledWith(
-      workflowHistoryUserPreferencesConfig.historyEventTypes.key,
-      workflowHistoryUserPreferencesConfig.historyEventTypes.schema
-    );
 
     expect(screen.getByTestId('ungrouped-preference')).toHaveTextContent(
       'null'
     );
-    expect(screen.getByTestId('event-types-preference')).toHaveTextContent(
-      'null'
-    );
   });
 
   it('should update ungrouped view preference and localStorage', () => {
@@ -128,46 +95,6 @@ describe(WorkflowHistoryContextProvider.name, () => {
     );
   });
 
-  it('should update history event types preference and localStorage', () => {
-    const { mockSetLocalStorageValue } = setup();
-
-    const setEventTypesButton = screen.getByText('Set Event Types');
-    fireEvent.click(setEventTypesButton);
-
-    expect(mockSetLocalStorageValue).toHaveBeenCalledWith(
-      workflowHistoryUserPreferencesConfig.historyEventTypes.key,
-      JSON.stringify(['TIMER', 'SIGNAL'])
-    );
-    expect(screen.getByTestId('event-types-preference')).toHaveTextContent(
-      'TIMER,SIGNAL'
-    );
-  });
-
-  it('should clear history event types preference and localStorage', () => {
-    const { mockClearLocalStorageValue } = setup({
-      localStorageValues: {
-        [workflowHistoryUserPreferencesConfig.historyEventTypes.key]: [
-          'TIMER',
-          'SIGNAL',
-        ],
-      },
-    });
-
-    expect(screen.getByTestId('event-types-preference')).toHaveTextContent(
-      'TIMER,SIGNAL'
-    );
-
-    const clearButton = screen.getByText('Clear Event Types');
-    fireEvent.click(clearButton);
-
-    expect(mockClearLocalStorageValue).toHaveBeenCalledWith(
-      workflowHistoryUserPreferencesConfig.historyEventTypes.key
-    );
-    expect(screen.getByTestId('event-types-preference')).toHaveTextContent(
-      'null'
-    );
-  });
-
   it('should maintain state across re-renders', () => {
     const { rerender } = setup();
 

src/views/workflow-history/workflow-history-context-provider/workflow-history-context-provider.tsx

@@ -28,14 +28,6 @@ export default function WorkflowHistoryContextProvider({
     )
   );
 
-  const [historyEventTypesPreference, setHistoryEventTypesPreference] =
-    useState(() =>
-      getLocalStorageValue(
-        workflowHistoryUserPreferencesConfig.historyEventTypes.key,
-        workflowHistoryUserPreferencesConfig.historyEventTypes.schema
-      )
-    );
-
   const setUngroupedViewUserPreference = useCallback(
     (isUngroupedHistoryViewEnabled: boolean) => {
       setLocalStorageValue(
@@ -47,32 +39,11 @@ export default function WorkflowHistoryContextProvider({
     []
   );
 
-  const setHistoryEventTypesUserPreference = useCallback(
-    (historyEventTypes: Array<WorkflowHistoryEventFilteringType>) => {
-      setLocalStorageValue(
-        workflowHistoryUserPreferencesConfig.historyEventTypes.key,
-        JSON.stringify(historyEventTypes)
-      );
-      setHistoryEventTypesPreference(historyEventTypes);
-    },
-    []
-  );
-
-  const clearHistoryEventTypesUserPreference = useCallback(() => {
-    clearLocalStorageValue(
-      workflowHistoryUserPreferencesConfig.historyEventTypes.key
-    );
-    setHistoryEventTypesPreference(null);
-  }, []);
-
   return (
     <WorkflowHistoryContext.Provider
       value={{
         ungroupedViewUserPreference: ungroupedViewPreference,
         setUngroupedViewUserPreference,
-        historyEventTypesUserPreference: historyEventTypesPreference,
-        setHistoryEventTypesUserPreference,
-        clearHistoryEventTypesUserPreference,
       }}
     >
       {children}

src/views/workflow-history/workflow-history-context-provider/workflow-history-context-provider.types.ts

@@ -3,9 +3,4 @@ import { type WorkflowHistoryEventFilteringType } from '../workflow-history-filt
 export type WorkflowHistoryContextType = {
   ungroupedViewUserPreference: boolean | null;
   setUngroupedViewUserPreference: (v: boolean) => void;
-  historyEventTypesUserPreference: Array<WorkflowHistoryEventFilteringType> | null;
-  setHistoryEventTypesUserPreference: (
-    v: Array<WorkflowHistoryEventFilteringType>
-  ) => void;
-  clearHistoryEventTypesUserPreference: () => void;
 };