initialisers: use init calls on object definitions

Author: chqrlie

compiler/c2module_loader.c2

@@ -49,8 +49,7 @@ fn void create_signed(ast_context.Context* context,
     QualType qt = ast.builtins[kind];
     Expr* ie = cast<Expr*>(IntegerLiteral.createSignedConstant(context, 0, value, qt));
     u32 name2 = pool.addStr(name, true);
-    TypeRefHolder ref;
-    ref.init();
+    TypeRefHolder ref.init();
     ref.setBuiltin(kind, 0);
     VarDecl* var = VarDecl.create(context, VarDeclKind.GlobalVar, name2, 0, true, &ref, a.getIdx(), 0, ie);
     Decl* d = cast<Decl*>(var);
@@ -71,8 +70,7 @@ fn void create_unsigned(ast_context.Context* context,
     QualType qt = ast.builtins[kind];
     Expr* ie = cast<Expr*>(IntegerLiteral.createUnsignedConstant(context, 0, value, qt));
     u32 name2 = pool.addStr(name, true);
-    TypeRefHolder ref;
-    ref.init();
+    TypeRefHolder ref.init();
     ref.setBuiltin(kind, 0);
     VarDecl* var = VarDecl.create(context, VarDeclKind.GlobalVar, name2, 0, true, &ref, a.getIdx(), 0, ie);
     Decl* d = cast<Decl*>(var);
@@ -90,8 +88,7 @@ fn void add_ctype(ast_context.Context* context,
         BuiltinKind kind)
 {
     u32 type_name = pool.addStr(name, true);
-    TypeRefHolder ref;
-    ref.init();
+    TypeRefHolder ref.init();
     ref.setBuiltin(kind, 0);
     AliasTypeDecl* t = AliasTypeDecl.create(context, type_name, 0, true, a.getIdx(), &ref);
     Decl* d = t.asDecl();

compiler/compiler_libs.c2

@@ -104,8 +104,7 @@ fn void Compiler.open_lib(Compiler* c, Component* comp) {
     u32 dirname = c.auxPool.addStr(libdir, false);
 
     comp.setPath(dirname);
-    string_list.List mods;
-    mods.init(c.astPool);
+    string_list.List mods.init(c.astPool);
     bool ok = manifest.parse(c.sm, file_id, c.astPool, comp, &mods);
     if (!ok) {
         stdlib.exit(-1);
@@ -267,8 +266,7 @@ fn void Compiler.showLibs(Compiler* c, string_buffer.Buf* out, const char* dirna
                                                    name_idx,
                                                    Kind.ExternalStatic, // doesn't matter
                                                    true);
-                string_list.List mods;
-                mods.init(c.auxPool);   // need to be astPool, but here it doesn't matter
+                string_list.List mods.init(c.auxPool);   // need to be astPool, but here it doesn't matter
                 manifest.parse(c.sm, file_id, c.astPool, comp, &mods);
                 c.components.add(comp);
                 mods.free();

compiler/main.c2

@@ -653,8 +653,7 @@ fn void Context.free(Context* c) {
 public fn i32 main(i32 argc, char** argv) {
     console.init();
 
-    Context c;
-    c.init();
+    Context c.init();
     c.handle_args(argc, argv);
     c.handle_plugins();
     bool hasError = c.build_targets();

plugins/git_version_plugin.c2

@@ -87,8 +87,7 @@ fn void generate_module(void* arg) {
     u32 var_name = p.info.astPool.addStr("Describe", true);
 
     // create type
-    ast.TypeRefHolder ref;
-    ref.init();
+    ast.TypeRefHolder ref.init();
     ref.setConst();
     ref.addArray(nil);
     ref.setBuiltin(ast.BuiltinKind.Char, 0);