machinst x64: New backend unwind (#2266)

Addresses unwind for experimental x64 backend. The preliminary code enables backtrace on SystemV call convension.

Author: yurydelendik

cranelift/codegen/src/context.rs

@@ -253,6 +253,14 @@ impl Context {
         &self,
         isa: &dyn TargetIsa,
     ) -> CodegenResult<Option<crate::isa::unwind::UnwindInfo>> {
+        if self.mach_compile_result.is_some() {
+            return Ok(self
+                .mach_compile_result
+                .as_ref()
+                .unwrap()
+                .unwind_info
+                .clone());
+        }
         isa.create_unwind_info(&self.func)
     }
 

cranelift/codegen/src/isa/aarch64/inst/emit.rs

@@ -481,6 +481,7 @@ impl MachInstEmitInfo for EmitInfo {
 impl MachInstEmit for Inst {
     type State = EmitState;
     type Info = EmitInfo;
+    type UnwindInfo = super::unwind::AArch64UnwindInfo;
 
     fn emit(&self, sink: &mut MachBuffer<Inst>, emit_info: &Self::Info, state: &mut EmitState) {
         // N.B.: we *must* not exceed the "worst-case size" used to compute

cranelift/codegen/src/isa/aarch64/inst/mod.rs

@@ -29,6 +29,7 @@ pub mod args;
 pub use self::args::*;
 pub mod emit;
 pub use self::emit::*;
+pub mod unwind;
 
 #[cfg(test)]
 mod emit_tests;

cranelift/codegen/src/isa/aarch64/inst/unwind.rs

@@ -0,0 +1,15 @@
+use super::*;
+use crate::isa::unwind::UnwindInfo;
+use crate::result::CodegenResult;
+
+pub struct AArch64UnwindInfo;
+
+impl UnwindInfoGenerator<Inst> for AArch64UnwindInfo {
+    fn create_unwind_info(
+        _context: UnwindInfoContext<Inst>,
+        _kind: UnwindInfoKind,
+    ) -> CodegenResult<Option<UnwindInfo>> {
+        // TODO
+        Ok(None)
+    }
+}

cranelift/codegen/src/isa/aarch64/mod.rs

@@ -77,6 +77,7 @@ impl MachBackend for AArch64Backend {
             buffer,
             frame_size,
             disasm,
+            unwind_info: None,
         })
     }
 

cranelift/codegen/src/isa/arm32/inst/emit.rs

@@ -274,6 +274,7 @@ impl MachInstEmitInfo for EmitInfo {
 impl MachInstEmit for Inst {
     type Info = EmitInfo;
     type State = EmitState;
+    type UnwindInfo = super::unwind::Arm32UnwindInfo;
 
     fn emit(&self, sink: &mut MachBuffer<Inst>, emit_info: &Self::Info, state: &mut EmitState) {
         let start_off = sink.cur_offset();

cranelift/codegen/src/isa/arm32/inst/mod.rs

@@ -22,6 +22,7 @@ mod emit;
 pub use self::emit::*;
 mod regs;
 pub use self::regs::*;
+pub mod unwind;
 
 #[cfg(test)]
 mod emit_tests;

cranelift/codegen/src/isa/arm32/inst/unwind.rs

@@ -0,0 +1,15 @@
+use super::*;
+use crate::isa::unwind::UnwindInfo;
+use crate::result::CodegenResult;
+
+pub struct Arm32UnwindInfo;
+
+impl UnwindInfoGenerator<Inst> for Arm32UnwindInfo {
+    fn create_unwind_info(
+        _context: UnwindInfoContext<Inst>,
+        _kind: UnwindInfoKind,
+    ) -> CodegenResult<Option<UnwindInfo>> {
+        // TODO
+        Ok(None)
+    }
+}

cranelift/codegen/src/isa/arm32/mod.rs

@@ -73,6 +73,7 @@ impl MachBackend for Arm32Backend {
             buffer,
             frame_size,
             disasm,
+            unwind_info: None,
         })
     }
 

cranelift/codegen/src/isa/mod.rs

@@ -87,7 +87,6 @@ mod arm32;
 #[cfg(feature = "arm64")]
 pub(crate) mod aarch64;
 
-#[cfg(feature = "unwind")]
 pub mod unwind;
 
 mod call_conv;