Fix a panic when opening a directory with truncate(true) (#388)

* Fix a panic when opening a directory with `truncate(true)`

This is intended to address bytecodealliance/wasmtime#10577

* Update CI runners

Author: alexcrichton

.github/workflows/main.yml

@@ -201,7 +201,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        build: [stable, windows-latest, windows-2019, macos-latest, macos-13, beta, ubuntu-20.04, aarch64-ubuntu]
+        build: [stable, windows-latest, windows-2019, macos-latest, macos-13, beta, ubuntu-22.04, aarch64-ubuntu]
         include:
           - build: stable
             os: ubuntu-latest
@@ -221,8 +221,8 @@ jobs:
           - build: beta
             os: ubuntu-latest
             rust: beta
-          - build: ubuntu-20.04
-            os: ubuntu-20.04
+          - build: ubuntu-22.04
+            os: ubuntu-22.04
             rust: stable
           - build: aarch64-ubuntu
             os: ubuntu-latest
@@ -332,13 +332,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        build: [ubuntu, ubuntu-20.04]
+        build: [ubuntu, ubuntu-22.04]
         include:
           - build: ubuntu
             os: ubuntu-latest
             rust: nightly
-          - build: ubuntu-20.04
-            os: ubuntu-20.04
+          - build: ubuntu-22.04
+            os: ubuntu-22.04
             rust: nightly
 
     env:

cap-primitives/src/windows/fs/open_unchecked.rs

@@ -205,12 +205,14 @@ fn handle_open_result(
             }
 
             // Windows truncates symlinks into normal files, so truncation
-            // may be disabled above; do it manually if needed.
+            // may be disabled above; do it manually if needed. Note that this
+            // is expected to always succeed for normal files, but this will
+            // fail if a directory was opened as directories don't support
+            // truncation.
             if manually_trunc {
-                // Unwrap is ok because 0 never overflows, and we'll only
-                // have `manually_trunc` set when the file is opened for
-                // writing.
-                f.set_len(0).unwrap();
+                if let Err(e) = f.set_len(0) {
+                    return Err(OpenUncheckedError::Other(e));
+                }
             }
             Ok(f)
         }

tests/fs.rs

@@ -1645,3 +1645,19 @@ fn create_dir_long_paths() {
         std::io::ErrorKind::NotFound
     );
 }
+
+/// Ensure that opening a directory with the truncation flag set is an error,
+/// not a panic inside of cap-std.
+#[test]
+fn open_directory_with_truncate_is_error() {
+    use cap_fs_ext::OpenOptionsMaybeDirExt;
+    let tmpdir = tmpdir();
+    let mut options = OpenOptions::new();
+    options
+        .truncate(true)
+        .maybe_dir(true)
+        .read(true)
+        .write(true);
+    tmpdir.create_dir("test").unwrap();
+    assert!(tmpdir.open_with("test", &options).is_err());
+}